Skip to content

Restore 'Pull arch from payload' and fix#813

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jottofar:ota-655-fixed
Aug 16, 2022
Merged

Restore 'Pull arch from payload' and fix#813
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jottofar:ota-655-fixed

Conversation

@jottofar
Copy link
Copy Markdown
Contributor

@jottofar jottofar commented Aug 3, 2022

by first restoring 0b8e83f.
Ths issue was that the 'SyncWorkerStatus.Architecture' was being clobbered
at

cluster-version-operator/pkg/cvo/sync_worker.go

Line 860 in 9d57cfc

status: SyncWorkerStatus{
.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@jottofar
Copy link
Copy Markdown
Contributor Author

jottofar commented Aug 3, 2022

/test e2e-agnostic-upgrade

1 similar comment
@jottofar
Copy link
Copy Markdown
Contributor Author

jottofar commented Aug 4, 2022

/test e2e-agnostic-upgrade

@jottofar
Copy link
Copy Markdown
Contributor Author

jottofar commented Aug 4, 2022

/payload 4.12 ci blocking

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 4, 2022

@jottofar: trigger 4 job(s) of type blocking for the ci release of OCP 4.12

  • periodic-ci-openshift-release-master-ci-4.12-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-azure-upgrade
  • periodic-ci-openshift-release-master-ci-4.12-e2e-aws-sdn-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ff492ef0-140d-11ed-809e-7bedec92052c-0

@jottofar
Copy link
Copy Markdown
Contributor Author

jottofar commented Aug 5, 2022

/hold
Hold until I understand why prior version failed payload tests but passed PR CI tests.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2022
@jottofar
Copy link
Copy Markdown
Contributor Author

jottofar commented Aug 8, 2022

/test unit

@jottofar jottofar force-pushed the ota-655-fixed branch 2 times, most recently from c023ef5 to 2c837db Compare August 10, 2022 14:10
@jottofar
Copy link
Copy Markdown
Contributor Author

jottofar commented Aug 15, 2022

/retest

@jottofar
Copy link
Copy Markdown
Contributor Author

jottofar commented Aug 15, 2022

/test e2e-agnostic-upgrade

@jottofar
Copy link
Copy Markdown
Contributor Author

jottofar commented Aug 15, 2022

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2022
LalatenduMohanty
LalatenduMohanty approved these changes Aug 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,jottofar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 15, 2022

/retest-required

Remaining retests: 2 against base HEAD 348add6 and 8 for PR HEAD da30c8e in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 16, 2022

/retest-required

Remaining retests: 1 against base HEAD 348add6 and 7 for PR HEAD da30c8e in total

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 16, 2022

/retest-required

Remaining retests: 0 against base HEAD 348add6 and 6 for PR HEAD da30c8e in total

@jottofar
Copy link
Copy Markdown
Contributor Author

jottofar commented Aug 16, 2022

This has passed previously and current failure not related to the changes in this PR.

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 16, 2022

@jottofar: Overrode contexts on behalf of jottofar: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

This has passed previously and current failure not related to the changes in this PR.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 16, 2022

@jottofar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit bfa3017 into openshift:master Aug 16, 2022
@wking
Copy link
Copy Markdown
Member

wking commented Aug 30, 2022 •
edited
Loading

There's a bugfix in #828. We're unlikely to backport this particular change, but commenting here in case we change our minds, so we remember to backport both this and the fix. [edit: oops, I need to make this comment on #805]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

1 more reviewer

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jottofar @openshift-ci-robot @wking @LalatenduMohanty @openshift-merge-robot