Bug 1778958: Remove serviceAccount in favour of serviceAccountName #3632

andrewballantyne · 2019-12-02T22:56:19Z

Pipeline Operator 0.8.0 deprecates serviceAccount in favour of serviceAccountName
Pipeline Operator 0.9.0 will make serviceAccount an invalid field

https://jira.coreos.com/browse/ODC-2439

andrewballantyne · 2019-12-02T22:57:30Z

/hold

Let's not get this in just yet. More investigation can be done to see the longevity of a Pipeline Operator and see if we can better transition rather than hard cut. 0.7.0 does NOT support the serviceAccountName field.

openshift-ci-robot · 2019-12-02T22:58:33Z

@andrewballantyne: This pull request references Bugzilla bug 1778958, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1778958: Remove serviceAccount in favour of serviceAccountName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2019-12-03T18:24:22Z

Resized this to allow for ports back to 4.3 & 4.2. The YAMLs are not used in todays scripts, so deleting them serves as nothing but potential conflict as I cherry pick to previous releases.

andrewballantyne · 2019-12-03T18:25:34Z

Waiting for Canary 0.9.0 before trying to push this through - shouldn't be too much longer. Once it's tested with 0.9.0, we should be good to go with this change & the backports.

andrewballantyne · 2019-12-03T18:26:22Z

frontend/packages/dev-console/src/utils/pipeline-actions.tsx

Going with a specific spread to allow wider version support.

andrewballantyne · 2019-12-03T18:26:57Z

frontend/packages/dev-console/src/utils/pipeline-actions.tsx

Prep for changing apiVersions (unrelated to this fix though - future assistance)

abhinandan13jan · 2019-12-05T13:42:01Z

/assign

abhinandan13jan · 2019-12-06T10:39:02Z

/lgtm

abhinandan13jan · 2019-12-06T11:46:45Z

/retest

- Pipeline Operator 0.8.0 deprecates serviceAccount in favour of serviceAccountName - Pipeline Operator 0.9.0 will make serviceAccount an invalid field

andrewballantyne · 2019-12-31T17:27:49Z

The Operator got the canary channel for 0.9.x. Tested it against the migration (from 0.8.x to 0.9.x) and saw there is a chance that the user created their own PipelineRun that has a serviceAccount and then the Operator got upgraded; this would cause a UI error preventing re-runs.

Changes since last review:

Added a migration that changes serviceAccount to serviceAccountName if it exists
Added tests for the migration code

andrewballantyne · 2020-01-02T19:54:08Z

/kind cleanup

andrewballantyne · 2020-01-02T23:39:34Z

/hold cancel
/retest
#3847 has fixed the e2e tests

frontend/packages/dev-console/src/utils/pipeline-actions.tsx

andrewballantyne · 2020-01-03T17:37:41Z

/retest

abhinandan13jan · 2020-01-06T13:01:56Z

/lgtm

openshift-ci-robot · 2020-01-06T13:02:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-06T13:02:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-01-06T16:38:00Z

@andrewballantyne: All pull requests linked via external trackers have merged. Bugzilla bug 1778958 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1778958: Remove serviceAccount in favour of serviceAccountName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2020-01-06T16:43:08Z

/cherry-pick release-4.3

openshift-cherrypick-robot · 2020-01-06T16:43:29Z

@andrewballantyne: new pull request created: #3869

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2020-01-06T17:42:19Z

/cherry-pick release-4.2

openshift-cherrypick-robot · 2020-01-06T17:42:26Z

@andrewballantyne: #3632 failed to apply on top of branch "release-4.2":

Using index info to reconstruct a base tree...
A	frontend/packages/dev-console/src/components/pipelines/detail-page-tabs/pipeline-details/__tests__/pipelinerun-mock.ts
M	frontend/packages/dev-console/src/utils/__tests__/pipeline-actions.spec.ts
M	frontend/packages/dev-console/src/utils/pipeline-actions.tsx
M	frontend/packages/dev-console/src/utils/pipeline-augment.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/utils/pipeline-augment.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/utils/pipeline-augment.ts
Auto-merging frontend/packages/dev-console/src/utils/pipeline-actions.tsx
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/utils/pipeline-actions.tsx
Auto-merging frontend/packages/dev-console/src/utils/__tests__/pipeline-actions.spec.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/utils/__tests__/pipeline-actions.spec.ts
Auto-merging frontend/packages/dev-console/src/components/pipelines/__tests__/pipelinerun-mock.ts
error: Failed to merge in the changes.
Patch failed at 0001 Handle serviceAccount migration to serviceAccountName

Details

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 2, 2019

openshift-ci-robot requested review from divyanshiGupta and sahil143 December 2, 2019 22:56

openshift-ci-robot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 2, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2019

andrewballantyne changed the title ~~Remove serviceAccount in favour of serviceAccountName~~ Bug 1778958: Remove serviceAccount in favour of serviceAccountName Dec 2, 2019

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 2, 2019

andrewballantyne force-pushed the pipelines-0.9.0-support branch from 90de6d5 to 21d85ef Compare December 3, 2019 18:23

openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 3, 2019

andrewballantyne commented Dec 3, 2019

View reviewed changes

openshift-ci-robot assigned abhinandan13jan Dec 5, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2019

Handle serviceAccount migration to serviceAccountName

8a37b94

- Pipeline Operator 0.8.0 deprecates serviceAccount in favour of serviceAccountName - Pipeline Operator 0.9.0 will make serviceAccount an invalid field

andrewballantyne force-pushed the pipelines-0.9.0-support branch from 21d85ef to 8a37b94 Compare December 31, 2019 17:24

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 31, 2019

andrewballantyne requested a review from abhinandan13jan January 2, 2020 16:36

openshift-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 2, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2020

abhinandan13jan reviewed Jan 3, 2020

View reviewed changes

frontend/packages/dev-console/src/utils/pipeline-actions.tsx Show resolved Hide resolved

andrewballantyne requested a review from abhinandan13jan January 5, 2020 22:00

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2020

openshift-merge-robot merged commit c12d0fc into openshift:master Jan 6, 2020

openshift-cherrypick-robot mentioned this pull request Jan 6, 2020

[release-4.3] Bug 1788201: Remove serviceAccount in favour of serviceAccountName #3869

Merged

andrewballantyne mentioned this pull request Jan 8, 2020

[release-4.2] Bug 1789119: Support for Pipeline Operator 0.9 on OpenShift 4.2 #3898

Merged

spadgett added this to the v4.4 milestone Jan 14, 2020

Bug 1778958: Remove serviceAccount in favour of serviceAccountName #3632

Bug 1778958: Remove serviceAccount in favour of serviceAccountName #3632

Uh oh!

Conversation

andrewballantyne commented Dec 2, 2019

Uh oh!

andrewballantyne commented Dec 2, 2019

Uh oh!

openshift-ci-robot commented Dec 2, 2019

Uh oh!

andrewballantyne commented Dec 3, 2019

Uh oh!

andrewballantyne commented Dec 3, 2019

Uh oh!

andrewballantyne Dec 3, 2019

Choose a reason for hiding this comment

Uh oh!

andrewballantyne Dec 3, 2019

Choose a reason for hiding this comment

Uh oh!

abhinandan13jan Dec 6, 2019

Choose a reason for hiding this comment

Uh oh!

abhinandan13jan commented Dec 5, 2019

Uh oh!

abhinandan13jan commented Dec 6, 2019

Uh oh!

abhinandan13jan commented Dec 6, 2019

Uh oh!

andrewballantyne commented Dec 31, 2019

Uh oh!

andrewballantyne commented Jan 2, 2020

Uh oh!

andrewballantyne commented Jan 2, 2020

Uh oh!

Uh oh!

andrewballantyne commented Jan 3, 2020

Uh oh!

abhinandan13jan commented Jan 6, 2020

Uh oh!

openshift-ci-robot commented Jan 6, 2020

Uh oh!

openshift-bot commented Jan 6, 2020

Uh oh!

openshift-ci-robot commented Jan 6, 2020

Uh oh!

andrewballantyne commented Jan 6, 2020

Uh oh!

openshift-cherrypick-robot commented Jan 6, 2020

Uh oh!

andrewballantyne commented Jan 6, 2020

Uh oh!

openshift-cherrypick-robot commented Jan 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants