Skip to content

[release-4.3] Bug 1788201: Remove serviceAccount in favour of serviceAccountName #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 4, 2020
Merged

[release-4.3] Bug 1788201: Remove serviceAccount in favour of serviceAccountName #3869

openshift-merge-robot merged 1 commit into from
Feb 4, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 6, 2020

This is an automated cherry-pick of #3632

/assign andrewballantyne

@andrewballantyne
Handle serviceAccount migration to serviceAccountName
266a61f 
- Pipeline Operator 0.8.0 deprecates serviceAccount in favour of
serviceAccountName
- Pipeline Operator 0.9.0 will make serviceAccount an invalid field
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 6, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 6, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1778958, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected Bugzilla bug 1778958 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1778958: Remove serviceAccount in favour of serviceAccountName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 6, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Jan 6, 2020
@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jan 6, 2020

/retitle [release-4.3] Bug 1788201: Remove serviceAccount in favour of serviceAccountName

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1778958: Remove serviceAccount in favour of serviceAccountName [release-4.3] Bug 1788201: Remove serviceAccount in favour of serviceAccountName Jan 6, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1788201, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1788201: Remove serviceAccount in favour of serviceAccountName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jan 6, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 6, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2020

@andrewballantyne: This pull request references Bugzilla bug 1788201, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 6, 2020
@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jan 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2020
@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jan 7, 2020

/assign @christianvogt

@andrewballantyne andrewballantyne mentioned this pull request Jan 8, 2020
Merged
@christianvogt
Copy link
Contributor

christianvogt commented Jan 8, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@christianvogt
Copy link
Contributor

christianvogt commented Jan 8, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2020

@christianvogt: This pull request references Bugzilla bug 1788201, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jan 10, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 10, 2020

@andrewballantyne: This pull request references Bugzilla bug 1788201, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jan 16, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2020

@andrewballantyne: This pull request references Bugzilla bug 1788201, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jan 22, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2020

@andrewballantyne: This pull request references Bugzilla bug 1788201, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.3.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jan 22, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2020

@andrewballantyne: This pull request references Bugzilla bug 1788201, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis
Copy link
Member

eparis commented Feb 4, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2020

@eparis: This pull request references Bugzilla bug 1788201, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit 1f7418a into openshift:release-4.3 Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 4, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1788201 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.3] Bug 1788201: Remove serviceAccount in favour of serviceAccountName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.3.z milestone Feb 17, 2020
meysam-jeffrey pushed a commit to snapp-incubator/console that referenced this pull request Dec 24, 2025
@openshift-merge-robot
Merge pull request openshift#3869 from openshift-cherrypick-robot/che…
cc1fc22 
…rry-pick-3632-to-release-4.3

[release-4.3] Bug 1788201: Remove serviceAccount in favour of serviceAccountName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

Assignees

@andrewballantyne andrewballantyne

@christianvogt christianvogt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3.z

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @openshift-ci-robot @andrewballantyne @christianvogt @eparis @spadgett @openshift-merge-robot