Skip to content

[release-4.2] Bug 1789119: Support for Pipeline Operator 0.9 on OpenShift 4.2 #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 9, 2020
Merged

[release-4.2] Bug 1789119: Support for Pipeline Operator 0.9 on OpenShift 4.2 #3898

openshift-merge-robot merged 1 commit into from
Jan 9, 2020

Conversation

@andrewballantyne
Copy link
Contributor

@andrewballantyne andrewballantyne commented Jan 8, 2020

4.2 back-port of #3632 (was manual due to code conflicts)

The 4.3 back-port is #3869

A necessary back-port to allow OpenShift Console code to work with Pipeline Operator v0.9.x.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2020

@andrewballantyne: This pull request references Bugzilla bug 1789119, which is invalid:

  • expected dependent Bugzilla bug 1778958 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1788201 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.2] Bug 1789119: Support for Pipeline Operator 0.9 on OpenShift 4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/dev-console Related to dev-console labels Jan 8, 2020
@andrewballantyne
Copy link
Contributor Author

andrewballantyne commented Jan 8, 2020

/lgtm

/assign @christianvogt

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2020

@andrewballantyne: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

/assign @christianvogt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christianvogt
Copy link
Contributor

christianvogt commented Jan 8, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2020

@christianvogt: This pull request references Bugzilla bug 1789119, which is invalid:

  • expected dependent Bugzilla bug 1778958 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christianvogt
Copy link
Contributor

christianvogt commented Jan 8, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@andrewballantyne
Copy link
Contributor Author

andrewballantyne commented Jan 8, 2020

/test e2e-gcp-console-olm

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@andrewballantyne
Copy link
Contributor Author

andrewballantyne commented Jan 8, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 8, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 8, 2020

@andrewballantyne: This pull request references Bugzilla bug 1789119, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 8, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit aa1f4bb into openshift:release-4.2 Jan 9, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2020

@andrewballantyne: All pull requests linked via external trackers have merged. Bugzilla bug 1789119 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.2] Bug 1789119: Support for Pipeline Operator 0.9 on OpenShift 4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.2.z milestone Jan 14, 2020
meysam-jeffrey pushed a commit to snapp-incubator/console that referenced this pull request Dec 24, 2025
@openshift-merge-robot
Merge pull request openshift#3898 from andrewballantyne/pipeline-oper…
242738b 
…ator-0.9-for-4.2

[release-4.2] Bug 1789119: Support for Pipeline Operator 0.9 on OpenShift 4.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

@sahil143 sahil143 Awaiting requested review from sahil143

Assignees

@christianvogt christianvogt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2.z

Development

Successfully merging this pull request may close these issues.

7 participants

@andrewballantyne @openshift-ci-robot @christianvogt @openshift-bot @mrunalp @spadgett @openshift-merge-robot