Pipeline Topology Implementation #4004

andrewballantyne · 2020-01-19T00:19:39Z

Fixes:
https://issues.redhat.com/browse/ODC-2605

Analysis / Root cause:
Implements the foundation of the Pipeline Builder and replaces the existing rendering logic to be more inline with what the Pipeline spec can present as a node network.

Solution Description:
Pulled the @console/topology code into Pipelines. This gives us the power of a layout engine and a free and open canvas to draw in.

Screen shots / Gifs for design review:
@openshift/team-devconsole-ux

Note: the top visualization is the same rendering issue from https://issues.redhat.com/browse/ODC-2464 fixed.

There are some unexpected outcomes out of the layout as of right now:

I have no current intent on addressing the above issues until after the Pipeline Builder feature is completed. We'll likely need to work on a constraint system with Dagre which may use "ghost" groups or something (unsure of the solution at this time).

Pipeline Runs:

Unit test coverage report:

TODO: Add tests

Test setup:

Install the OpenShift Pipeline Operator
Add pipelines (could install the ones from frontend/packages/dev-console/yamls/pipelines/install_pipeline_mocks.sh or create / upload your own)
View the new visualization in Pipeline and Pipeline Runs (and in the Add flow)

Browser conformance:

Chrome
Firefox
Safari
Edge

/kind feature
cc @jeff-phillips-18 @christianvogt

andrewballantyne · 2020-01-19T00:21:30Z

...console/src/components/pipelines/detail-page-tabs/pipeline-details/PipelineVisualization.tsx

@serenamarie125 I took a causal stab at solving https://issues.redhat.com/browse/ODC-1860 when I stumbled upon the issue in my work.

andrewballantyne · 2020-01-19T00:21:59Z

...le/src/components/pipelines/detail-page-tabs/pipeline-details/PipelineVisualizationTask.scss

I likely can gut a lot of this too... I just haven't looked too much into it.

andrewballantyne · 2020-01-19T00:29:04Z

...le/src/components/pipelines/detail-page-tabs/pipeline-details/pipeline-topology/factories.ts

@jeff-phillips-18 This is the hack we discussed - we need to find a better way for me to get a notification when the layout finishes.

andrewballantyne · 2020-01-19T00:31:03Z

frontend/packages/topology/src/layouts/DagreLayout.ts

All changes for DagreLayout were rushed and not really thought through. @jeff-phillips-18 @christianvogt Feel free to comment on direction / changes. I'll likely conflict with your work Jeff when it comes to your topology work.

We can reconcile once the changes are in, you can use the GRAPH_LAYOUT_END_EVENT event once its there.

serenamarie125 · 2020-01-19T22:22:55Z

@andrewballantyne this is looking really good! will this PR also cover the tooltips associated with the PLR visualization? I'm assuming they shouldn't be affected, but you never know :)

Is it also worth including screenshots of what the PL vs PLR visualizations look like?

andrewballantyne · 2020-01-20T10:26:52Z

@andrewballantyne this is looking really good! will this PR also cover the tooltips associated with the PLR visualization? I'm assuming they shouldn't be affected, but you never know :)

Is it also worth including screenshots of what the PL vs PLR visualizations look like?

Doh, of course, I'll update with it. I tested it under the hood but didn't post the screenshots 😦 Not sure what I was thinking haha.

andrewballantyne · 2020-01-20T10:52:48Z

@serenamarie125 Apologizes for that; Pipeline Runs have been added to the description (from the Pipeline Run details page).

andrewballantyne · 2020-01-20T17:19:17Z

/test backend

andrewballantyne · 2020-01-20T17:22:18Z

/retest

andrewballantyne · 2020-01-20T17:47:26Z

/retest

spadgett · 2020-01-20T18:17:23Z

/hold
this didn't actually pass e2e tests

spadgett · 2020-01-20T18:41:19Z

/hold cancel
rerunning tests

openshift-ci-robot · 2020-01-20T20:15:12Z

@andrewballantyne: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-console	`5f923f2`	link	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jeff-phillips-18 · 2020-01-23T22:03:05Z

frontend/packages/dev-console/src/components/pipelines/pipeline-topology/TaskEdge.tsx

+        endPoint.clone().translate(-targetNode.getBounds().width / 2, 0),
+      )}
+      stroke="var(--pf-global--BorderColor--light-100)"
+      fill="none"


Rather these styles be in a .scss file but ok.

jeff-phillips-18 · 2020-01-23T22:13:28Z

/lgtm

openshift-ci-robot · 2020-01-23T22:14:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrewballantyne, jeff-phillips-18
To complete the pull request process, please assign christianvogt
You can assign the PR to them by writing /assign @christianvogt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [andrewballantyne]
frontend/packages/topology/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andrewballantyne · 2020-01-23T22:54:15Z

Folded into #4055 for CI sanity.

openshift-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. component/dev-console Related to dev-console labels Jan 19, 2020

openshift-ci-robot requested review from abhi-kn and jeff-phillips-18 January 19, 2020 00:20

andrewballantyne commented Jan 19, 2020

View reviewed changes

andrewballantyne force-pushed the pipeline-topology-foundation branch 2 times, most recently from 725260d to c7e7a44 Compare January 19, 2020 03:00

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 19, 2020

andrewballantyne force-pushed the pipeline-topology-foundation branch from c7e7a44 to b745f71 Compare January 19, 2020 04:22

Pipeline Topology Implementation

5f923f2

andrewballantyne force-pushed the pipeline-topology-foundation branch from b745f71 to 5f923f2 Compare January 20, 2020 10:55

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020

This was referenced Jan 21, 2020

Pipeline builder visualization #4031

Closed

Pipeline builder page #4033

Closed

Pipeline builder task sidebar #4049

Closed

andrewballantyne mentioned this pull request Jan 23, 2020

Edit pipeline builder #4055

Merged

5 tasks

jeff-phillips-18 reviewed Jan 23, 2020

View reviewed changes

jeff-phillips-18 approved these changes Jan 23, 2020

View reviewed changes

openshift-ci-robot assigned jeff-phillips-18 Jan 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2020

andrewballantyne closed this Jan 23, 2020

Pipeline Topology Implementation #4004

Pipeline Topology Implementation #4004

Uh oh!

Conversation

andrewballantyne commented Jan 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewballantyne Jan 19, 2020

Choose a reason for hiding this comment

Uh oh!

andrewballantyne Jan 19, 2020

Choose a reason for hiding this comment

Uh oh!

andrewballantyne Jan 19, 2020

Choose a reason for hiding this comment

Uh oh!

andrewballantyne Jan 19, 2020

Choose a reason for hiding this comment

Uh oh!

jeff-phillips-18 Jan 23, 2020

Choose a reason for hiding this comment

Uh oh!

serenamarie125 commented Jan 19, 2020

Uh oh!

andrewballantyne commented Jan 20, 2020

Uh oh!

andrewballantyne commented Jan 20, 2020

Uh oh!

andrewballantyne commented Jan 20, 2020

Uh oh!

andrewballantyne commented Jan 20, 2020

Uh oh!

andrewballantyne commented Jan 20, 2020

Uh oh!

spadgett commented Jan 20, 2020

Uh oh!

spadgett commented Jan 20, 2020

Uh oh!

openshift-ci-robot commented Jan 20, 2020

Uh oh!

jeff-phillips-18 Jan 23, 2020

Choose a reason for hiding this comment

Uh oh!

jeff-phillips-18 commented Jan 23, 2020

Uh oh!

openshift-ci-robot commented Jan 23, 2020

Uh oh!

andrewballantyne commented Jan 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

andrewballantyne commented Jan 19, 2020 •

edited

Loading