Skip to content

Conversation

@andrewballantyne
Copy link
Contributor

Fixes:
Dependency on #4004 (https://issues.redhat.com/browse/ODC-2605) -- 1st commit
Dependency on #4031 (https://issues.redhat.com/browse/ODC-2448) -- 2nd commit
Dependency on #4033 (https://issues.redhat.com/browse/ODC-2447) -- 3rd commit
https://issues.redhat.com/browse/ODC-2449 -- 4th commit

Do review of the fourth commit while we wait for #4004, #4031 & #4033 to get in.

Analysis / Root cause:
After selecting a task, we want to stitch the values into the task so we can get a more complete Pipeline out of the Pipeline Builder.

Solution Description:
Implemented a sidebar that allows setting of params and resources, as well as changing the visual name of the task.

Screen shots / Gifs for design review:

PipelineBuilderTaskSidebar

Missing items:

  • Add the ability to remove
  • Add validation for params

Unit test coverage report:

  • Unit Tests

Test setup:

  • Install the Pipeline Operator (this comes with cluster tasks from 0.8.x onwards)
  • Go to the Pipelines page and "Create Pipeline"

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 23, 2020
@andrewballantyne
Copy link
Contributor Author

/kind feature

cc @openshift/team-devconsole-ux

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 23, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Jan 23, 2020
@andrewballantyne andrewballantyne mentioned this pull request Jan 23, 2020
5 tasks
Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrewballantyne, serenamarie125
To complete the pull request process, please assign christianvogt
You can assign the PR to them by writing /assign @christianvogt in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Contributor Author

Folded into #4055 for CI sanity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/dev-console Related to dev-console kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants