-
Notifications
You must be signed in to change notification settings - Fork 667
Pipeline builder page #4033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline builder page #4033
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0b2f73d to
f10e525
Compare
serenamarie125
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far!
Selecting that task is rough ;) but not your implementation issue
I can probably cap the height of the popout - might make it a little nicer to work with. |
|
there are lint errors |
@abhinandan13jan There sure are! I'm having issues with my linter and I posted that in the |
f10e525 to
25ead20
Compare
| edges={edges} | ||
| layout={PipelineLayout.DAGRE_VIEWER} | ||
| /> | ||
| <div style={{ marginBottom: 'var(--pf-global--spacer--md)' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not marginBottom: global_spacer_md.value from patternfly/react-tokens? Both would do the same thing... I am unsure which is more appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was likely a hack to test something and stayed because it worked... probably should go into a scss file.
|
apart from one small comment, the third commit looks good. |
|
Folded into #4055 for CI sanity. |
Fixes:
Dependency on #4004 (https://issues.redhat.com/browse/ODC-2605) -- 1st commit
Dependency on #4031 (https://issues.redhat.com/browse/ODC-2448) -- 2nd commit
https://issues.redhat.com/browse/ODC-2447 -- 3rd commit
Do review of the third commit while we wait for #4004 & #4031 to get in.
Analysis / Root cause:
With the work done in #4004 and #4031 we needed a real user page to make use of the Pipeline Builder.
Solution Description:
Mount a formik page and form; stitching up the Pipeline Builder visualization from #4031.
Screen shots / Gifs for design review:

@openshift/team-devconsole-ux
Unit test coverage report:
Test setup:
Browser conformance:
/kind feature
/assign @christianvogt