Triggers start modal

[andrewballantyne]

Fixes:
https://issues.redhat.com/browse/ODC-3348

Analysis / Root cause:
Need a way to associate trigger resources with a Pipeline.

Solution Description:
Create a "Add Trigger" modal and under the hood bind everything together.

Main notes:

• Reworked PipelineResources form section (resources no longer create inside the modal)
  • No longer a sub-form in the PipelineResources
• Cleaned up a lot of misc Pipeline stuff to make good reuse where possible
• Modals are structured differently now to support flexibility
• Add Trigger Modal always requests new resources out of the gate
• Start Pipeline Modal always tries to make use of existing resources out of the gate

Screen shots / Gifs for design review:
@openshift/team-devconsole-ux

Add Trigger Modal:

Variables:

Use of variables mixed with static text:

Trigger Modal requests new resources to allow easy use of Parameters, but naturally not all resources need to be created fresh and thus can be referenced against existing resources:

TriggerTemplate that was created at the finish of the modal:

Unit test coverage report:

• Write some tests

Test setup:

• Need the OpenShift Pipelines Operator
• Need an existing Pipeline (ideally with at least one parameter or resource)
• Need a TriggerBinding resource in order to map
  • There is currently an awkward "nothing to do" when no TriggerBindings exist

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

/kind feature

[andrewballantyne]

cc @siamaksade @serenamarie125

I had to change the way the Pipeline Resources worked... I tried for several hours today to try and make a reuse of existing structure, but we cannot be creating resources mid-modal and still use that logic for Triggers as the TriggerBinding params cannot be referenced from a fully-created and stand alone PipelineResource.

It was too much duplicate not to impact the way the start modal was done as well. I prefer it this way tbh, resources shouldn't be created mid-modal - as if you cancel out, you shouldn't have extra resources.

[rohitkrai03]

/lgtm

[sahil143]

/lgtm

verified changes locally

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [andrewballantyne,rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[divyanshiGupta]

/retest

[andrewballantyne]

/retest

[andrewballantyne]

/retest

[andrewballantyne]

/test e2e-gcp-console

[spadgett]

/hold
for #5100

[spadgett]

/hold cancel
/retest