[release-v0.23] add patch of missing versions by devguyio · Pull Request #1389 · openshift/knative-eventing

devguyio · 2021-09-02T02:20:06Z

Add a patch which adds the dropped versions of all eventing APIs.

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

devguyio · 2021-09-02T06:48:28Z

still investigating why it failed but in the mean while I'll retest
/retest

matzew · 2021-09-02T06:57:34Z

We actually have to apply the patch file. It's not done automatically.

It's only done automatically when the branch is created

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

devguyio · 2021-09-02T07:06:14Z

We actually have to apply the patch file. It's not done automatically.

It's only done automatically when the branch is created

Done

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

matzew · 2021-09-02T08:46:43Z

The reconciler tests are PITA... b/c of KO - I can follow up on that

matzew · 2021-09-02T08:57:56Z

@devguyio please see here this patch for your branch: devguyio#2

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

matzew · 2021-09-02T10:47:17Z

@devguyio here is one more issue:
devguyio#3

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

matzew · 2021-09-02T13:02:56Z

    resources.go:61: Pod "brokerdlq-kgesnbxt" is invalid: spec.containers[0].image: Required value

matzew · 2021-09-02T13:21:36Z

@@ -24,7 +24,7 @@ spec:
  restartPolicy: "Never"
  containers:
    - name: eventshub
-      image: registry.ci.openshift.org/openshift/knative-v0.23.0:knative-eventing-test-eventshub
+      image: ko://knative.dev/reconciler-test/cmd/eventshub


ught... that's a revert we don't want ..

following up on that ...

@devguyio here we go devguyio#4

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

lberk · 2021-09-02T15:08:02Z

/lgtm

matzew · 2021-09-02T17:47:03Z

/retest

On Thu 2. Sep 2021 at 19:44, openshift-ci[bot] ***@***.***> wrote: @devguyio <https://github.com/devguyio>: The following test *failed*, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Rerun command ci/prow/47-reconciler-aws-ocp-47 61da85b <61da85b> link <https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_knative-eventing/1389/pull-ci-openshift-knative-eventing-release-v0.23-47-reconciler-aws-ocp-47/1433421973827883008> /test 47-reconciler-aws-ocp-47 Full PR test history <https://prow.ci.openshift.org/pr-history?org=openshift&repo=knative-eventing&pr=1389>. Your PR dashboard <https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:devguyio>. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#1389 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABGPTV5YVGOBUQNJAU7HBDT76ZV3ANCNFSM5DH32ZLA> .

-- Sent from Gmail Mobile

matzew · 2021-09-02T22:20:28Z

/retest

On Fri 3. Sep 2021 at 00:01, openshift-ci[bot] ***@***.***> wrote: @devguyio <https://github.com/devguyio>: The following test *failed*, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Rerun command ci/prow/47-reconciler-aws-ocp-47 61da85b <61da85b> link <https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_knative-eventing/1389/pull-ci-openshift-knative-eventing-release-v0.23-47-reconciler-aws-ocp-47/1433486649349640192> /test 47-reconciler-aws-ocp-47 Full PR test history <https://prow.ci.openshift.org/pr-history?org=openshift&repo=knative-eventing&pr=1389>. Your PR dashboard <https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:devguyio>. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#1389 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABGPTWDQTLFQBAVWNPCJKTT77X2PANCNFSM5DH32ZLA> .

-- Sent from Gmail Mobile

openshift-bot · 2021-09-03T00:24:32Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

devguyio · 2021-09-03T02:57:25Z

FAIL: kntest not installed, please clone knative test-infra repo and run `go install ./kntest/cmd/kntest` to install it

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

maschmid · 2021-09-03T06:24:48Z

@@ -62,7 +62,7 @@ func createCertTemplate(name, namespace string, notAfter time.Time) (*x509.Certi
 			Organization: []string{organization},
 			CommonName:   commonName,
 		},
-		SignatureAlgorithm:    x509.SHA256WithRSA,
+		SignatureAlgorithm:    x509.PureEd25519,


This would be a regression, won't work on FIPS enabled clusters.

ugh - yeah

related PR here: e7b9776#diff-37c9e2e0678e8fdad32b5400892c0e3c17f41abd8efcffbe108c8a31e180c0c0

maschmid · 2021-09-03T06:29:24Z

-	// regular update using the same manager name.
-	// Note that the APIVersion field is not related to the Subresource field and
-	// it always corresponds to the version of the main resource.
-	Subresource string `json:"subresource,omitempty" protobuf:"bytes,8,opt,name=subresource"`
 }


this revert would be a regression of 69d6d4e (SRVKS-790)

yeah 😄 just checked the same

matzew · 2021-09-03T06:29:31Z

-
-	// Subresource is the name of the subresource used to update that object, or
-	// empty string if the object was updated through the main resource. The
-	// value of this field is used to distinguish between managers, even if they
-	// share the same name. For example, a status update will be distinct from a
-	// regular update using the same manager name.
-	// Note that the APIVersion field is not related to the Subresource field and
-	// it always corresponds to the version of the main resource.
-	Subresource string `json:"subresource,omitempty" protobuf:"bytes,8,opt,name=subresource"`


this is another patch we would loos - for OCP 4.9

maschmid · 2021-09-03T06:30:55Z

-	metrics.Record(ctx, requestCountM.M(1))
+	metrics.RecordBatch(ctx, requestCountM.M(1),
+		// Convert time.Duration in nanoseconds to milliseconds
+		responseTimeInMsecM.M(float64(d.Milliseconds())))
 	return nil


This would be a regression of #1301

* Rollback certificate algorithm changes (knative#1281) (knative#1283) Co-authored-by: Markus Thömmes <markusthoemmes@me.com> * mute noisy metrics * [SRVKS-790] Patch subresource to unblock webhooks on 4.9 (knative#1361) Co-authored-by: Markus Thömmes <markusthoemmes@me.com> Co-authored-by: Stavros Kontopoulos <skontopo@redhat.com>

matzew · 2021-09-03T11:59:56Z

/retest

aliok

/lgtm
/approve

openshift-ci · 2021-09-03T15:05:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, devguyio, lberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [aliok,devguyio,lberk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

add patch of missing versions

17ee801

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

openshift-ci Bot requested review from markusthoemmes and matzew September 2, 2021 02:20

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021

Patch 0.23 with missing API versions

cbd4f9d

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

openshift-ci Bot added the area/test-and-release Issues or PRs related to test and release label Sep 2, 2021

remove the patch, it's not needed in other versions

f19b9d8

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

Using pre-built image from OCP registry (#2)

0931d60

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Apply ko publish patch to here ... (#3)

e0a955d

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

matzew reviewed Sep 2, 2021

View reviewed changes

One more thing.... (#4)

61da85b

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

openshift-ci Bot assigned lberk Sep 2, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021

Add logs to understand rekt progress

7cbbff8

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021

maschmid reviewed Sep 3, 2021

View reviewed changes

matzew reviewed Sep 3, 2021

View reviewed changes

maschmid reviewed Sep 3, 2021

View reviewed changes

aliok approved these changes Sep 3, 2021

View reviewed changes

openshift-ci Bot assigned aliok Sep 3, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021

openshift-merge-robot merged commit 6ae515e into openshift:release-v0.23 Sep 3, 2021

matzew mentioned this pull request Sep 4, 2021

[RELEASE-1.17] Add missing CRDs to migration post install openshift-knative/serverless-operator#1187

Merged

Conversation

devguyio commented Sep 2, 2021

Uh oh!

devguyio commented Sep 2, 2021

Uh oh!

matzew commented Sep 2, 2021

Uh oh!

devguyio commented Sep 2, 2021

Uh oh!

matzew commented Sep 2, 2021

Uh oh!

matzew commented Sep 2, 2021

Uh oh!

matzew commented Sep 2, 2021

Uh oh!

matzew commented Sep 2, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lberk commented Sep 2, 2021

Uh oh!

matzew commented Sep 2, 2021 via email

Uh oh!

matzew commented Sep 2, 2021 via email

Uh oh!

openshift-bot commented Sep 3, 2021

Uh oh!

devguyio commented Sep 3, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matzew commented Sep 3, 2021

Uh oh!

aliok left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Sep 3, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants