Skip to content

bug 1934085: UPSTREAM: 100128: [sig-scheduling] SchedulerPreemption|SchedulerPredicates|SchedulerPriorities: adjust some e2e tests to run in a single node cluster scenario#665

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
ingvagabund:backport-100128-single-node-sig-scheduling
Apr 15, 2021
Merged

Conversation

@ingvagabund
Copy link
Copy Markdown
Member

@ingvagabund ingvagabund commented Apr 14, 2021 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

To run the tests in a single node cluster, create two pods consuming 2/5 of the extended resource instead of one consuming 2/3.
The low priority pod will be consuming 2/5 of the extended resource instead so in case there's only a single node,
a high priority pod consuming 2/5 of the extended resource can be still scheduled. Thus, making sure only the low priority pod
gets preempted once the preemptor pod consuming 2/5 of the extended resource gets scheduled while keeping the high priority pod untouched.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Backporting upstream kubernetes#100128

To help unblock openshift/release#16290

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@ingvagabund
UPSTREAM: 100128: [sig-scheduling] SchedulerPreemption|SchedulerPredi…
af7298a 
…cates|SchedulerPriorities: adjust some e2e tests to run in a single node cluster scenario

Skip PodTopologySpread tests in a single node cluster scenario

validates basic preemption works|validates lower priority pod preemption by critical pod: allocate 4/5 instead of 2/3

To run the tests in a single node cluster, create two pods consuming 2/5 of the extended resource instead of one consuming 2/3.
The low priority pod will be consuming 2/5 of the extended resource instead so in case there's only a single node,
a high priority pod consuming 2/5 of the extended resource can be still scheduled. Thus, making sure only the low priority pod
gets preempted once the preemptor pod consuming 2/5 of the extended resource gets scheduled while keeping the high priority pod untouched.
@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Apr 14, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 14, 2021

@ingvagabund: the contents of this pull request could be automatically validated.

The following commits are valid:

@ingvagabund ingvagabund changed the title UPSTREAM: 100128: [sig-scheduling] SchedulerPreemption|SchedulerPredicates|SchedulerPriorities: adjust some e2e tests to run in a single node cluster scenario bug 1934085: UPSTREAM: 100128: [sig-scheduling] SchedulerPreemption|SchedulerPredicates|SchedulerPriorities: adjust some e2e tests to run in a single node cluster scenario Apr 14, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 14, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 14, 2021

@ingvagabund: This pull request references Bugzilla bug 1934085, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @kasturinarra

Details

In response to this:

bug 1934085: UPSTREAM: 100128: [sig-scheduling] SchedulerPreemption|SchedulerPredicates|SchedulerPriorities: adjust some e2e tests to run in a single node cluster scenario

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund mentioned this pull request Apr 14, 2021
Closed
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 14, 2021

@ingvagabund: This pull request references Bugzilla bug 1934085, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @kasturinarra

Details

In response to this:

bug 1934085: UPSTREAM: 100128: [sig-scheduling] SchedulerPreemption|SchedulerPredicates|SchedulerPriorities: adjust some e2e tests to run in a single node cluster scenario

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Apr 14, 2021

/retest

soltysh
soltysh approved these changes Apr 14, 2021
View reviewed changes
Copy link
Copy Markdown

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@soltysh
Copy link
Copy Markdown

soltysh commented Apr 14, 2021

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2021
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

16 similar comments
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6825c59 into openshift:master Apr 15, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 15, 2021

@ingvagabund: All pull requests linked via external trackers have merged:

Bugzilla bug 1934085 has been moved to the MODIFIED state.

Details

In response to this:

bug 1934085: UPSTREAM: 100128: [sig-scheduling] SchedulerPreemption|SchedulerPredicates|SchedulerPriorities: adjust some e2e tests to run in a single node cluster scenario

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the backport-100128-single-node-sig-scheduling branch April 15, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marun marun Awaiting requested review from marun

@mfojtik mfojtik Awaiting requested review from mfojtik

@kasturinarra kasturinarra Awaiting requested review from kasturinarra

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ingvagabund @openshift-ci-robot @soltysh @openshift-bot @openshift-merge-robot