CORS-4280: AWS: Add throughput validation for gp3 volumes by jhixson74 · Pull Request #1430 · openshift/machine-api-operator

jhixson74 · 2025-11-07T00:50:10Z

Throughput can only be configured on gp3 volumes and must be between 125 and 2000 MiB's

This pull request depends on openshift/api#2480

openshift-ci-robot · 2025-11-07T00:50:14Z

@jhixson74: This pull request references CORS-4280 which is a valid jira issue.

Details

In response to this:

Throughput can only be configured on gp3 volumes and must be between 125 and 2000 MiB's

This pull request depends on openshift/api#2480

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

damdo · 2025-11-13T08:26:06Z

/assign @JoelSpeed @damdo

damdo

/approve

/hold

For other reviews and in case you want to address my personal preference

openshift-ci · 2025-11-13T08:33:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

damdo · 2025-11-13T08:33:47Z

/test unit

damdo · 2025-11-15T09:12:55Z

@jhixson74 Needs rebasing

damdo · 2025-11-17T17:34:41Z

@jhixson74 Needs fixing, compilation is broken after rebase

jhixson74 · 2025-11-17T18:04:53Z

@jhixson74 Needs fixing, compilation is broken after rebase

I would expect compilation to not work since the new API field is required. Am I missing something else?

jhixson74 · 2025-11-17T18:06:50Z

@jhixson74 Needs fixing, compilation is broken after rebase

I would expect compilation to not work since the new API field is required. Am I missing something else?

Nevermind. I found it . Fixes coming soon. Thanks for the heads up.

damdo · 2025-11-17T19:34:34Z

@jhixson74 looks like something might still be off

jhixson74 · 2025-11-17T20:03:41Z

@jhixson74 looks like something might still be off

I am not seeing anything other than the expected ThroughputMib error. I tested this locally with a patched openshift/api and build and tests were fine. What is off?

damdo · 2025-11-18T15:15:28Z

# github.com/openshift/machine-api-operator/pkg/webhooks pkg/webhooks/machine_webhook.go:799:49: ebs.ThroughputMib undefined (type *"github.com/openshift/api/machine/v1beta1".EBSBlockDeviceSpec has no field or method ThroughputMib) pkg/webhooks/machine_webhook.go:804:27: ebs.ThroughputMib undefined (type *"github.com/openshift/api/machine/v1beta1".EBSBlockDeviceSpec has no field or method ThroughputMib)

according to the CI job

damdo · 2025-11-21T16:34:16Z

/test golint

damdo · 2025-11-21T17:35:58Z

/test unit

damdo · 2025-11-21T17:49:39Z

/retest

damdo · 2025-11-22T10:52:15Z

/retest

damdo

/lgtm

damdo · 2025-11-22T10:52:51Z

/unhold

damdo · 2025-11-22T15:00:28Z

/retest

damdo · 2025-11-23T08:45:40Z

/retest

openshift-ci · 2025-11-23T08:51:28Z

@jhixson74: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`710235e`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

tthvo · 2025-11-24T22:03:47Z

/retest

liweinan · 2025-11-25T16:18:42Z

Verified with the build: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1993316592309506048

Used the test script from: openshift/release#71426

cd /Users/weli/works/oc-swarm/release && mkdir -p /Users/weli/works/oc-swarm/openshift-versions/work/cluster-profile && cp /Users/weli/.aws/credentials /Users/weli/works/oc-swarm/openshift-versions/work/cluster-profile/.awscred && cp /Users/weli/works/oc-swarm/openshift-versions/work/install-config.yaml.bkup /Users/weli/works/oc-swarm/openshift-versions/work/install-config.yaml && cp /Users/weli/works/oc-swarm/openshift-versions/work/auth/kubeconfig /Users/weli/works/oc-swarm/openshift-versions/work/kubeconfig && export CLUSTER_PROFILE_DIR=/Users/weli/works/oc-swarm/openshift-versions/work/cluster-profile && export SHARED_DIR=/Users/weli/works/oc-swarm/openshift-versions/work && ci-operator/step-registry/cucushift/installer/check/aws/rootvolume/cucushift-installer-check-aws-rootvolume-commands.sh |& tee /Users/weli/works/oc-swarm/openshift-versions/work/gp3-throughput-check.log
Cluster ID: weli-test3-d7j8h
Region: us-east-1
Expected throughput: 500 MiB/s
Expected worker rootVolume size: 130 GiB
Expected control-plane rootVolume size: 130 GiB
Checking worker nodes
PASS: ip-10-0-114-239.ec2.internal volume vol-05752be10666a276c type=gp3 size=130GiB iops=3000 throughput=500MiB/s
PASS: ip-10-0-134-253.ec2.internal volume vol-0bee845cdf74607ac type=gp3 size=130GiB iops=3000 throughput=500MiB/s
PASS: ip-10-0-74-88.ec2.internal volume vol-089c5c17df90e0414 type=gp3 size=130GiB iops=3000 throughput=500MiB/s
Checking control plane nodes
PASS: ip-10-0-107-238.ec2.internal volume vol-0e9c5ae15dd92af10 type=gp3 size=130GiB iops=3000 throughput=500MiB/s
PASS: ip-10-0-40-2.ec2.internal volume vol-0aa07aeff7282dba5 type=gp3 size=130GiB iops=3000 throughput=500MiB/s
PASS: ip-10-0-90-23.ec2.internal volume vol-003cebc10ca7bf3a0 type=gp3 size=130GiB iops=3000 throughput=500MiB/s
==========================================
Test Summary
All root volume throughput checks passed.

liweinan · 2025-11-25T16:18:52Z

/verified

openshift-ci-robot · 2025-11-25T16:18:55Z

@liweinan: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

liweinan · 2025-11-25T16:19:11Z

/verified by liweinan

openshift-ci-robot · 2025-11-25T16:19:23Z

@liweinan: This PR has been marked as verified by liweinan.

Details

In response to this:

/verified by liweinan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…_throughput" This reverts commit 798f605, reversing changes made to 1d78f2e.

damdo · 2025-11-26T09:25:19Z

/test ?

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2025

openshift-ci Bot requested review from nrb and racheljpg November 7, 2025 00:50

This was referenced Nov 7, 2025

CORS-4277: Ensure Throughput setting is honoured on gp3 volumes openshift/machine-api-provider-aws#155

Merged

CORS-4212: AWS: Add the ability to configure throughput on GP3 volumes openshift/installer#9945

Merged

damdo mentioned this pull request Nov 13, 2025

CORS-4250: AWS: Add the ability to configure throughput on GP3 volumes openshift/api#2480

Merged

openshift-ci Bot assigned damdo and JoelSpeed Nov 13, 2025

damdo reviewed Nov 13, 2025

View reviewed changes

Comment thread pkg/webhooks/machine_webhook.go

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2025

jhixson74 force-pushed the main_aws_gp3_throughput branch from bc526a8 to 710235e Compare November 14, 2025 04:26

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2025

jhixson74 requested a review from damdo November 15, 2025 00:48

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2025

jhixson74 force-pushed the main_aws_gp3_throughput branch from 710235e to 38f58bd Compare November 17, 2025 17:14

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2025

jhixson74 force-pushed the main_aws_gp3_throughput branch from 38f58bd to cc98b67 Compare November 17, 2025 18:23

liweinan mentioned this pull request Nov 20, 2025

CORS-4212 openshift/release#71426

Merged

jhixson74 force-pushed the main_aws_gp3_throughput branch 2 times, most recently from a9f7897 to d0598c3 Compare November 21, 2025 16:11

jhixson74 added 4 commits November 21, 2025 08:46

AWS: Ensure throughput setting is configured correctly on gp3 volumes

d9f44eb

AWS: GP3 volume throughput tests

b92e3fa

Bump openshift/api for AWS GP3 changes

d7e7a75

go mod vendor for AWS GP3 changes

bb4779e

jhixson74 force-pushed the main_aws_gp3_throughput branch from d0598c3 to bb4779e Compare November 21, 2025 16:46

damdo reviewed Nov 22, 2025

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2025

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 25, 2025

openshift-merge-bot Bot merged commit 798f605 into openshift:main Nov 25, 2025
16 checks passed

jianlinliu added a commit to jianlinliu/machine-api-operator that referenced this pull request Nov 26, 2025

Revert "Merge pull request openshift#1430 from jhixson74/main_aws_gp3…

3071191

…_throughput" This reverts commit 798f605, reversing changes made to 1d78f2e.

jianlinliu mentioned this pull request Nov 26, 2025

TRT-2440: Revert #1430 "CORS-4280: AWS: Add throughput validation for gp3 volumes" #1439

Closed

Conversation

jhixson74 commented Nov 7, 2025

Uh oh!

openshift-ci-robot commented Nov 7, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

damdo commented Nov 13, 2025

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci Bot commented Nov 13, 2025

Uh oh!

damdo commented Nov 13, 2025

Uh oh!

damdo commented Nov 15, 2025

Uh oh!

damdo commented Nov 17, 2025

Uh oh!

jhixson74 commented Nov 17, 2025

Uh oh!

jhixson74 commented Nov 17, 2025

Uh oh!

damdo commented Nov 17, 2025

Uh oh!

jhixson74 commented Nov 17, 2025

Uh oh!

damdo commented Nov 18, 2025

Uh oh!

damdo commented Nov 21, 2025

Uh oh!

damdo commented Nov 21, 2025

Uh oh!

damdo commented Nov 21, 2025

Uh oh!

damdo commented Nov 22, 2025

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

damdo commented Nov 22, 2025

Uh oh!

damdo commented Nov 22, 2025

Uh oh!

damdo commented Nov 23, 2025

Uh oh!

openshift-ci Bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tthvo commented Nov 24, 2025

Uh oh!

liweinan commented Nov 25, 2025

Uh oh!

liweinan commented Nov 25, 2025

Uh oh!

openshift-ci-robot commented Nov 25, 2025

Uh oh!

liweinan commented Nov 25, 2025

Uh oh!

openshift-ci-robot commented Nov 25, 2025

Uh oh!

Uh oh!

damdo commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

openshift-ci-robot commented Nov 7, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci Bot commented Nov 23, 2025 •

edited

Loading