CORS-4277: Ensure Throughput setting is honoured on gp3 volumes#155
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jhixson74: This pull request references CORS-4277 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jhixson74: This pull request references CORS-4277 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
damdo
left a comment
damdo
left a comment
There was a problem hiding this comment.
Makes sense thanks.
Could we add a similar validation in the machine-api-operator webhooks and a bunch of unit tests? Thanks
|
jhixson74
force-pushed
the
main_aws_gp3_throughput
branch
from
4897e16 to
71f9ec4
Compare
|
/test unit images |
|
jhixson74
force-pushed
the
main_aws_gp3_throughput
branch
from
71f9ec4 to
fccfb5d
Compare
|
@jhixson74 same go mod replacement + tidy/vendor will be needed on this one. Thanks! |
jhixson74
force-pushed
the
main_aws_gp3_throughput
branch
from
fccfb5d to
c4c451d
Compare
|
/retest ci/prow/e2e-aws |
|
@jhixson74: The The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest e2e-aws |
|
@jhixson74: The The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws |
jhixson74
force-pushed
the
main_aws_gp3_throughput
branch
from
c4c451d to
8691fa4
Compare
|
/retest |
damdo
left a comment
damdo
left a comment
There was a problem hiding this comment.
/approve
/lgtm
/hold
For all CI jobs to pass/be green
openshift-ci
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
jhixson74
force-pushed
the
main_aws_gp3_throughput
branch
from
8691fa4 to
6cad282
Compare
|
The job failure ci/prow/e2e-aws-serial-1of2 is due to waiter timeout. We are investigating and handling it openshift/installer#10124 👍 |
|
ci/prow/e2e-aws failure seems related to AWS running out of capacity (i.e. unrelated to this change): Let's give it another run: /test e2e-aws e2e-aws-serial-1of2 okd-scos-e2e-aws-ovn |
|
/test e2e-aws-serial-1of2 Looks like the rate limiting and timeout exceed problem is gone. Not sure what's going with this one here. |
|
@jhixson74: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
openshift/machine-api-operator#1430 (comment) /verified by liweinan |
openshift-ci-robot
added
the
verified
|
@liweinan: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @damdo, since all e2e tests passed, may we remove the hold 😁 ? |
|
Dam indicated the holds were for e2e tests, so I think we're safe to remove /hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
6 participants
This PR depends on openshift/api#2480