Skip to content

CORS-4212 #71426

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
liweinan:CORS-4212
Dec 22, 2025
Merged

CORS-4212 #71426
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
liweinan:CORS-4212

Conversation

@liweinan
Copy link
Copy Markdown
Contributor

@liweinan liweinan commented Nov 17, 2025

CORS-4212
AWS GP3 Throughput Config

@liweinan liweinan marked this pull request as draft November 17, 2025 02:52
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2025
@liweinan liweinan marked this pull request as ready for review November 17, 2025 02:52
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2025
@openshift-ci openshift-ci Bot requested review from akostadinov, gpei and yapei November 17, 2025 02:52
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 17, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 19, 2025
@liweinan
Copy link
Copy Markdown
Contributor Author

liweinan commented Nov 20, 2025 •
edited by openshift-ci Bot
Loading

Test Result

❯ cd /Users/weli/works/oc-swarm/openshift-versions/test-gp3 && export KUBECONFIG=$PWD/auth/kubeconfig &
& oc get machines.machine.openshift.io -n openshift-machine-api -o json | jq '.items[0].spec.providerSpec.value.blockDevices[0].ebs'
{
  "encrypted": true,
  "iops": 0,
  "kmsKey": {
    "arn": ""
  },
  "volumeSize": 120,
  "volumeType": "gp3"
}

Config

platform:
  aws:
    region: us-east-1
    defaultMachinePlatform:
      rootVolume:
        type: gp3
        size: 120
        throughput: 500  # Note: field name is "throughput" (int64) in install-config

Manifests

./test-gp3/openshift/99_openshift-machine-api_master-control-plane-machine-set.yaml:83:                volumeSize: 120
./test-gp3/openshift/99_openshift-cluster-api_worker-machineset-0.yaml:36:              volumeSize: 120
./test-gp3/openshift/99_openshift-cluster-api_worker-machineset-1.yaml:36:              volumeSize: 120
./test-gp3/openshift/99_openshift-cluster-api_master-machines-2.yaml:25:          volumeSize: 120
./test-gp3/openshift/99_openshift-cluster-api_master-machines-0.yaml:25:          volumeSize: 120
./test-gp3/openshift/99_openshift-cluster-api_worker-machineset-4.yaml:36:              volumeSize: 120
./test-gp3/openshift/99_openshift-cluster-api_master-machines-1.yaml:25:          volumeSize: 120
./test-gp3/openshift/99_openshift-cluster-api_worker-machineset-2.yaml:36:              volumeSize: 120
./test-gp3/openshift/99_openshift-cluster-api_worker-machineset-3.yaml:36:              volumeSize: 120
❯ grep -rin 'volumetype'
./test-gp3/openshift/99_openshift-machine-api_master-control-plane-machine-set.yaml:84:                volumeType: gp3
./test-gp3/openshift/99_openshift-cluster-api_worker-machineset-0.yaml:37:              volumeType: gp3
./test-gp3/openshift/99_openshift-cluster-api_worker-machineset-1.yaml:37:              volumeType: gp3
./test-gp3/openshift/99_openshift-cluster-api_master-machines-2.yaml:26:          volumeType: gp3
./test-gp3/openshift/99_openshift-cluster-api_master-machines-0.yaml:26:          volumeType: gp3
./test-gp3/openshift/99_openshift-cluster-api_worker-machineset-4.yaml:37:              volumeType: gp3
./test-gp3/openshift/99_openshift-cluster-api_master-machines-1.yaml:26:          volumeType: gp3
./test-gp3/openshift/99_openshift-cluster-api_worker-machineset-2.yaml:37:              volumeType: gp3
./test-gp3/openshift/99_openshift-cluster-api_worker-machineset-3.yaml:37:              volumeType: gp3
❯ grep -rin 'throughput' *
test-gp3/.openshift_install.log:53:time="2025-11-20T16:14:47+08:00" level=warning msg="failed to parse first occurrence of unknown field: failed to unmarshal install-config.yaml: error unmarshaling JSON: while decoding JSON: json: unknown field \"throughput\""

gp3 Throughput Findings

  • Every generated Machine object (control plane and workers) lacks throughputMib in providerSpec.blockDevices[].ebs; the JSON retrieved via oc get machines.machine.openshift.io -o json shows only volumeType: "gp3" and volumeSize: 120. Without throughputMib, AWS keeps the default 125 MiB/s, so the gp3 throughput configuration never takes effect.

  • The Cluster API AWSMachine resources also omit spec.rootVolume.throughput, confirming that the ControlPlaneMachineSet did not propagate the field either.

Conclusion: No runtime manifest carries the gp3 throughput setting, so EC2 volumes will remain at the default throughput and the CORS-4212 verification cannot be satisfied. Use an installer payload that already includes gp3 throughput support (or manually add throughputMib: 500 / rootVolume.throughput: 500 in the Machine/MachineSet/AWSMachine specs) before validating the AWS-side volume properties.

@liweinan
Copy link
Copy Markdown
Contributor Author

liweinan commented Nov 20, 2025

Relative PRs: openshift/machine-api-operator#1430 / openshift/machine-api-provider-aws#155 / openshift/api#2480 / openshift/installer#9945

gpei
gpei reviewed Nov 21, 2025
View reviewed changes
Comment thread ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-commands.sh Outdated
Comment thread .../installer/check/aws/gp3-throughput/cucushift-installer-check-aws-gp3-throughput-commands.sh Outdated
Comment thread .../installer/check/aws/gp3-throughput/cucushift-installer-check-aws-gp3-throughput-commands.sh Outdated
Comment thread .../installer/check/aws/gp3-throughput/cucushift-installer-check-aws-gp3-throughput-commands.sh Outdated
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 24, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 24, 2025
@liweinan
Copy link
Copy Markdown
Contributor Author

liweinan commented Nov 24, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-aws-ipi-rootvolume-gp3-throughput

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 24, 2025

@liweinan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@liweinan
Copy link
Copy Markdown
Contributor Author

liweinan commented Nov 24, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-aws-ipi-rootvolume-gp3-throughput

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 24, 2025

@liweinan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@liweinan
Copy link
Copy Markdown
Contributor Author

liweinan commented Nov 24, 2025

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-aws-ipi-rootvolume-gp3-throughput

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 24, 2025

@liweinan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 17, 2025

@liweinan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@liweinan
Copy link
Copy Markdown
Contributor Author

liweinan commented Dec 17, 2025

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f7 periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f28-destructive

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 17, 2025

@liweinan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@liweinan
Copy link
Copy Markdown
Contributor Author

liweinan commented Dec 17, 2025

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f7 periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f28-destructive

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 17, 2025

@liweinan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@liweinan
Copy link
Copy Markdown
Contributor Author

liweinan commented Dec 18, 2025

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f7 periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f28-destructive

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 18, 2025

@liweinan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 19, 2025

[REHEARSALNOTIFIER]
@liweinan: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f7 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f28-destructive N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@liweinan
Copy link
Copy Markdown
Contributor Author

liweinan commented Dec 19, 2025

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f7 periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f28-destructive

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 19, 2025

@liweinan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 20, 2025

@liweinan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-aws-ipi-rootvolume-gp3-throughput-split eeefe35 link unknown /pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-aws-ipi-rootvolume-gp3-throughput-split
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-gp3-throughput-default b9da9a9 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-gp3-throughput-default
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-gp3-throughput-split b9da9a9 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-gp3-throughput-split
ci/rehearse/periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-aws-ipi-rootvolume-gp3-throughput 4b7b099 link unknown /pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-aws-ipi-rootvolume-gp3-throughput
ci/rehearse/periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-aws-ipi-rootvolume-gp3-throughput-hybrid 4b7b099 link unknown /pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-aws-ipi-rootvolume-gp3-throughput-hybrid
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-gp3-throughput-edge-f28-destructive 5a2d3b4 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-gp3-throughput-edge-f28-destructive
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-default-f7 f286f84 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-default-f7
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-individual-f7 f286f84 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-individual-f7
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-individual-f28-destructive 8a0cf78 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-individual-f28-destructive
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-default-f28-destructive 8a0cf78 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-rootvolume-default-f28-destructive
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f7 6df0517 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f7
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f28-destructive 6df0517 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-aws-ipi-localzone-rootvolume-f28-destructive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@liweinan
Copy link
Copy Markdown
Contributor Author

liweinan commented Dec 22, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 22, 2025

@liweinan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 22, 2025
@liweinan
Copy link
Copy Markdown
Contributor Author

liweinan commented Dec 22, 2025

@yunjiang29 I have finished working on this PR, could you please help to review it? Thanks!

@yunjiang29
Copy link
Copy Markdown
Contributor

yunjiang29 commented Dec 22, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2025
@yunjiang29
Copy link
Copy Markdown
Contributor

yunjiang29 commented Dec 22, 2025

@liangxia Please approve this PR, thanks

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangxia, liweinan, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit b6a22f2 into openshift:master Dec 22, 2025
17 of 19 checks passed
sjug pushed a commit to sjug/release that referenced this pull request Jan 30, 2026
@liweinan @sjug
CORS-4212 AWS GP3 Throughput Config (openshift#71426)
6e38182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yapei yapei Awaiting requested review from yapei

@akostadinov akostadinov Awaiting requested review from akostadinov

4 more reviewers

@gpei gpei gpei left review comments

@yunjiang29 yunjiang29 yunjiang29 left review comments

@tthvo tthvo tthvo left review comments

@liangxia liangxia liangxia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liangxia liangxia

@yunjiang29 yunjiang29

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@liweinan @openshift-ci-robot @yunjiang29 @gpei @liangxia @tthvo @openshift-merge-robot