Skip to content

sync layering with master#2990

Merged
openshift-merge-robot merged 10 commits intoopenshift:layeringfrom
cheesesashimi:zzlotnik/update-layering-branch
Mar 8, 2022
Merged

sync layering with master#2990
openshift-merge-robot merged 10 commits intoopenshift:layeringfrom
cheesesashimi:zzlotnik/update-layering-branch

Conversation

@cheesesashimi
Copy link
Copy Markdown
Member

Syncs the layering branch with master.

andreaskaris and others added 10 commits February 23, 2022 11:50
When NetworkManager is restarted, all interfaces are removed from the
external bridge (br-ex / breth0). By default, ports' OVS IDs
change and the existing flows point to wrong 'output:' port numbers
leading to packet drops of all traffic that originates at
LOCAL and the node will not be able to request an IP address via DHCP.
Request fixed ofport numbers via the ofport_request field.

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
Signed-off-by: Qi Wang <qiwan@redhat.com>
Fix: https://bugzilla.redhat.com/show_bug.cgi?id=2050466
Add validation for image and icsp CR to not allow the empty string ("") in the CRD.
Empty string regsitries configurations will fail the machine config deamon operations
of pulling images and the nodes will stopped in NotReady state when node rebooting after node drain.

Signed-off-by: Qi Wang <qiwan@redhat.com>
Signed-off-by: Qi Wang <qiwan@redhat.com>
Bug 2050466: Not allow empty string in icsp&image CR
This adds support for a new RHCOS extension called "kerberos".

It will allow users to kerberize their NFS mounts.
Bug 2048352: ovn-kubernetes: Fixed ofport_request for physical ports
This has been dead code since openshift@d08090d

I was briefly confused by this when trying to figure out a different
bug around why my change to add a new field to controllerconfig
wasn't working.
@openshift-ci openshift-ci Bot requested review from mtrmac and yuqi-zhang March 7, 2022 21:13
@cgwalters
Copy link
Copy Markdown
Member

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
@cgwalters
Copy link
Copy Markdown
Member

OK yeah, this is definitely a case where we want to bypass CI
/skip
/hop
/jump

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 8, 2022

@cheesesashimi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-single-node 1cab2b2 link false /test e2e-gcp-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 3a91c46 into openshift:layering Mar 8, 2022
@cheesesashimi cheesesashimi deleted the zzlotnik/update-layering-branch branch March 21, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. layering lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants