Skip to content

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Jan 27, 2020

Manual cherry-pick of #266 b/c this is touching deps.

/assign @deads2k

smarterclayton and others added 20 commits October 2, 2019 19:34
The --force flag is dangerous and potentially allows untrusted
content to be upgraded to accidentally. Instead, introduce two
new flags `--allow-explicit-upgrade` (for upgrading to something not
in availableVersions) and `--allow-upgrade-with-warnigns` (for upgrading
when another upgrade is in progress or the cluster is reporting
an error) and remove those checks from `--force`.

While this is an API change, it is necessary to ensure that users
do not accidentally get access to untrusted content when
performing upgrades across major versions in advance of graph
updates, or when they are upgrading in disconnected environments.
Bug 1756454: Separate upgrade flags for safety instead of abusing force
We mirror the manifest list and blobs, but not the sub manifests.
Correct that by registering those with the plan. We must then
upload dependent manifests first, since the registry will not allow
partial manifest lists.
Bug 1760269: UPSTREAM: 77874: fix CVE-2019-11244: kubectl --http-cache=<world-accessible dir>
In some cases the FROM statement on a Dockerfile may contain an extra
alias, e.g.:

FROM fedora:latest AS builder

This commit fixes the parser to use only the second parsed node on the
FROM statement(on this case "fedora:latest") instead of returning the
last one(on this case "builder").
In order for console-operator deployment to succeed, cli-artifacts needs
to be available on all arches for downloads-openshift-console.  However,
in that case, /usr/bin/oc (inherited from cli) is a native binary, and
we want to provide all primary Linux architectures to match those on
mirror.openshift.com.

In order to do so, this provides cross-compiled Linux binaries for
multiple architectures.  Cross-compiling oc fails with gssapi enabled,
therefore it is disabled in the cross builds.

(cherry picked from commit e949088)
(squashed commit 2510f47)
Bug 1771420: Update ruby-22-centos7 to ruby-25-centos7
Bug 1773807: Enable all Linux arches in cli-artifacts [4.2]
…ry-pick-124-to-release-4.2

Bug 1761922: Manifest lists can fail to mirror because dependent manifests are not uploaded
…ry-pick-136-to-release-4.2

Bug 1770741: Fixed Dockerfile FROM statement parser.
Bug 1772463: Set TypeSetter in get print flags, like we do everywhere elsewhere
[release-4.2] Bug 1776495: don't install quota CRDs
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 27, 2020
@openshift-ci-robot
Copy link

@soltysh: This pull request references Bugzilla bug 1795312, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "4.2.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1795312: initialize auth plugins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Contributor Author

soltysh commented Jan 27, 2020

Wrong branch 🤦‍♂️

@soltysh soltysh closed this Jan 27, 2020
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 27, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2020
@openshift-ci-robot
Copy link

@soltysh: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

@soltysh: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@soltysh: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-cmd 548ecae link /test e2e-cmd
ci/prow/verify 548ecae link /test verify
ci/prow/e2e-aws 548ecae link /test e2e-aws
ci/prow/unit 548ecae link /test unit
ci/prow/e2e-aws-builds 548ecae link /test e2e-aws-builds
ci/prow/build-rpms-from-tar 548ecae link /test build-rpms-from-tar
ci/prow/e2e-aws-upgrade 548ecae link /test e2e-aws-upgrade
ci/prow/images 548ecae link /test images
ci/prow/rpm-build 548ecae link /test rpm-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants