Skip to content

tests: Add skip-console-warnings to global kola config#1128

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:skip-console-checks
Jan 30, 2023
Merged

tests: Add skip-console-warnings to global kola config#1128
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:skip-console-checks

Conversation

@cgwalters
Copy link
Copy Markdown
Member

@openshift-ci openshift-ci Bot requested review from aaradhak and ashcrow January 30, 2023 13:54
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2023
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Jan 30, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Jan 30, 2023

/lgtm cancel

Wait, shouldn't this have something like:

  osversion:
    - c9s
    - rhel-9.0

?

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023
@cgwalters
Copy link
Copy Markdown
Member Author

Wait, shouldn't this have something like:

Yes...but we're not going to care about rhel8 very quickly on this branch so...does it matter?

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Jan 30, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 30, 2023

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit eb0c766 into openshift:master Jan 30, 2023
@dustymabe
Copy link
Copy Markdown
Member

Note that with this change we're now ignoring other failures:

[2023-02-07T22:03:13.487Z] === RUN   basic
[2023-02-07T22:03:39.977Z] === RUN   basic/MachineID
[2023-02-07T22:03:39.977Z] === RUN   basic/RHCOSGrowpart
[2023-02-07T22:03:39.977Z] === RUN   basic/PortSSH
[2023-02-07T22:03:39.977Z] === RUN   basic/DbusPerms
[2023-02-07T22:03:39.977Z] === RUN   basic/ServicesActive
[2023-02-07T22:03:39.977Z] === RUN   basic/ReadOnly
[2023-02-07T22:03:39.977Z] === RUN   basic/Useradd
[2023-02-07T22:03:40.897Z] 2023-02-07T22:03:40Z kola: Found systemd generator failure (/usr/lib/systemd/system-generators/podman-system-generator) on machine 1c7134f1-2fdd-4c7f-a3ad-3523d6bd364a console
[2023-02-07T22:03:40.897Z] --- PASS: basic (27.44s)

travier added a commit to travier/os that referenced this pull request Mar 14, 2023
travier added a commit to travier/os that referenced this pull request Mar 14, 2023
travier added a commit to travier/os that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants