Skip to content

[release-4.13] Revert "tests: Add skip-console-warnings to global kola config"#1303

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
travier:release-4.13-revert-skip-console
Jun 7, 2023
Merged

[release-4.13] Revert "tests: Add skip-console-warnings to global kola config"#1303
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
travier:release-4.13-revert-skip-console

Conversation

@travier
Copy link
Copy Markdown
Member

@travier travier commented Jun 1, 2023 •
edited
Loading

Fixes: #1160
See: #1128
See: https://bugzilla.redhat.com/show_bug.cgi?id=2164765

This reverts commit 010cb8b.

(cherry picked from commit e82af1c)

Cherry-picked from #1175

@travier travier mentioned this pull request Jun 1, 2023
Merged
@openshift-ci openshift-ci Bot requested review from ashcrow and marmijo June 1, 2023 13:28
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2023

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dustymabe
Copy link
Copy Markdown
Member

dustymabe commented Jun 1, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dustymabe dustymabe changed the title Revert "tests: Add skip-console-warnings to global kola config" [release-4.13] Revert "tests: Add skip-console-warnings to global kola config" Jun 1, 2023
@travier
Copy link
Copy Markdown
Member Author

travier commented Jun 2, 2023

/hold
This still needs other changes
/label cherry-pick-approved
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jun 2, 2023
@travier
Copy link
Copy Markdown
Member Author

travier commented Jun 2, 2023

My bad, confused that with another PR.
/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
@travier
Copy link
Copy Markdown
Member Author

travier commented Jun 2, 2023

@mrunalp I need a valid bug override. This has been merged in 4.14 already and this is only about our tests, not a feature or a change.

@travier
Copy link
Copy Markdown
Member Author

travier commented Jun 7, 2023

@sdodson @mrunalp Can I get a valid bug override?

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Jun 7, 2023

/label jira/valid-bug

@openshift-ci openshift-ci Bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit cd5dd0a into openshift:release-4.13 Jun 7, 2023
@travier travier deleted the release-4.13-revert-skip-console branch June 7, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashcrow ashcrow Awaiting requested review from ashcrow

@marmijo marmijo Awaiting requested review from marmijo

Assignees

@dustymabe dustymabe

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@travier @dustymabe @sdodson @openshift-merge-robot