Skip to content

Revert "tests: Add skip-console-warnings to global kola config"#1175

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
travier:re-add-console-warnings
Jun 1, 2023
Merged

Revert "tests: Add skip-console-warnings to global kola config"#1175
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
travier:re-add-console-warnings

Conversation

@travier
Copy link
Copy Markdown
Member

@travier travier commented Feb 23, 2023 •
edited
Loading

Revert "tests: Add skip-console-warnings to global kola config"

Fixes: #1160
See: #1128
See: https://bugzilla.redhat.com/show_bug.cgi?id=2164765

Kept for C9S until the podman build lands there.

This reverts commit 010cb8b.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2023
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Feb 27, 2023

Woohoo!

/lgtm
/approve
/retest

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 27, 2023

/retest-required

Remaining retests: 0 against base HEAD 960df71 and 2 for PR HEAD b84f487 in total

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Feb 28, 2023

It turns out we were also hitting

    harness.go:1566: Found systemd generator failure (/usr/lib/systemd/system-generators/podman-system-generator) on machine 24eacb44-8c1b-4764-9595-ab78fcc413af console

which needs containers/podman@f135252
to also be backported.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 28, 2023

/retest-required

Remaining retests: 0 against base HEAD 5b027c6 and 1 for PR HEAD b84f487 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 28, 2023

/retest-required

Remaining retests: 0 against base HEAD 413dfe5 and 0 for PR HEAD b84f487 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 1, 2023

/hold

Revision b84f487 was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2023
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 6, 2023

/retest

@travier travier force-pushed the re-add-console-warnings branch from b84f487 to 005a262 Compare March 6, 2023 15:27
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 8, 2023

/unhold
/retest

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2023
@travier travier force-pushed the re-add-console-warnings branch from 005a262 to 4a6b76e Compare March 9, 2023 14:13
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 10, 2023

/retest

@travier travier force-pushed the re-add-console-warnings branch from 4a6b76e to 44e569a Compare March 10, 2023 09:22
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 10, 2023

Waiting for #1189

@travier travier force-pushed the re-add-console-warnings branch from 44e569a to ac0f6e8 Compare March 10, 2023 18:01
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 13, 2023

/retest

@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 13, 2023

Still waiting on a new podman build.

@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 13, 2023

/test images
/retest

1 similar comment
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 14, 2023

/test images
/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2023
@travier travier force-pushed the re-add-console-warnings branch from ac0f6e8 to 2419a93 Compare March 14, 2023 15:03
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2023
@travier travier mentioned this pull request Mar 14, 2023
Merged
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 15, 2023

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2023
@travier travier force-pushed the re-add-console-warnings branch from 2419a93 to 0b3380e Compare March 15, 2023 15:32
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2023
@travier
Copy link
Copy Markdown
Member Author

travier commented Mar 16, 2023

/retest

@travier travier force-pushed the re-add-console-warnings branch from 0b3380e to 8ce0fb3 Compare March 16, 2023 13:12
@travier travier force-pushed the re-add-console-warnings branch from 8ce0fb3 to a5773ad Compare March 29, 2023 11:08
Adam0Brien
Adam0Brien approved these changes Mar 29, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Adam0Brien Adam0Brien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travier
Copy link
Copy Markdown
Member Author

travier commented Apr 12, 2023

/test images

@travier travier force-pushed the re-add-console-warnings branch from a5773ad to 09f5636 Compare April 12, 2023 12:55
@travier
Copy link
Copy Markdown
Member Author

travier commented Apr 12, 2023

/retest

@jlebon
Copy link
Copy Markdown
Member

jlebon commented Apr 13, 2023

Looks like SCOS timed out.
/retest

@travier travier force-pushed the re-add-console-warnings branch from 09f5636 to ee1c90e Compare May 19, 2023 09:31
@travier travier force-pushed the re-add-console-warnings branch from ee1c90e to e82af1c Compare May 23, 2023 07:26
@dustymabe
Copy link
Copy Markdown
Member

dustymabe commented May 30, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adam0Brien, dustymabe, jlebon, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Adam0Brien,dustymabe,jlebon,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 30, 2023

/retest-required

Remaining retests: 0 against base HEAD 3fce236 and 2 for PR HEAD e82af1c in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 31, 2023

/retest-required

Remaining retests: 0 against base HEAD a321ec6 and 1 for PR HEAD e82af1c in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 31, 2023 •
edited
Loading

@travier: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-90-build-test-metal 2419a93 link true /test rhcos-90-build-test-metal
ci/prow/rhcos-86-build-test-metal 2419a93 link true /test rhcos-86-build-test-metal
ci/prow/rhcos-86-build-test-qemu 2419a93 link true /test rhcos-86-build-test-qemu
ci/prow/rhcos-90-build-test-qemu 2419a93 link true /test rhcos-90-build-test-qemu

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@travier
Copy link
Copy Markdown
Member Author

travier commented Jun 1, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit e85c1e3 into openshift:master Jun 1, 2023
@travier travier deleted the re-add-console-warnings branch June 1, 2023 13:20
@travier
Copy link
Copy Markdown
Member Author

travier commented Jun 1, 2023

/cherrypick release-4.13

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jun 1, 2023

@travier: #1175 failed to apply on top of branch "release-4.13":

Applying: Revert "tests: Add `skip-console-warnings` to global kola config"
Using index info to reconstruct a base tree...
M	kola-denylist.yaml
Falling back to patching base and 3-way merge...
Auto-merging kola-denylist.yaml
CONFLICT (content): Merge conflict in kola-denylist.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Revert "tests: Add `skip-console-warnings` to global kola config"
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier travier mentioned this pull request Jun 1, 2023
Merged
@travier
Copy link
Copy Markdown
Member Author

travier commented Jun 1, 2023

4.13 in #1303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gursewak1997 gursewak1997 Awaiting requested review from gursewak1997

1 more reviewer

@Adam0Brien Adam0Brien Adam0Brien approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dustymabe dustymabe

@jlebon jlebon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[4.13-9.2] Revert: tests: Add skip-console-warnings to global kola config

8 participants

@travier @jlebon @openshift-ci-robot @cgwalters @dustymabe @openshift-cherrypick-robot @Adam0Brien @openshift-merge-robot