PBID-450: enrich auction.hasUserData#33
Merged
Jimmy Tu (jimee02) merged 6 commits intoopenx-adapterfrom Jun 11, 2020
Merged
Conversation
added 5 commits
June 10, 2020 16:37
mocking over mocking "sinon.useFakeTimers" was messing up unrelated tests for other adapters
it returns a list of id module name that have non-empty user data
Kenan Gillet (kenan-gillet)
requested review from
Harman Goei (hrgui) and
Jimmy Tu (jimee02)
Harman Goei (hrgui)
approved these changes
Jun 10, 2020
Author
|
Jimmy Tu (@jimee02) if it is ok with you can you merge it and update the sigmoid testing setup ? thanks |
it seems to not be supported on some browser supported by PrebidJS see https://stackoverflow.com/questions/52283892/transpiling-array-prototype-flat-away-with-babel
Jimmy Tu (jimee02)
approved these changes
Jun 11, 2020
| return utils._map(userId, (id, module) => { | ||
| return hasUserData(module, id) ? module : false | ||
| }).filter(module => module); | ||
| }).reduce(utils.flatten, []).filter(utils.uniques).sort(); |
|
TY for fixing the linting around openrtb bidder |
|
Kenan Gillet (@kenan-gillet) deployed to adservertesting |
Gabriela Międlar (gmiedlar-ox)
pushed a commit
that referenced
this pull request
Jul 17, 2025
…rameters (prebid#13122) * V 0 29 (#31) * AGT-403: Add adType parameter to payload in report * AGT-403: Test for partner report, adType parameter * AGT-403: Test refactoring * AGT-403: Documentation updated * IntentIq Analytics Module: adUnitCode or placemetId to report (#9) * AGT-446: adUnitCode or placemetId to report * AGT-446: Description of changes, example * AGT-446: Fix documentation * AGT-446: Changes after review * Agt 409 full url in prebid modules (#8) * add sync * update full url * set url param * fix comment * fix issue fix sync mode * update url * update full url * add test * move browser_blacklist (#10) * add is optedOut (#11) * update date in FPD after sync (#12) * update sync logic for new user (#13) * fix unit tests * change version name * IntentIq ID: Support sourceMetaData and sourceMetaDataExternal (#17) * AGT-453: Support sourceMetaData * AGT-453: sourceMetaDataExternal * AGT-453: Documentation * AGT-453: Changes after review * AGT-453: Fix doc * Fix doc * AGT-453: Fix test * update test * update endpoint (#16) * update endpoint * update test * add tests * update test * fix conflict * fix conflict * add test for reportingServerAddress * add test for reportingServerAddress * AGT-498: support report method parameter (#22) * AGT-498: reportMethod * AGT-498: Tests and refactoring * AGT-498: method refactoring * AGT-498: get method refactoring * AGT-498: reportMethod parameter description (#23) * AGT-498: reportMethod * AGT-498: Tests and refactoring * AGT-498: method refactoring * AGT-498: get method refactoring * AGT-498: Documentation * Agt 452 server call counters (#18) * add counters * add unit tests and fixes * counters additions * clear counters when a request is made --------- Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> * add siloEnabled feature (#19) * add siloEnabled feature * add siloEnabled feature to analytics adapter * add unit tests for siloEnabled feature * add siloenabled to docs --------- Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> * fix unit test issues * AGT-455: Source parameter in requests (#28) * AGT-508: Spd parameter (#29) * AGT-508: Spd parameter * AGT-508: Move appendSpd to utils * AGT-499: Support partnerClientIdType and partnerClientId (#30) * AGT-499: partnerClientId and partnerClientIdType in requests * AGT-499: Clean comment * AGT-499: Refactoring * add groupchanged parameter (#25) * add groupchanged parameter * fix md file issue * add groupChanged example in docs * remove group from example * add unit tests and fix groupChanged issue --------- Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com> * Agt 501 support additional params (#24) * additionalParams feature init * additional params add features * additionalparams fix analytics adapter * add unit tests for additionalParams * fix currentBrowser issue --------- Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com> * fix linter error --------- Co-authored-by: dmytro-po <dmytro.po@intentiq.com> Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com> Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com> Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com> Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> * fix unit tests (#32) Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com> * Agt 547 vr bug for module (#33) * save progress * fix calling server * add "dbsaved" parameter * add tests * AGT-552: Additional query params (#34) * AGT-552: Additional query params * update documentation --------- Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com> * Fix unit test for specific browser * fix spelling --------- Co-authored-by: Eyvaz <62054743+eyvazahmadzada@users.noreply.github.com> Co-authored-by: dmytro-po <dmytro.po@intentiq.com> Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com> Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information