Skip to content

Unit Tests for Container, DFP Win Scenarios#16

Merged
Jimmy Tu (jimee02) merged 2 commits intoopenx-adapterfrom
PBID-170
Apr 14, 2020
Merged

Unit Tests for Container, DFP Win Scenarios#16
Jimmy Tu (jimee02) merged 2 commits intoopenx-adapterfrom
PBID-170

Conversation

@suribabuox
Copy link

@suribabuox suribabuox commented Apr 13, 2020

Added following unit test cases to openx analytics adapter.

  1. Container Win scenario. The test cases contain validating the events (bids received, bid won, auction end, etc) in the data which is pushed after auction end timeout.
  2. DFP Win scenario. The test cases contain validating the events (bids received, auction end) in the data which is pushed after slot load timeout.

Note: I have disabled all the other test cases so all test cases pass (most of the old ones are failing).

jimee02
Jimmy Tu (jimee02) suggested changes Apr 13, 2020
View reviewed changes
Copy link

@jimee02 Jimmy Tu (jimee02) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the export, else if, and split rename issues

modules/openxAnalyticsAdapter.js Outdated
Copy link

@jimee02 Jimmy Tu (jimee02) Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be exported instead of attached it to the object. Especially since you're doing this specifically for testing

Copy link
Author

@suribabuox suribabuox Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detached it from openxAdapter and created a single object(with adapter and AUCTION_END_WAIT_TIME) that can be exported to test spec. I couldn't export multiple entities so I had to club them into a single object (or function would also have worked).

test/spec/modules/openxAnalyticsAdapter_spec.js Outdated
Copy link

@jimee02 Jimmy Tu (jimee02) Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else if

test/spec/modules/openxAnalyticsAdapter_spec.js Outdated
Copy link

@jimee02 Jimmy Tu (jimee02) Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this an accidental rename?

Copy link
Author

@suribabuox suribabuox Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a mistake. I'll revert it.

test/spec/modules/openxAnalyticsAdapter_spec.js Outdated
Copy link

@jimee02 Jimmy Tu (jimee02) Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? I thought they used Mocha for their test runner. I think it should be it.skip()

Since most of these are skipped, you can use describe.only()

https://mochajs.org/#inclusive-tests

Copy link
Author

@suribabuox suribabuox Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using describe.only() but it's causing some issues with beforeEach, before functions (not calling them). So I updated the rest of them with it.skip().

@suribabuox
Copy link
Author

suribabuox commented Apr 14, 2020

Update the export, else if, and split rename issues

I have updated the code with above mentioned changes

jimee02
Jimmy Tu (jimee02) approved these changes Apr 14, 2020
View reviewed changes
Copy link

@jimee02 Jimmy Tu (jimee02) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimee02 Jimmy Tu (jimee02) merged commit 0a4a925 into openx-adapter Apr 14, 2020
Laurentiu Badea (laurb9) pushed a commit that referenced this pull request Jul 30, 2024
@pashaGhub @eldzis
setupad Bid Adapter: initial commit (prebid#11008)
48113b1 
* create setupadBidAdapter

* add setupadBidAdapter

* update setupadBidAdapter

* update metrics collection

* update analytics collection

* update getUserSyncs

* add setupadAnalyticsAdapter.js

* test setupadAnalyticsAdapter

* remove test: 1

* add GVLID && bug fixes && test updates

* remove setupadAnalyticsAdapter

* add userID module handling

* add GVLID && bug fixes && test updates

* remove setupadAnalyticsAdapter

* add userID module handling

* clean up && seat bugfix

* clean up logs

* add userID module handling

* update md && clean up

* Send setupad only on bidRequested

* Fix bidResponse and bidWon responses

* Improve bidResponse and bidWon logic

* Revert changes to specific files

* Remove test parameter

* Fix multiple bidResponse and bidTimeout calls to getPixelUrl

* eslint errors fixes(brackets added)

* Add extra checks for events

* Fix BIDDER_CODE const

* update reporting endpoint

* update setupadBidAdapter_spec.js REPORT_ENDPOINT

* update readme

* Revert "Merge branch 'prebid:master' into setupad-adapter"

This reverts commit 1c14dbe, reversing
changes made to 7fe9ea5.

* Revert "Revert "Merge branch 'prebid:master' into setupad-adapter""

This reverts commit a34e3e4.

* # This is a combination of 20 commits.
# This is the 1st commit message:

add setupadBidAdapter

# This is the commit message #2:

update setupadBidAdapter

# This is the commit message #3:

update metrics collection

# This is the commit message #4:

update analytics collection

# This is the commit message #5:

update getUserSyncs

# This is the commit message #6:

add setupadAnalyticsAdapter.js

# This is the commit message #7:

test setupadAnalyticsAdapter

# This is the commit message #8:

remove test: 1

# This is the commit message #9:

add GVLID && bug fixes && test updates

# This is the commit message #10:

remove setupadAnalyticsAdapter

# This is the commit message #11:

add userID module handling

# This is the commit message #12:

clean up && seat bugfix

# This is the commit message #13:

add userID module handling

# This is the commit message #14:

add GVLID && bug fixes && test updates

# This is the commit message #15:

remove setupadAnalyticsAdapter

# This is the commit message #16:

add userID module handling

# This is the commit message #17:

clean up logs

# This is the commit message #18:

update md && clean up

# This is the commit message #19:

Send setupad only on bidRequested

# This is the commit message #20:

Fix bidResponse and bidWon responses

* # This is a combination of 22 commits.tree 8abae7e
parent cecfce3
author pavel <pavel@setupad.com> 1706627437 +0200
committer pavel <pavel@setupad.com> 1706627437 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC
 s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn
 f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd
 bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY
 QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD
 TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7
 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3
 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL
 k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9
 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j
 CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n
 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E=
 =oJtZ
 -----END PGP SIGNATURE-----

bugfixes

# This is the commit message #22:

Remove test parameter

* # This is a combination of 26 commits.
parent cecfce3
author pavel <pavel@setupad.com> 1706627437 +0200
committer pavel <pavel@setupad.com> 1706627437 +0200
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5EW0ACgkQFABtd4pC
 s/CK3w//WWJSFUlycnnNKTV2XfdcBjooOeZZvjpXVthwr09CCC4uO//kw4bPluhn
 f5fcVFdXzrY1AZ6ch8Wo3msX/Pkso014jIGd5aIWcHpNYFtffACwH/40Y8AcJNZd
 bsOZxVK0awPTz/RihC5eY+0J3cP+iFWP/FlYJoHEQIBXq/Eg6mWoAhxwpL/JvxbY
 QbLFWsRn2ckQ6ftOZgm3/jh8VLaG1zWbWImlWEs5Zel+CorJBTniTj58VbApelYD
 TFMgbSR2I4NGVaqNIrHePnSMsDATxalQ2nZPwY6raKCHWIbvoUPIn/OpDMMbKgC7
 nCwounNmObxFVoj3xusAZppzHpKPasY8xKWb2Kr7zfhZArsOMC6B7fYqQNK0cWG3
 8RR/10oheJD9M2kRlfLiqnRv7ExY08SQ/ZMo9LA8BeRUGBXhh6++8FKhKIHvX1gL
 k1R5W6c+NNWP+PDFsmrFpMn+LpYdl84I7yfYK5dHuw80od7f1wuAVYpswi6Cziy9
 /KY6/rfENvUrGTmWSh5GdDBel89ACCfFkasIKB92xhzKTfjzF/DXkc8XQZOMbt1j
 CsILgWMNfLPMo4Dlgdx/tYCSLLBNEtZ1/hhUcFQ3+0TzLf0GtMkvMnlBnDinqe1n
 1P30fQ2I5W5NJKDPrCOnRymI6QOAPFXtMF11R81mbB9H8asft/E=
 =oJtZ
 -----END PGP SIGNATURE-----

bugfixes

# This is the commit message #22:

Remove test parameter

# This is the commit message #23:

Fix multiple bidResponse and bidTimeout calls to getPixelUrl

# This is the commit message #25:

eslint errors fixes(brackets added)

# This is the commit message #26:

Add extra checks for events

* parent 75178b9
author pavel <pavel@setupad.com> 1706627694 +0200
committer pavel <pavel@setupad.com> 1706627694 +0200
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEEqGYI3KX/FkbObQG8FABtd4pCs/AFAmW5Em4ACgkQFABtd4pC
 s/BBUQ/+NXyHoxPM185YJLG9M1ySC/5vTT9W5mfwQ93cVDLCeuGnpsnmi4S21NuQ
 b7gSeokFjwztvVOUmh/xqMp4lTsvL53TUd00b1k4KGVSqgcF00Foit5g8fOGLYsI
 DAoqphYV6MWjpAun+II+ELY8QUkHR1cjTc7PEGtmf+8RnptGVdyJ6C9Ab8u9TQTY
 Apj5Srhfo3Tl8S+WScOxwwB/uqEJR4fhIrJyzFzdLDEb2olSPyrQUs87vQXlhEnK
 buPEg2F5JsRH6sw11Xp3TFNSZGxNnBSlTh9dixou5md4yRCv5a2TMef667N0BVDp
 lGgc7mCrRKXyqzphmmeHudiscEGFjtUPObXoHutSVw22wdARFCTpNFKBLLFn4v8o
 Zv1OvFdNprvHsoeW0HVlZdU7OKnDTRrko6DHk2AahxojjvAFEWuDsGYZNjhdQwRR
 lK1zm+SFQnKI0Eojd+f84fvKod9geGs640jyH/x5R4eYm4yjZb8SkRtd3cca88wS
 OuGq9LIkbU428b46l7VnDwudldTXPUU8eKfUtFRjdGtIWH9I3tK6TsRoCfTcXkv0
 smxYiiU1XHjAkkPFWQWEeFdfZ071snFKVWouU0AoKiq+PdRoS8+3AJqIQUjlA2sH
 AybnSkv9KxY/Rs1bnvMubsQm1GF66qVrbxBU6FILBv1JZYwj4yA=
 =Gbog
 -----END PGP SIGNATURE-----

bugfixes

update setupadBidAdapter_spec.js REPORT_ENDPOINT

update readme

Revert "Merge branch 'prebid:master' into setupad-adapter"

This reverts commit 1c14dbe, reversing
changes made to 7fe9ea5.

Revert "Revert "Merge branch 'prebid:master' into setupad-adapter""

This reverts commit a34e3e4.

* change double quote to single quote

---------

Co-authored-by: pavel <pavel@setupad.com>
Co-authored-by: Elgars Grodnis <elgars@setupad.com>

* bugfix setupadBidAdapter

remove getAdEl, spelling correction

* add onBidWon event

onBidWon event handling moved from custom to native onBidWon method

* minor bugfixes && remove funk getSiteObj && getDeviceObj

---------

Co-authored-by: pavel <pavel@setupad.com>
Co-authored-by: Elgars Grodnis <elgars@setupad.com>
Laurentiu Badea (laurb9) pushed a commit that referenced this pull request Jul 30, 2024
@garciapuig @gguridi
AzerionEdge RTD Module: Compatibility with GDPR/USP Privacy Modules (p…
c30f105 
…rebid#11775)

* Azerion Edge RTD Module: Initial release

### Type of change

[x] Feature: New RTD Submodule

### Description of change

Adds new Azerion Edge RTD module.

Maintainer: azerion.com

Contact: @garciapuig @mserrate @gguridi

* Azerion Edge RTD Module: Initial release. Typo

* AzerionEdge RTD Module: Documentation: Required parameters

Type of change:
Documentation/Feature

Description of change:
Specifying new required parameters on documentation.
Updating examples.

* AzerionEdge RTD Module: Compatible with GDPR/USP Privacy Modules (#14)

- Added GDPR validation.
- We validate against ImproveDigital vendor ID consent and several purposes.
- We don't load edge script, nor process the existing data, if consent wasn't given.
- Adding support for USP consent.

* AzerionEdgeRTDModule: Passing the consent to the script execution  (#17)

Adding GVL ID to the module configuration
Passing the consent to the script execution instead of handling it in prebid (#16)

---------
Co-authored-by: Gorka Guridi <gorka.guridi@azerion.com>

---------

Co-authored-by: Gorka Guridi <gorka.guridi@gmail.com>
Gabriela Międlar (gmiedlar-ox) pushed a commit that referenced this pull request Dec 23, 2024
@sebrobert
BeOpAdapter - First Party Cookie read and set (#16) (prebid#12486)
6398c68
Gabriela Międlar (gmiedlar-ox) pushed a commit that referenced this pull request Jul 17, 2025
@DimaIntentIQ @eyvazahmadzada
@dmytro-po @dLepetynskyiIntentiq
IntentIq ID & Analytics Modules: Supports additional configuration pa…
d1e86a7 
…rameters (prebid#13122)

* V 0 29 (#31)

* AGT-403: Add adType parameter to payload in report

* AGT-403: Test for partner report, adType parameter

* AGT-403: Test refactoring

* AGT-403: Documentation updated

* IntentIq Analytics Module: adUnitCode or placemetId to report (#9)

* AGT-446: adUnitCode or placemetId to report

* AGT-446: Description of changes, example

* AGT-446: Fix documentation

* AGT-446: Changes after review

* Agt 409 full url in prebid modules (#8)

* add sync

* update full url

* set url param

* fix comment

* fix issue fix sync mode

* update url

* update full url

* add test

* move browser_blacklist (#10)

* add is optedOut (#11)

* update date in FPD after sync (#12)

* update sync logic for new user (#13)

* fix unit tests

* change version name

* IntentIq ID: Support sourceMetaData and sourceMetaDataExternal (#17)

* AGT-453: Support sourceMetaData

* AGT-453: sourceMetaDataExternal

* AGT-453: Documentation

* AGT-453: Changes after review

* AGT-453: Fix doc

* Fix doc

* AGT-453: Fix test

* update test

* update endpoint (#16)

* update endpoint

* update test

* add tests

* update test

* fix conflict

* fix conflict

* add test for reportingServerAddress

* add test for reportingServerAddress

* AGT-498: support report method parameter (#22)

* AGT-498: reportMethod

* AGT-498: Tests and refactoring

* AGT-498: method refactoring

* AGT-498: get method refactoring

* AGT-498: reportMethod parameter description (#23)

* AGT-498: reportMethod

* AGT-498: Tests and refactoring

* AGT-498: method refactoring

* AGT-498: get method refactoring

* AGT-498: Documentation

* Agt 452 server call counters (#18)

* add counters

* add unit tests and fixes

* counters additions

* clear counters when a request is made

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* add siloEnabled feature (#19)

* add siloEnabled feature

* add siloEnabled feature to analytics adapter

* add unit tests for siloEnabled feature

* add siloenabled to docs

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* fix unit test issues

* AGT-455: Source parameter in requests (#28)

* AGT-508: Spd parameter (#29)

* AGT-508: Spd parameter

* AGT-508: Move appendSpd to utils

* AGT-499: Support partnerClientIdType and partnerClientId (#30)

* AGT-499: partnerClientId and partnerClientIdType in requests

* AGT-499: Clean comment

* AGT-499: Refactoring

* add groupchanged parameter (#25)

* add groupchanged parameter

* fix md file issue

* add groupChanged example in docs

* remove group from example

* add unit tests and fix groupChanged issue

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>

* Agt 501 support additional params (#24)

* additionalParams feature init

* additional params add features

* additionalparams fix analytics adapter

* add unit tests for additionalParams

* fix currentBrowser issue

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>

* fix linter error

---------

Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>
Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com>
Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com>
Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* fix unit tests (#32)

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* Agt 547 vr bug for module (#33)

* save progress

* fix calling server

* add "dbsaved" parameter

* add tests

* AGT-552: Additional query params (#34)

* AGT-552: Additional query params

* update documentation

---------

Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com>

* Fix unit test for specific browser

* fix spelling

---------

Co-authored-by: Eyvaz <62054743+eyvazahmadzada@users.noreply.github.com>
Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com>
Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jimee02 Jimmy Tu (jimee02) jimee02 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suribabuox @jimee02

Comments