Adding "Ad Position" dimension to the Schema

[suribabuox]

Below are the functionalities that are added to support "Ad Position" dimension.

• When ad loads (triggered by slotOnLoad event) we capture its position using its DOM element id (slot.getSlotElementId() method) and save it.
• While sending the data to server(triggered by auctionEnd timeout or all the slot load events), we attach the above saved "Ad Position "data to payload and then publish the data.

adPosition will be part of adUnits info list in auctionEnd event.

Possible "Ad Position" values

1. ATF
2. BTF

Note: There are some changes from the previous code review as well.

[suribabuox]

Tried doing using "DOMContentLoaded" event but the callback function is not getting called every time. So finding the window size on the fly every time.

[suribabuox]

Finding the coordinates of the overlapping area (intersection of window and ad slot) and calculating its area and then comparing it with the total ad slot area.

[suribabuox]

Assigning the empty value if adPosition cannot be determined.

[Jimmy Tu (jimee02)]

This may give you a false-positive in situations where the adslot element is outside the screen. Since this is hard to unit test, you can cheat by exposing this function and passing in the values explicitly.

For example:
Window is: 100 width and 100 height
Ad slot bounding box is 100 pixels below the window and 100 pixels to the right of the window.
(top, right , bottom, left): 200, 300, 300, 200

left = 200
right = 100
bottom = 100
right = 100

intersection = 10000
adslot area = 10000

[suribabuox]

Jimmy Tu (@jimee02) Updated the logic to handle such false positives. Please have a look.

[Jimmy Tu (jimee02)]

LGTM