build: add seq-ui docker-compose#125
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 71.47% 71.54% +0.06%
==========================================
Files 201 201
Lines 18167 18167
==========================================
+ Hits 12985 12997 +12
+ Misses 4461 4451 -10
+ Partials 721 719 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📝 WalkthroughWalkthroughAdds Seq UI quickstart: a new UI config, a docker-compose stack (seq-ui, seq-db-proxy, seq-db-store, minio), and updates the existing quickstart docker-compose to use the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (7)
quickstart/config.seq-ui.yaml (2)
6-13: Service address wiring is correct; consider allowing multiple backends.
seq_db_addrsis a list but only one address is provided. If you plan to demo proxy failover/sharding later, consider adding commented examples to clarify usage.
18-24: Quickstart-safe limits: add a brief note to prevent prod copy-paste.The search/export ceilings are generous for local use. Add a comment that these are not production defaults to avoid accidental reuse.
seq_api: + # NOTE: Quickstart/demo limits. Tune down for production. seq_cli_max_search_limit: 10000 max_search_limit: 1000 max_search_total_limit: 100000 max_search_offset_limit: 100000 max_export_limit: 10000quickstart/docker-compose.seq-ui.yaml (5)
7-9: Potential port collisions with the other quickstart compose.This stack exposes 5555–5557, and the proxy exposes 9002/9004/9200; MinIO is 9000/9001. The existing quickstart/docker-compose.yaml uses overlapping 900x ports. Running both stacks together will fail. Consider a note in README or offset these ports here.
11-11: Trailing spaces flagged by yamllint.Line 11 has trailing whitespace. Please strip to keep CI linters happy.
26-26: Another trailing space.Line 26 has trailing whitespace. Remove it.
20-22: Expose debug ports only if needed.Mapping
9200to the host is handy locally but easy to forget. Consider commenting it out by default with a note.- - "9200:9200" # Default debug port +# - "9200:9200" # Debug port (uncomment for troubleshooting)
1-45: Optional: add restart policy for resilience.For a smoother quickstart experience, add
restart: unless-stoppedto each service.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
quickstart/config.seq-ui.yaml(1 hunks)quickstart/docker-compose.seq-ui.yaml(1 hunks)quickstart/docker-compose.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
quickstart/docker-compose.seq-ui.yaml
[error] 11-11: trailing spaces
(trailing-spaces)
[error] 26-26: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (3)
quickstart/docker-compose.yaml (1)
28-28: Pin MinIO image instead of usinglatestBoth
quickstart/docker-compose.yaml(line 28) andquickstart/docker-compose.seq-ui.yaml(line 38) referenceminio/minio:latest; pin to a known-stable release tag (e.g.RELEASE.<version>) or digest (@sha256:<digest>). Confirm which MinIO version or digest you’d like to use.quickstart/config.seq-ui.yaml (2)
1-4: Ports align with compose exposure — looks good.HTTP/grpc/debug ports match the seq-ui service mappings in docker-compose.seq-ui.yaml.
12-15: Keepalive params: double-check server compatibility.
permit_without_stream: truewith 10s/10s may cause frequent pings. Fine for quickstart, but verify the server’s keepalive policy to avoid unexpected disconnects.
Description
Add docker-compose file to launch seq-db alongside seq-ui
If you have used LLM/AI assistance please provide model name and full prompt:
Summary by CodeRabbit
New Features
Chores