build: use ghcr images in quickstart docker compose files#127
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 71.49% 71.50% +0.01%
==========================================
Files 201 201
Lines 18167 18167
==========================================
+ Hits 12988 12991 +3
+ Misses 4458 4456 -2
+ Partials 721 720 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📝 WalkthroughWalkthroughSwitches quickstart compose services from local builds to ghcr.io/ozontech/seq-db:latest, updates volume mounts to a single mappings.yaml file, points config to /seq-db/mappings.yaml, adds quickstart/mappings.yaml, and ignores quickstart/data in .gitignore. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
quickstart/config.quickstart.yaml (1)
31-33: Mapping file path switch looks consistent with the new volume mount.One ask: the container commands use a relative
--config=config.yaml, andstorage.data_diris./data. This assumes the container working directory is/seq-db. If that’s not guaranteed, prefer absolute paths to avoid surprises.Apply outside this hunk (example):
# quickstart/config.quickstart.yaml - data_dir: ./data + data_dir: /seq-db/data# quickstart/docker-compose.yaml - command: --mode proxy --config=config.yaml + command: --mode proxy --config=/seq-db/config.yaml - command: --mode store --config=config.yaml + command: --mode store --config=/seq-db/config.yaml# quickstart/docker-compose.seq-ui.yaml - command: --mode proxy --config=config.yaml + command: --mode proxy --config=/seq-db/config.yaml - command: --mode store --config=config.yaml + command: --mode store --config=/seq-db/config.yamlquickstart/docker-compose.yaml (1)
3-7: Avoid mutable “latest” for reproducible quickstarts.Pin
ghcr.io/ozontech/seq-dbto a version tag or digest (and reuse via an env/anchor) to keep tutorials stable.Example:
- image: ghcr.io/ozontech/seq-db:latest + image: ghcr.io/ozontech/seq-db:${SEQ_DB_TAG:-vX.Y.Z}Add
.envwithSEQ_DB_TAG=vX.Y.Zand document updating it.quickstart/docker-compose.seq-ui.yaml (1)
13-17: Same note: pin the seq-db image instead of “latest”.Mirror the tag/digest approach here for consistency with the other compose.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.gitignore(1 hunks)quickstart/config.quickstart.yaml(1 hunks)quickstart/docker-compose.seq-ui.yaml(1 hunks)quickstart/docker-compose.yaml(1 hunks)quickstart/mappings.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (5)
.gitignore (1)
26-27: LGTM: ignore quickstart runtime data.Prevents accidental check-ins of local volumes. No further action.
quickstart/mappings.yaml (1)
12-17: Replacetitlewithnameundertypes
typesentries expect anamekey (e.g.- name: "keyword"), nottitle. Confirm against the seq-db mapping schema and update accordingly.quickstart/docker-compose.yaml (2)
6-6: Nice: single-file mapping mount aligns with config path.Keeps the quickstart minimal.
19-20: Good: dedicated data volume path under quickstart.Matches
.gitignoreand keeps state local to the example.quickstart/docker-compose.seq-ui.yaml (1)
29-30: Volumes look correct and consistent with the non-UI compose.No issues spotted.
Description
use ghcr images in quickstart docker compose files
If you have used LLM/AI assistance please provide model name and full prompt:
Summary by CodeRabbit
New Features
Chores