build: add frontend to docker compose#131
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
- Coverage 71.50% 71.49% -0.02%
==========================================
Files 201 201
Lines 18170 18170
==========================================
- Hits 12993 12991 -2
- Misses 4457 4459 +2
Partials 720 720 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📝 WalkthroughWalkthroughAdds new CORS, DB timeout, and API limit settings to the seq-ui quickstart config, and introduces a new frontend service in the docker-compose file mapping port 5173 to container port 80. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
quickstart/config.seq-ui.yaml(1 hunks)quickstart/docker-compose.seq-ui.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (1)
quickstart/docker-compose.seq-ui.yaml (1)
11-14: Pin image tag and confirm FE→API wiringFile: quickstart/docker-compose.seq-ui.yaml Lines: 11-14
- Parameterize the image tag to avoid using :latest in CI/deployments. Suggested diff:
- image: ghcr.io/ozontech/seq-ui-fe:latest + image: ghcr.io/ozontech/seq-ui-fe:${SEQ_UI_FE_TAG:-latest} + # If the image supports runtime envs, consider wiring API base URL explicitly: + # environment: + # - API_BASE_URL=http://seq-ui:5555
- Confirm how the FE resolves the API base URL (env/config/reverse-proxy). If FE is served from a different origin and CORS is open, ensure it targets seq-ui:5555 or use a reverse proxy to avoid cross-origin calls.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
If you have used LLM/AI assistance please provide model name and full prompt:
Summary by CodeRabbit