FIx typos in br external storages by TomShawn · Pull Request #6018 · pingcap/docs-cn

TomShawn · 2021-04-12T07:40:10Z

What is changed, added or deleted? (Required)

Fix a few typos

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s): *: generalize and link to the external storage docs from Lightning #5528

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

TomShawn · 2021-04-12T07:40:46Z

/assign
/cc @yikeke
/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/translation done
/label require-LGT1

IANTHEREAL · 2021-04-12T07:50:37Z

LGTM

kennytm · 2021-04-12T07:56:44Z

LGTM

Co-authored-by: Coco Yee <40977455+yikeke@users.noreply.github.com>

yikeke

/lgtm

yikeke · 2021-04-13T03:49:26Z

/sig migration

ti-chi-bot · 2021-04-13T03:49:27Z

@yikeke: The label(s) sig/migration cannot be applied, because the repository doesn't have them.

Details

In response to this:

/sig migration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

yikeke · 2021-04-13T03:49:51Z

/sig migrate

YuJuncen · 2021-04-13T03:50:16Z

/lgtm

YuJuncen · 2021-04-13T03:59:16Z

/lgtm

ti-chi-bot · 2021-04-13T03:59:17Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

YuJuncen
yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

yikeke · 2021-04-13T03:59:26Z

/merge

ti-chi-bot · 2021-04-13T03:59:28Z

@yikeke: /merge is only allowed for the committers in list.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

YuJuncen · 2021-04-13T04:42:32Z

/merge

Seems this PR was FULLY treated as a sig-migrate item...🧐

ti-chi-bot · 2021-04-13T04:42:36Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 3728810

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-04-13T04:44:27Z

cherry pick to release-4.0 in PR #6024

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-04-13T04:45:07Z

cherry pick to release-5.0 in PR #6025

yikeke · 2021-04-13T05:17:10Z

/merge

Seems this PR was FULLY treated as a sig-migrate item...🧐

Solved. I need to add the sig/docs label as well...

FIx typos in br external storages

b8827f4

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2021

ti-chi-bot assigned TomShawn Apr 12, 2021

ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-4.0 labels Apr 12, 2021

ti-chi-bot requested a review from yikeke April 12, 2021 07:40

ti-chi-bot added needs-cherry-pick-5.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 12, 2021

TomShawn mentioned this pull request Apr 12, 2021

*: generalize and link to the external storage docs from Lightning pingcap/docs#5286

Merged

10 tasks

yikeke requested a review from IANTHEREAL April 12, 2021 07:46

Update backup-and-restore-tool.md

db7dfc3

ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2021

TomShawn added 2 commits April 12, 2021 17:14

reword

454489e

reword

38f5115

TomShawn mentioned this pull request Apr 12, 2021

br:tidy up the incompatible issues in using BR tools pingcap/docs#5288

Merged

10 tasks

TomShawn added 3 commits April 12, 2021 17:59

refine wording

cc46bd4

clarify /

3513108

br 存储--> 外部存储

3da09f0

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2021

yikeke reviewed Apr 13, 2021

View reviewed changes

Comment thread br/backup-and-restore-tool.md Outdated

TomShawn and others added 2 commits April 13, 2021 11:10

correct br compatibility tables

054bdc2

Update br/backup-and-restore-tool.md

3728810

Co-authored-by: Coco Yee <40977455+yikeke@users.noreply.github.com>

yikeke approved these changes Apr 13, 2021

View reviewed changes

ti-chi-bot added the area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. label Apr 13, 2021

yikeke removed the require-LGT1 Indicates that the PR requires an LGTM. label Apr 13, 2021

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2021

ti-chi-bot merged commit 39dfbef into pingcap:master Apr 13, 2021

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 13, 2021

cherry pick pingcap#6018 to release-4.0

c424b4f

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Apr 13, 2021

FIx typos in br external storages (#6018) #6024

Merged

10 tasks

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 13, 2021

cherry pick pingcap#6018 to release-5.0

8256167

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Apr 13, 2021

FIx typos in br external storages (#6018) #6025

Merged

10 tasks

TomShawn deleted the fix-typosaaa branch April 13, 2021 05:00

ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021

FIx typos in br external storages (#6018) (#6025)

913a47a

ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021

FIx typos in br external storages (#6018) (#6024)

7f9ff96

Conversation

TomShawn commented Apr 12, 2021

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

TomShawn commented Apr 12, 2021

Uh oh!

IANTHEREAL commented Apr 12, 2021

Uh oh!

kennytm commented Apr 12, 2021

Uh oh!

Uh oh!

yikeke left a comment

Choose a reason for hiding this comment

Uh oh!

yikeke commented Apr 13, 2021

Uh oh!

ti-chi-bot commented Apr 13, 2021

Uh oh!

yikeke commented Apr 13, 2021

Uh oh!

YuJuncen commented Apr 13, 2021

Uh oh!

YuJuncen commented Apr 13, 2021

Uh oh!

ti-chi-bot commented Apr 13, 2021

Uh oh!

yikeke commented Apr 13, 2021

Uh oh!

ti-chi-bot commented Apr 13, 2021

Uh oh!

YuJuncen commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ti-chi-bot commented Apr 13, 2021

Uh oh!

ti-srebot commented Apr 13, 2021

Uh oh!

ti-srebot commented Apr 13, 2021

Uh oh!

yikeke commented Apr 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

YuJuncen commented Apr 13, 2021 •

edited

Loading