*: generalize and link to the external storage docs from Lightning by TomShawn · Pull Request #5286 · pingcap/docs

TomShawn · 2021-04-12T07:33:51Z

What is changed, added or deleted? (Required)

Generalize the "BR storage" page to "external storage", and talk about all associated migration services.

Link back to this page from their documents.

Follow-up: Change the file name for 外部存储 and remove it out of /br. @IANTHEREAL will work on its new position in TOC.

Which TiDB version(s) do your changes apply to? (Required)

master (the latest development version)
v5.0 (TiDB 5.0 versions)
v4.0 (TiDB 4.0 versions) Have version-specific changes
v3.1 (TiDB 3.1 versions)
v3.0 (TiDB 3.0 versions)
v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

This PR is translated from: *: generalize and link to the external storage docs from Lightning docs-cn#5528 FIx typos in br external storages docs-cn#6018
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

TomShawn · 2021-04-12T07:35:08Z

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/status PTAL
/translation from-docs-cn
/cc @yikeke @overvenus @IANTHEREAL

TomShawn · 2021-04-12T07:35:32Z

/label requires-version-specific-change

ti-chi-bot · 2021-04-12T07:35:33Z

@TomShawn: The label(s) requires-version-specific-change cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, for-future-release, requires-version-specific-changes, website.

Details

In response to this:

/label requires-version-specific-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn · 2021-04-12T07:36:22Z

/label requires-version-specific-changes

TomShawn · 2021-04-12T07:39:40Z

/label requires-followup

IANTHEREAL · 2021-04-12T07:52:07Z

+Currently, TiDB Lightning supports:
+
+- The data source of the [Dumpling](/dumpling-overview.md), CSV or [Amazon Aurora Parquet](/migrate-from-aurora-using-lightning.md) exported formats.
+- Reading data from a local disk or from the Amazon S3 storage.


can it link to external storage introduction？

IANTHEREAL · 2021-04-12T07:54:48Z

Rest LGTM

Co-authored-by: kennytm <kennytm@gmail.com>

yikeke · 2021-04-12T09:41:42Z

New feature: Now all the docs repositories support labeling sig/xxx to give the review privileges to the SIG's reviewers.

Do you know which SIG the PR changes belong to? @kennytm

yikeke · 2021-04-13T02:53:45Z

+### External storages

 BR supports backing up data to S3 or GCS:



Modify the Line 111: BR storages -> external storages

And the same for the Chinese version.

Done in 913a840

yikeke

rest /lgtm

ti-chi-bot · 2021-04-13T03:15:43Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

Co-authored-by: Coco Yee <40977455+yikeke@users.noreply.github.com>

yikeke · 2021-04-13T03:23:25Z

PTAL again @kennytm

kennytm · 2021-04-13T05:12:13Z

/lgtm

ti-chi-bot · 2021-04-13T05:12:15Z

@kennytm: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn · 2021-04-13T10:09:00Z

/remove-status LGT1
/status LGT2

TomShawn · 2021-04-13T10:09:08Z

/merge

ti-chi-bot · 2021-04-13T10:09:10Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 913a840

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-04-13T10:10:24Z

cherry pick to release-4.0 in PR #5315

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-04-13T10:11:01Z

cherry pick to release-5.0 in PR #5316

…5286) (#5316)

…5286) (#5315)

*: generalize and link to the external storage docs from Lightning

04cf8ce

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2021

ti-chi-bot requested review from IANTHEREAL, overvenus and yikeke April 12, 2021 07:35

ti-chi-bot added status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 12, 2021

ti-chi-bot added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Apr 12, 2021

ti-chi-bot added the requires-followup This PR requires a follow-up task after being merged. label Apr 12, 2021

IANTHEREAL reviewed Apr 12, 2021

View reviewed changes

kennytm reviewed Apr 12, 2021

View reviewed changes

Comment thread br/backup-and-restore-storages.md Outdated

Update br/backup-and-restore-storages.md

c184968

Co-authored-by: kennytm <kennytm@gmail.com>

TomShawn commented Apr 12, 2021

View reviewed changes

Comment thread tidb-lightning/tidb-lightning-overview.md Outdated

Update tidb-lightning/tidb-lightning-overview.md

d525227

yikeke reviewed Apr 13, 2021

View reviewed changes

Comment thread br/backup-and-restore-storages.md Outdated

yikeke reviewed Apr 13, 2021

View reviewed changes

Comment thread dumpling-overview.md Outdated

yikeke reviewed Apr 13, 2021

View reviewed changes

yikeke approved these changes Apr 13, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2021

TomShawn and others added 2 commits April 13, 2021 11:16

Apply suggestions from code review

7f98b30

Co-authored-by: Coco Yee <40977455+yikeke@users.noreply.github.com>

br storages --> external storages

913a840

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2021

ti-chi-bot merged commit 3f76f22 into pingcap:master Apr 13, 2021

TomShawn deleted the storage-paramms-to-lightbing branch April 13, 2021 10:09

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 13, 2021

cherry pick pingcap#5286 to release-4.0

9433e7b

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Apr 13, 2021

*: generalize and link to the external storage docs from Lightning (#5286) #5315

Merged

10 tasks

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 13, 2021

cherry pick pingcap#5286 to release-5.0

8fff74c

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Apr 13, 2021

*: generalize and link to the external storage docs from Lightning (#5286) #5316

Merged

10 tasks

ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021

*: generalize and link to the external storage docs from Lightning (#…

4f52d6f

…5286) (#5316)

ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021

*: generalize and link to the external storage docs from Lightning (#…

b247fdc

…5286) (#5315)

		### External storages

		BR supports backing up data to S3 or GCS:

Conversation

TomShawn commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

Uh oh!

TomShawn commented Apr 12, 2021

Uh oh!

TomShawn commented Apr 12, 2021

Uh oh!

ti-chi-bot commented Apr 12, 2021

Uh oh!

TomShawn commented Apr 12, 2021

Uh oh!

TomShawn commented Apr 12, 2021

Uh oh!

IANTHEREAL Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

TomShawn Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

IANTHEREAL commented Apr 12, 2021

Uh oh!

Uh oh!

Uh oh!

yikeke commented Apr 12, 2021

Uh oh!

Uh oh!

Uh oh!

yikeke Apr 13, 2021

Choose a reason for hiding this comment

Uh oh!

TomShawn Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yikeke left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot commented Apr 13, 2021

Uh oh!

yikeke commented Apr 13, 2021

Uh oh!

kennytm commented Apr 13, 2021

Uh oh!

ti-chi-bot commented Apr 13, 2021

Uh oh!

TomShawn commented Apr 13, 2021

Uh oh!

TomShawn commented Apr 13, 2021

Uh oh!

ti-chi-bot commented Apr 13, 2021

Uh oh!

ti-srebot commented Apr 13, 2021

Uh oh!

ti-srebot commented Apr 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TomShawn commented Apr 12, 2021 •

edited

Loading

TomShawn Apr 13, 2021 •

edited

Loading