Skip to content

*: generalize and link to the external storage docs from Lightning (#5286)#5316

Merged
ti-chi-bot merged 2 commits into
pingcap:release-5.0from
ti-srebot:release-5.0-3f76f22b90c1
Apr 13, 2021
Merged

*: generalize and link to the external storage docs from Lightning (#5286)#5316
ti-chi-bot merged 2 commits into
pingcap:release-5.0from
ti-srebot:release-5.0-3f76f22b90c1

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Apr 13, 2021

cherry-pick #5286 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In docs repo:
git pr https://github.com/pingcap/docs/pull/5316

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/docs.git pr/5316:release-5.0-3f76f22b90c1

What is changed, added or deleted? (Required)

Fix #4445.

Generalize the "BR storage" page to "external storage", and talk about all associated migration services.

Link back to this page from their documents.

Follow-up: Change the file name for 外部存储 and remove it out of /br. @IANTHEREAL will work on its new position in TOC.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions) Have version-specific changes
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added requires-followup This PR requires a follow-up task after being merged. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Apr 13, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor Author

@TomShawn you're already a collaborator in bot's repo.

@TomShawn
Copy link
Copy Markdown
Contributor

/remove-label requires-followup

@ti-chi-bot ti-chi-bot removed the requires-followup This PR requires a follow-up task after being merged. label Apr 13, 2021
Comment thread br/backup-and-restore-storages.md Outdated
Comment thread br/backup-and-restore-storages.md Outdated
Comment thread br/backup-and-restore-storages.md Outdated
Comment thread br/backup-and-restore-storages.md Outdated
@TomShawn
Copy link
Copy Markdown
Contributor

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2021
@TomShawn
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: ad245f6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2021
@ti-chi-bot ti-chi-bot merged commit 4f52d6f into pingcap:release-5.0 Apr 13, 2021
@TomShawn TomShawn deleted the release-5.0-3f76f22b90c1 branch April 13, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants