Skip to content

model: add IsCommonHandle field on TableInfo#850

Merged
lysu merged 2 commits into
pingcap:masterfrom
coocood:is-common-handle-fields
May 11, 2020
Merged

model: add IsCommonHandle field on TableInfo#850
lysu merged 2 commits into
pingcap:masterfrom
coocood:is-common-handle-fields

Conversation

@coocood
Copy link
Copy Markdown
Member

@coocood coocood commented May 9, 2020

What problem does this PR solve?

To support clustered index.

pingcap/tidb#17044

@coocood coocood requested a review from a team May 9, 2020 10:17
@ghost ghost requested review from kennytm and removed request for a team May 9, 2020 10:17
@coocood coocood requested review from a team, SunRunAway and lysu May 9, 2020 10:17
@ghost ghost removed their request for review May 9, 2020 10:17
Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix go fmt. Rest LGTM.

@coocood
Copy link
Copy Markdown
Member Author

coocood commented May 10, 2020

@kennytm PTAL

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2020

Codecov Report

Merging #850 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #850   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files          40       40           
  Lines       14646    14646           
=======================================
  Hits        11461    11461           
  Misses       2502     2502           
  Partials      683      683           

@kennytm kennytm added the status/LGT1 LGT1 label May 10, 2020
Copy link
Copy Markdown
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu merged commit 9301e3b into pingcap:master May 11, 2020
@coocood coocood deleted the is-common-handle-fields branch May 11, 2020 03:10
AilinKid pushed a commit to AilinKid/parser that referenced this pull request Jun 2, 2020
AilinKid added a commit that referenced this pull request Jun 2, 2020
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants