Skip to content

parser: support check constraints field#871

Merged
AilinKid merged 10 commits into
pingcap:masterfrom
AilinKid:check_constraint2
May 26, 2020
Merged

parser: support check constraints field#871
AilinKid merged 10 commits into
pingcap:masterfrom
AilinKid:check_constraint2

Conversation

@AilinKid
Copy link
Copy Markdown
Contributor

Signed-off-by: Arenatlx 314806019@qq.com

What problem does this PR solve?

support check constraint info.

What is changed and how it works?

1:add constraint info in model.go
2:add a item to store the check constraint info in tableInfo.

Check List

Tests

  • Integration test

Code changes

  • Has changed the model

Related changes

  • Need to update the documentation

AilinKid and others added 8 commits May 22, 2020 10:52
Signed-off-by: Arenatlx <314806019@qq.com>
Signed-off-by: Arenatlx <314806019@qq.com>
.
Signed-off-by: Arenatlx <314806019@qq.com>
Signed-off-by: AilinKid <314806019@qq.com>
.
Signed-off-by: Arenatlx <314806019@qq.com>
Signed-off-by: Arenatlx <314806019@qq.com>
@AilinKid AilinKid requested a review from a team May 25, 2020 06:31
@ghost ghost requested review from tangenta and removed request for a team May 25, 2020 06:31
@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2020

Codecov Report

Merging #871 into master will decrease coverage by 0.01%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   78.30%   78.28%   -0.02%     
==========================================
  Files          40       40              
  Lines       14682    14693      +11     
==========================================
+ Hits        11497    11503       +6     
- Misses       2502     2507       +5     
  Partials      683      683              

Copy link
Copy Markdown
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label May 25, 2020
tangenta
tangenta previously approved these changes May 26, 2020
Copy link
Copy Markdown
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread ast/ddl.go Outdated
@tangenta tangenta added DNM and removed status/WIP labels May 26, 2020
@AilinKid AilinKid changed the title parser: support check constraints filed parser: support check constraints field May 26, 2020
Signed-off-by: Arenatlx <314806019@qq.com>
@AilinKid AilinKid removed DNM labels May 26, 2020
@AilinKid
Copy link
Copy Markdown
Contributor Author

this pr is ready to merge PTAL @tangenta

@AilinKid AilinKid added the status/LGT2 LGT2 label May 26, 2020
@tangenta tangenta removed the status/LGT1 LGT1 label May 26, 2020
@zz-jason
Copy link
Copy Markdown
Member

@AilinKid please create an issue for this PR and link the issue to the project kanban.

@AilinKid
Copy link
Copy Markdown
Contributor Author

@AilinKid please create an issue for this PR and link the issue to the project kanban.

ok

@AilinKid
Copy link
Copy Markdown
Contributor Author

Linked Issue: pingcap/tidb#17402

@AilinKid AilinKid merged commit aec2981 into pingcap:master May 26, 2020
AilinKid added a commit to AilinKid/parser that referenced this pull request Jun 1, 2020
AilinKid added a commit to AilinKid/parser that referenced this pull request Jun 2, 2020
AilinKid added a commit that referenced this pull request Jun 2, 2020
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
kafka1991 added a commit to kafka1991/parser that referenced this pull request Jan 4, 2022
(cherry picked from commit aec2981)

# Conflicts:
#	model/model.go
kafka1991 added a commit to kafka1991/parser that referenced this pull request Jan 4, 2022
(cherry picked from commit aec2981)

# Conflicts:
#	model/model.go
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
(cherry picked from commit aec2981)

# Conflicts:
#	model/model.go
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
(cherry picked from commit aec2981)

# Conflicts:
#	model/model.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants