Skip to content

parser: cherry-pick #871, #850 to 4.0-itai#881

Merged
AilinKid merged 4 commits into
pingcap:4.0-itaifrom
AilinKid:local-itai
Jun 2, 2020
Merged

parser: cherry-pick #871, #850 to 4.0-itai#881
AilinKid merged 4 commits into
pingcap:4.0-itaifrom
AilinKid:local-itai

Conversation

@AilinKid
Copy link
Copy Markdown
Contributor

@AilinKid AilinKid commented Jun 1, 2020

What problem does this PR solve?

cherry-pick :
support check constraints field (#871)
model: add IsCommonHandle field on TableInfo (#850)
to 4.0 itai

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

@AilinKid AilinKid changed the title Local itai parser: support check constraint field (#871) Jun 1, 2020
@AilinKid AilinKid requested review from tangenta and zimulala June 1, 2020 10:23
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2020

Codecov Report

Merging #881 into 4.0-itai will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##           4.0-itai     #881      +/-   ##
============================================
- Coverage     78.20%   78.19%   -0.02%     
============================================
  Files            40       40              
  Lines         14667    14682      +15     
============================================
+ Hits          11470    11480      +10     
- Misses         2514     2519       +5     
  Partials        683      683              

Copy link
Copy Markdown
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Copy Markdown
Contributor Author

AilinKid commented Jun 1, 2020

conflict file

model.go

Copy link
Copy Markdown
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT2 LGT2 label Jun 1, 2020
AilinKid and others added 2 commits June 2, 2020 10:49
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid AilinKid changed the title parser: support check constraint field (#871) parser: cherry-pick #871, #850 to 4.0-itai Jun 2, 2020
.
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid AilinKid merged commit becdf8c into pingcap:4.0-itai Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants