planner: the issue that incorrect result is returned for nondeterministic function when executing a prepared point-get update.#22067
Merged
Conversation
…tic function when executing a prepared point-get update. (pingcap#21883)
bb7133
requested review from
hanfei1991 and
qw4990
and removed request for
a team
Member
Author
Contributor
|
LGTM |
Contributor
|
LGTM |
ti-srebot
approved these changes
Dec 29, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
Contributor
|
/run-all-tests |
winoros
pushed a commit
to winoros/tidb
that referenced
this pull request
Mar 22, 2021
…stic function when executing a prepared point-get update. (pingcap#22067)
SabaPing
pushed a commit
to SabaPing/tidb
that referenced
this pull request
Mar 25, 2021
…et update meets nondeterministic function. (pingcap#22067) (pingcap#23455)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks #21883 to release-5.0-rc:
What problem does this PR solve?
Issue Number: #21884
Problem Summary:
In #12243, the evaluated value of the parameters of the prepared statement is improperly cached in
tryCachePointPlan, which caused the bug reported in #21884 :tidb/planner/core/common_plans.go
Line 405 in 91bbcb8
What is changed and how it works?
How it Works:
Commented the related caching codes in
tryCachePointPlanas a short-term solution, the fix will be refined in the future.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note