Skip to content

planner: incorrect results returned when executing a prepared point-get update meets nondeterministic function. (#22067)#23455

Merged
ti-chi-bot merged 2 commits into
pingcap:masterfrom
winoros:pick
Mar 22, 2021
Merged

Conversation

@winoros
Copy link
Copy Markdown
Member

@winoros winoros commented Mar 22, 2021 •
edited
Loading

…

What problem does this PR solve?

Issue Number: close #21884

Problem Summary:

What is changed and how it works?

Cherry-pick #22067

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Fix the issue that incorrect result is returned for indeterministic function when executing a prepared point-get update with "prepared plan cache" is disabled.

@bb7133 @winoros
planner: the issue that incorrect result is returned for nondetermini…
1c9d7f1 
…stic function when executing a prepared point-get update. (pingcap#22067)
@winoros winoros requested review from bb7133, cfzjywxk and lysu March 22, 2021 09:26
@winoros winoros requested review from a team as code owners March 22, 2021 09:26
@winoros winoros requested review from lzmhhh123 and removed request for a team March 22, 2021 09:26
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 22, 2021
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Mar 22, 2021

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@winoros
Copy link
Copy Markdown
Member Author

winoros commented Mar 22, 2021

/run-check_release_note

@winoros winoros removed the request for review from lzmhhh123 March 22, 2021 09:29
@cfzjywxk
Copy link
Copy Markdown
Contributor

cfzjywxk commented Mar 22, 2021

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 22, 2021

@cfzjywxk: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lysu
Copy link
Copy Markdown
Contributor

lysu commented Mar 22, 2021

LGTM

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 22, 2021

@lysu: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lysu
Copy link
Copy Markdown
Contributor

lysu commented Mar 22, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 22, 2021

@lysu: /merge is only allowed for the committers in list.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lysu
Copy link
Copy Markdown
Contributor

lysu commented Mar 22, 2021

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 22, 2021

@lysu: /lgtm is only allowed for the reviewers in list.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ichn-hu ichn-hu mentioned this pull request Mar 22, 2021
Closed
@lysu
Copy link
Copy Markdown
Contributor

lysu commented Mar 22, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 22, 2021

@lysu: /merge is only allowed for the committers in list.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wjhuang2016
Copy link
Copy Markdown
Member

wjhuang2016 commented Mar 22, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2021
@winoros
Copy link
Copy Markdown
Member Author

winoros commented Mar 22, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Mar 22, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1c9d7f1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2021
@winoros winoros changed the title planner: the issue that incorrect result is returned for nondeterministic function when executing a prepared point-get update. (#22067) planner: incorrect results returned when executing a prepared point-get update meets nondeterministic function. (#22067) Mar 22, 2021
@winoros
Copy link
Copy Markdown
Member Author

winoros commented Mar 22, 2021

/run-check_dev_2
/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 9f465d7 into pingcap:master Mar 22, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 22, 2021
@winoros @ti-srebot
cherry pick pingcap#23455 to release-5.0
b69bc15 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 22, 2021
Merged
@ti-srebot
Copy link
Copy Markdown
Contributor

ti-srebot commented Mar 22, 2021

cherry pick to release-5.0 in PR #23458

@winoros winoros deleted the pick branch March 22, 2021 12:00
ti-chi-bot pushed a commit that referenced this pull request Mar 23, 2021
@ti-srebot
planner: incorrect results returned when executing a prepared point-g…
6019eb0 
…et update meets nondeterministic function. (#22067) (#23455) (#23458)
SabaPing pushed a commit to SabaPing/tidb that referenced this pull request Mar 25, 2021
@winoros @SabaPing
planner: incorrect results returned when executing a prepared point-g…
b41bdac 
…et update meets nondeterministic function. (pingcap#22067) (pingcap#23455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@lysu lysu Awaiting requested review from lysu

@bb7133 bb7133 Awaiting requested review from bb7133

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.0 sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

planner: incorrect NOW() result when executing a prepared point-get update

8 participants

@winoros @ti-srebot @cfzjywxk @ti-chi-bot @lysu @wjhuang2016 @qw4990 @bb7133