Skip to content

planner: incorrect results returned when executing a prepared point-get update meets nondeterministic function. (#22067) (#23455)#23458

Merged
ti-chi-bot merged 1 commit into
pingcap:release-5.0from
ti-srebot:release-5.0-9f465d788eb9
Mar 23, 2021
Merged

planner: incorrect results returned when executing a prepared point-get update meets nondeterministic function. (#22067) (#23455)#23458
ti-chi-bot merged 1 commit into
pingcap:release-5.0from
ti-srebot:release-5.0-9f465d788eb9

Conversation

@ti-srebot
Copy link
Copy Markdown
Contributor

@ti-srebot ti-srebot commented Mar 22, 2021

cherry-pick #23455 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23458

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/23458:release-5.0-9f465d788eb9

What problem does this PR solve?

Issue Number: close #21884

Problem Summary:

What is changed and how it works?

Cherry-pick #22067

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Fix the issue that incorrect result is returned for indeterministic function when executing a prepared point-get update with "prepared plan cache" is disabled.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested review from a team as code owners March 22, 2021 11:58
@ti-srebot ti-srebot requested review from hanfei1991 and wshwsh12 and removed request for a team March 22, 2021 11:58
@ti-srebot
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Copy Markdown
Contributor Author

@winoros you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2021
@wjhuang2016
Copy link
Copy Markdown
Member

/lgtm

@ti-chi-bot
Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2021
@winoros
Copy link
Copy Markdown
Member

winoros commented Mar 22, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b69bc15

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2021
@winoros
Copy link
Copy Markdown
Member

winoros commented Mar 23, 2021

/run-check_dev

@ti-chi-bot ti-chi-bot merged commit 6019eb0 into pingcap:release-5.0 Mar 23, 2021
@winoros winoros deleted the release-5.0-9f465d788eb9 branch March 23, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.0-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants