Skip to content

store: fix boltdb package import.#3

Merged
ngaut merged 1 commit into
masterfrom
fix-boltdb-import
Sep 6, 2015
Merged

store: fix boltdb package import.#3
ngaut merged 1 commit into
masterfrom
fix-boltdb-import

Conversation

@qiuyesuifeng
Copy link
Copy Markdown
Member

@qiuyesuifeng qiuyesuifeng commented Sep 6, 2015

No description provided.

@c4pt0r
Copy link
Copy Markdown
Member

c4pt0r commented Sep 6, 2015

LGTM

1 similar comment
@ngaut
Copy link
Copy Markdown
Member

ngaut commented Sep 6, 2015

LGTM

ngaut added a commit that referenced this pull request Sep 6, 2015
@ngaut
Merge pull request #3 from pingcap/fix-boltdb-import
7f9930a 
store: fix boltdb package import.
@ngaut ngaut merged commit 7f9930a into master Sep 6, 2015
@ngaut ngaut deleted the fix-boltdb-import branch September 6, 2015 06:22
@mawenbin666 mawenbin666 mentioned this pull request Jun 26, 2018
Closed
@CaitinChen CaitinChen mentioned this pull request Sep 10, 2018
Merged
@sakufo sakufo mentioned this pull request Sep 19, 2018
Closed
bb7133 referenced this pull request in bb7133/tidb Dec 6, 2018
@bb7133
address crazycs520's comments #3
6cf0fb8 
1. refactor CreateTeableInsertExec to re-use current executors
2. added more test cases
bb7133 referenced this pull request in bb7133/tidb Dec 24, 2018
@bb7133
address crazycs520's comments #3
3db4a20 
1. refactor CreateTeableInsertExec to re-use current executors
2. added more test cases
bb7133 referenced this pull request in bb7133/tidb Jan 17, 2019
@bb7133
address crazycs520's comments #3
2c6d803 
1. refactor CreateTeableInsertExec to re-use current executors
2. added more test cases
coocood added a commit to coocood/tidb that referenced this pull request Apr 15, 2019
@coocood @tiancaiamao
fix dead lock bug and optimize. (pingcap#3)
6cd2e21 
* fix shadow error
* reduce number of keys to lock
@morgo morgo mentioned this pull request Apr 18, 2019
Closed
bb7133 referenced this pull request in bb7133/tidb Jun 12, 2019
@bb7133
address comment #3
7f7ad56
IggieWang referenced this pull request in IggieWang/tidb Aug 11, 2019
@zouhuan1215
Merge pull request #3 from IggieWang/newidxadv
94fb775 
finish multiple tables advisor
@breezewish breezewish mentioned this pull request Sep 10, 2019
Closed
wph95 referenced this pull request in wph95/tidb Oct 6, 2019
@qiuyesuifeng
Merge pull request #3 from qiuyesuifeng/qiueysuifeng/hackathon
edabda9 
*: add global variable for stream table pos
gtygo added a commit to gtygo/tidb that referenced this pull request Oct 8, 2019
@gtygo
update pingcap#3
8307a39
lfkdsk added a commit to JustProject/tidb that referenced this pull request Nov 4, 2019
@lfkdsk
Feature add udf support (pingcap#3)
39340ce 
feature: add udf support.
feature: test where function
feature: add parser.
example: add trim user define plugin.
rm useless debug code.
gtygo added a commit to gtygo/tidb that referenced this pull request Nov 4, 2019
@gtygo
update pingcap#3
abc1611
windtalker referenced this pull request in windtalker/tidb Apr 8, 2020
@hanfei1991
Merge pull request #3 from windtalker/hanfei/join-merge
d2ee6e9 
basic support for multi table broadcast join
imtbkcat pushed a commit to imtbkcat/tidb that referenced this pull request May 7, 2020
@bb7133
Merge pull request pingcap#3 from zimulala/zimuxia/rename-db-4.0
44a44da
@jaltabike jaltabike mentioned this pull request Sep 10, 2018
Closed
@mahjonp mahjonp mentioned this pull request Aug 6, 2020
Open
@ti-srebot ti-srebot mentioned this pull request Sep 5, 2020
Closed
abbccdda pushed a commit to abbccdda/tidb that referenced this pull request Jan 16, 2021
@zhangjinpeng87
Merge pull request pingcap#3 from PatrickNicholas/2020-hackathon
40d9bf5 
Add network cost estimater for adpative follower local read
djshow832 referenced this pull request in djshow832/tidb Mar 12, 2021
@nolouch
Merge pull request #3 from djshow832/session
3547322 
add session variable `tidb_read_staleness`
TszKitLo40 pushed a commit to TszKitLo40/tidb that referenced this pull request Jan 3, 2022
@jyz0309
Merge pull request pingcap#3 from TszKitLo40/hackathon-file
b3e5a78 
Hackathon file
AilinKid added a commit to AilinKid/tidb that referenced this pull request Jan 6, 2022
@AilinKid
extractFD for group/datasource/selection/projection and ported some t…
21dd9b3 
…est (pingcap#3)
Xuanwo referenced this pull request in Xuanwo/tidb Jan 6, 2022
@crazycs520
Merge pull request #3 from crazycs520/support-delete
ed3dee3 
support auto delete partition
JmPotato pushed a commit to JmPotato/tidb that referenced this pull request Jan 7, 2022
@RinChanNOWWW
Merge pull request pingcap#3 from Long-Live-the-DoDo/feat_update_with…
a97b84d 
…_mvcc

feat: update with mvcc info to use tikv raw put
@winoros winoros mentioned this pull request Apr 8, 2022
Merged
12 tasks
@Benjamin2037 Benjamin2037 mentioned this pull request Jun 1, 2022
Closed
12 tasks
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Oct 22, 2022
@XuHuaiyu
Merge pull request pingcap#3 from guo-shaoge/tidb_plan_to_substrait
d59431d
YangKeao pushed a commit to YangKeao/tidb that referenced this pull request Dec 27, 2022
@lizhenhuan
Merge pull request pingcap#3 from pingcap/master
bd05be6 
Merge from pingcap repo
zhongzc pushed a commit to zhongzc/tidb that referenced this pull request Jan 31, 2023
@mornyx
Merge pull request pingcap#3 from zhongzc/stmtsummary
fa60ecc 
unify
keeplearning20221 added a commit to keeplearning20221/tidb that referenced this pull request Feb 13, 2023
@keeplearning20221
Merge pull request pingcap#3 from keeplearning20221/dependabot/go_mod…
86c2d49 
…ules/golang.org/x/text-0.7.0

build(deps): bump golang.org/x/text from 0.5.0 to 0.7.0
lichunzhu pushed a commit to lichunzhu/tidb that referenced this pull request Feb 15, 2023
@sleepymole
Merge pull request pingcap#3 from lichunzhu/optimize-duplicate-detection
be7329d 
support ResolveDuplicateRows
rebelice added a commit to rebelice/tidb that referenced this pull request Mar 1, 2023
@rebelice
Merge pull request pingcap#3 from rebelice/chore/export-ExtractTableList
b41f6f3 
chore: export ExtractTableList
ljun0712 pushed a commit to ljun0712/tidb that referenced this pull request Mar 1, 2023
@CbcWestwolf
charset: support gb18030 on TiDB (pingcap#3)
b0f7d83
@AilinKid AilinKid mentioned this pull request Jun 7, 2023
Merged
12 tasks
qw4990 added a commit to qw4990/tidb that referenced this pull request Jun 21, 2023
@qw4990
# This is a combination of 6 commits.
b6465f0 
# This is the 1st commit message:

fixup

# This is the commit message #2:

fixup

# This is the commit message pingcap#3:

fixup

# This is the commit message pingcap#4:

fixup

# This is the commit message pingcap#5:

fixup

# This is the commit message pingcap#6:

fixup
@JK1Zhang JK1Zhang mentioned this pull request Sep 21, 2023
Merged
12 tasks
rleungx pushed a commit to rleungx/tidb that referenced this pull request Feb 26, 2024
@clark1013 @lcwangchao
@CbcWestwolf @ti-chi-bot @wuhuizuo @zeminzhou @baiyuqing
extension/serverless: introduce serverless audit log (pingcap#870)
aef4fc1 
* init

* audit: init first version of audit log

* audit: support log global rotate

* audit: update log keys

* audit: more common notify implement

* audit: add record id

* audit: rename some names

* audit: default use normal log path

* audit: add server ip info

* audit: do some refine

* audit: Add some log keys

* audit: update some item format

* audit: add stmt demo

* audit: support redact

* audit: fix bug

* audit: update filter

* audit: update filter

* audit: check user

* audit: update

* update

* audit: update

* audit: fix bug

* aduit: update

* audit: update

* update

* update

* audit: add filter unit test

* fmt

* Add tests for `tidb_audit_enabled` and `tidb_audit_log`

* Add tests for `tidb_audit_log_max_size` and `tidb_audit_log_max_lifetime`

* Add tests for `tidb_audit_log_reserved_*`

* TODO: TestAuditLogRedact

* Fininsh `TestAuditLogRedact`

* Update (pingcap#1)

* fix typo (pingcap#2)

* Add `TRANSACTION`

* rename sysvar

* audit_log_create_filter, audit_log_remove_filter

* finish function call and table test

* test privilege

* finish test for sysvar

* TODO: TestConnectionEvenClass

* update

* audit: fix lint for audit log (pingcap#1)

* audit: fix UT failure caused by the change of redact log (pingcap#3)

* audit: use `t.TempDir()` to make test stable (pingcap#4)

* audit: fix test failed for 7.1

* Add `OWNERS` file (pingcap#35)

Co-authored-by: Chao Wang <cclcwangchao@hotmail.com>

* audit: fix panic when logging sometime (pingcap#26) (pingcap#31)

* test: fix unstable test TestAuditLogReservedDays (pingcap#8)

* Format sysvar_test.go

* audit: use `StatementContext` to generate redacted SQL (pingcap#9)

* audit: fix panic when logging sometime (pingcap#26)

* update

* add owner

* Update OWNERS

---------

Co-authored-by: CbcWestwolf <1004626265@qq.com>
Co-authored-by: wuhuizuo <wuhuizuo@126.com>

* audit: fix panic sometimes when `create user` without password (pingcap#37) (pingcap#39)

* This is an automated cherry-pick of pingcap#37

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix conflict

---------

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: 王超 <cclcwangchao@hotmail.com>

* extension/audit: introduce serverless audit log

Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com>

* update bazel config

Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com>

* support enable audit log when activate

Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com>

* add gwconnid to audit log

Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com>

* comment unstable test

* update bazel

* add log about activate request

* diff audit log enabled

* audit: fix memory leak for executeSQL (pingcap#44) (pingcap#45)

* This is an automated cherry-pick of pingcap#44

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* Update util.go

---------

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: 王超 <cclcwangchao@hotmail.com>

* Update extension/serverless/OWNERS

---------

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com>
Co-authored-by: Chao Wang <cclcwangchao@hotmail.com>
Co-authored-by: cbcwestwolf <1004626265@qq.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: wuhuizuo <wuhuizuo@126.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
Co-authored-by: Yuqing Bai <baiyuq@gmail.com>
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
make async commit configurable (pingcap#3)
c1e6547
@s4sukan s4sukan mentioned this pull request Mar 27, 2024
Open
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 28, 2024
@ystaticy
Merge pull request pingcap#3 from iosmanthus/iosmanthus/keyspace_rfc
0121e99 
rfc: add TiFlash keyspace sections
@pantheon-ai pantheon-ai Bot mentioned this pull request Jan 20, 2026
Open
13 tasks
gengliqi pushed a commit to gengliqi/tidb that referenced this pull request Feb 28, 2026
@windtalker
Merge pull request pingcap#3 from wfxr/mv-write-control
c052b25 
planner, executor, sessionctx: reject explicit dml on mview / mlog tables
@JmPotato JmPotato mentioned this pull request Apr 14, 2026
Merged
2 tasks
@takaidohigasi takaidohigasi mentioned this pull request Apr 24, 2026
Open
13 tasks
@mjonss mjonss mentioned this pull request Apr 29, 2026
Closed
13 tasks
premal added a commit to 6si/tidb that referenced this pull request May 4, 2026
@premal @claude
planner/executor: fix shard-key PointGet panics and misrouting
e41fb3c 
Bug pingcap#4 — panic in PointGetPlan.AccessObject and LoadTableStats when a
partitioned+sharded table is accessed by PK/index on UPDATE/DELETE.
GetPartitionIdxByRow returns a flat shard index (partIdx*shardCnt+slot)
which was used directly to index pi.Definitions (original partition count),
causing index-out-of-range. Fix maps flat→logical via idx/ShardCnt before
indexing the original PI for display (access_object.go, point_get_plan.go)
and resolves to the physical shard ID for KV access (GetPhysID in executor).

Bug pingcap#1 — PointGetPlan misroutes PK-only queries on sharded tables to the
wrong shard because locateShard hashes a zero shard-key column value.
Fix: decline to generate PointGetPlan when the predicate omits the shard key;
queries like WHERE id=X fall back to a table scan covering all shards.

Bug pingcap#3 — RANGE/HASH/KEY+shard tables with a shard-only filter always pruned
to partition p0 because PartitionPruning called pruneShardKeyPartition
directly (returning flat indices only in the first partition's range).
Fix: use pruneShardedRangeOrHashDynamic which expands matched shard slots
across all logical partitions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
premal added a commit to 6si/tidb that referenced this pull request May 4, 2026
@premal @claude
test(shard): add routing math unit tests for Bug pingcap#4, pingcap#3, …
376dfd6 
…pingcap#1 regressions

Adds 7 unit tests to shard_test.go covering the flatIdx arithmetic,
shardForRow bounds safety, rebuildShards post-DROP-PARTITION, and
PartitionExpr staleness detection. Tests run without a live cluster
and directly exercise the 4×4 layout (4 partitions × 4 shards) that
triggered the OOB panic in production (Bug pingcap#4).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@joechenrh joechenrh mentioned this pull request May 13, 2026
Open
13 tasks
takaidohigasi added a commit to takaidohigasi/tidb that referenced this pull request May 17, 2026
@takaidohigasi
*: address @D3Hunter review (parser PR)
adb27a7 
Fixes for D3Hunter's review on pingcap#68028:

[Blocker] Dual-password clauses are parsed but ignored by execution
  - Add executor stubs that reject RETAIN CURRENT PASSWORD / DISCARD
    OLD PASSWORD with ER_NOT_SUPPORTED_YET in executeAlterUser and
    executeSetPwd. Full execution / privilege / storage logic lives in
    the follow-up PR pingcap#68393.
  - Expose exeerrors.ErrNotSupportedYet for callers (was previously
    only available via dbterror.ClassExecutor.NewStd inline).
  - New TestDualPasswordParserOnlyStub in passwordtest to pin the
    stub's behavior.

[Major pingcap#2] CREATE USER accepted dual-password clauses outside MySQL grammar
  - Drop the CreateUserSpec/CreateUserSpecList non-terminals and route
    CREATE USER back through the original UserSpec/UserSpecList chain.
    CREATE USER + RETAIN/DISCARD is now a parser-level syntax error,
    matching MySQL.

[Major pingcap#3] ALTER USER over-accepted invalid RETAIN combinations
  - Introduce AuthOptionWithPassword (the BY-form subset of AuthOption)
    and restructure AlterUserSpec to bind RETAIN only to that subset.
    Reject at parse time:
      ALTER USER u IDENTIFIED WITH plugin AS '<hash>' RETAIN ...
      ALTER USER u IDENTIFIED WITH plugin RETAIN ...
      ALTER USER u RETAIN CURRENT PASSWORD (no auth)
      ALTER USER u IDENTIFIED BY '...' DISCARD OLD PASSWORD
  - DISCARD becomes its own AlterUserSpec variant (no auth-option
    coexists with it).

[Major pingcap#4] Grammar label/documentation contradiction
  - Drop the misleading 'unsupported dual password option' label on the
    deleted CreateUserSpec; rewrite UserSpec/AlterUserSpec labels to
    state the contract accurately.

[Major pingcap#5] Generic *PasswordOrLockOption type was overloaded
  - Introduce dedicated ast.DualPasswordOption and
    ast.DualPasswordOptionType (with DualPasswordRetainCurrent /
    DualPasswordDiscardOld). UserSpec.DualPasswordOption now uses the
    dedicated type. Remove the RetainCurrentPassword and
    DiscardOldPassword iota entries from PasswordOrLockOption.

[Minor pingcap#6] ALTER USER USER() branch
  - USER() still does not route through AlterUserSpecList; dual-password
    on USER() is now a parse-time syntax error (covered by negative test).

[Minor pingcap#7] Parser tests had no negative coverage
  - Add explicit ok=false rows for CREATE USER + RETAIN, the AS-hash +
    RETAIN form, bare RETAIN with no auth, plain BY + DISCARD,
    bare-plugin + RETAIN, and ALTER USER USER() + RETAIN.

[Minor pingcap#8] CREATE/ALTER user-spec grammar duplication
  - Now naturally eliminated because CREATE USER reuses UserSpec.

Behavior PR (pingcap#68393) needs to:
  - Remove the executor stubs added here.
  - Adopt the new ast.DualPasswordOption / DualPasswordOptionType
    symbols (the iota entries it currently consumes are gone).

Ref pingcap#60587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qiuyesuifeng @c4pt0r @ngaut