Fix mysqldef test#6
Merged
Merged
Conversation
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
coocood
pushed a commit
to coocood/tidb
that referenced
this pull request
Apr 18, 2019
IggieWang
added a commit
to IggieWang/tidb
that referenced
this pull request
Aug 13, 2019
finish sets_test.go
wph95
referenced
this pull request
in wph95/tidb
Oct 6, 2019
ichn-hu
pushed a commit
to ichn-hu/tidb
that referenced
this pull request
Apr 28, 2020
support execute summary info for tree struct based dag request
jackysp
pushed a commit
to jackysp/tidb
that referenced
this pull request
May 19, 2020
abbccdda
pushed a commit
to abbccdda/tidb
that referenced
this pull request
Jan 16, 2021
store: adaptive follower read with matched zone label
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* config section for logger & rename config file * adjust to new configuration * correct using config item * adjust comment
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
Signed-off-by: Neil Shen <overvenus@gmail.com>
lichunzhu
added a commit
to lichunzhu/tidb
that referenced
this pull request
Jan 5, 2022
WIP: Hack5.3(add index ok and admin check table ok)
rebelice
pushed a commit
to rebelice/tidb
that referenced
this pull request
Jan 7, 2022
dumpling: Implement parquet support
TszKitLo40
pushed a commit
to TszKitLo40/tidb
that referenced
this pull request
Jan 9, 2022
fix replay bug
Defined2014
pushed a commit
to Defined2014/tidb
that referenced
this pull request
Mar 15, 2022
support multi-schema change for add columns
sleepymole
pushed a commit
to sleepymole/tidb
that referenced
this pull request
Aug 22, 2022
fix: Fix missing required AZ for CreateVolumeFromSnapshot
zhongzc
pushed a commit
to zhongzc/tidb
that referenced
this pull request
Feb 6, 2023
refine stmt summary v2 retriever
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this pull request
Mar 5, 2024
…gcap#46706) (pingcap#47003) (pingcap#6) * client-go: attach request source with retry info for coprocessor (pingcap#46509) (pingcap#46706) close pingcap#46514 * restore bazelversiong Signed-off-by: you06 <you1474600@gmail.com> * remove unused field Signed-off-by: you06 <you1474600@gmail.com> * update client-go Signed-off-by: you06 <you1474600@gmail.com> --------- Signed-off-by: you06 <you1474600@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: you06 <you1474600@gmail.com> Co-authored-by: you06 <you1474600@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
wshwsh12
pushed a commit
to wshwsh12/tidb
that referenced
this pull request
Apr 16, 2025
fix incorrect column id and name
solotzg
pushed a commit
to solotzg/tidb
that referenced
this pull request
Mar 1, 2026
*: materialized view refresh optimizer updates
Open
13 tasks
13 tasks
takaidohigasi
added a commit
to takaidohigasi/tidb
that referenced
this pull request
May 17, 2026
Fixes for D3Hunter's review on pingcap#68028: [Blocker] Dual-password clauses are parsed but ignored by execution - Add executor stubs that reject RETAIN CURRENT PASSWORD / DISCARD OLD PASSWORD with ER_NOT_SUPPORTED_YET in executeAlterUser and executeSetPwd. Full execution / privilege / storage logic lives in the follow-up PR pingcap#68393. - Expose exeerrors.ErrNotSupportedYet for callers (was previously only available via dbterror.ClassExecutor.NewStd inline). - New TestDualPasswordParserOnlyStub in passwordtest to pin the stub's behavior. [Major pingcap#2] CREATE USER accepted dual-password clauses outside MySQL grammar - Drop the CreateUserSpec/CreateUserSpecList non-terminals and route CREATE USER back through the original UserSpec/UserSpecList chain. CREATE USER + RETAIN/DISCARD is now a parser-level syntax error, matching MySQL. [Major pingcap#3] ALTER USER over-accepted invalid RETAIN combinations - Introduce AuthOptionWithPassword (the BY-form subset of AuthOption) and restructure AlterUserSpec to bind RETAIN only to that subset. Reject at parse time: ALTER USER u IDENTIFIED WITH plugin AS '<hash>' RETAIN ... ALTER USER u IDENTIFIED WITH plugin RETAIN ... ALTER USER u RETAIN CURRENT PASSWORD (no auth) ALTER USER u IDENTIFIED BY '...' DISCARD OLD PASSWORD - DISCARD becomes its own AlterUserSpec variant (no auth-option coexists with it). [Major pingcap#4] Grammar label/documentation contradiction - Drop the misleading 'unsupported dual password option' label on the deleted CreateUserSpec; rewrite UserSpec/AlterUserSpec labels to state the contract accurately. [Major pingcap#5] Generic *PasswordOrLockOption type was overloaded - Introduce dedicated ast.DualPasswordOption and ast.DualPasswordOptionType (with DualPasswordRetainCurrent / DualPasswordDiscardOld). UserSpec.DualPasswordOption now uses the dedicated type. Remove the RetainCurrentPassword and DiscardOldPassword iota entries from PasswordOrLockOption. [Minor pingcap#6] ALTER USER USER() branch - USER() still does not route through AlterUserSpecList; dual-password on USER() is now a parse-time syntax error (covered by negative test). [Minor pingcap#7] Parser tests had no negative coverage - Add explicit ok=false rows for CREATE USER + RETAIN, the AS-hash + RETAIN form, bare RETAIN with no auth, plain BY + DISCARD, bare-plugin + RETAIN, and ALTER USER USER() + RETAIN. [Minor pingcap#8] CREATE/ALTER user-spec grammar duplication - Now naturally eliminated because CREATE USER reuses UserSpec. Behavior PR (pingcap#68393) needs to: - Remove the executor stubs added here. - Adopt the new ast.DualPasswordOption / DualPasswordOptionType symbols (the iota entries it currently consumes are gone). Ref pingcap#60587
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@qiuyesuifeng