Skip to content

Improve Documentation: various corrections of the English usage i…#4

Merged
ngaut merged 1 commit into
pingcap:masterfrom
chuchao333:feature/improve-readmes-enlish-usage
Sep 6, 2015
Merged

Improve Documentation: various corrections of the English usage i…#4
ngaut merged 1 commit into
pingcap:masterfrom
chuchao333:feature/improve-readmes-enlish-usage

Conversation

@chuchao333
Copy link
Copy Markdown
Contributor

@chuchao333 chuchao333 commented Sep 6, 2015

Thanks for sharing the great work! Just try to improve the README as I am reading through it.

@c4pt0r
Copy link
Copy Markdown
Member

c4pt0r commented Sep 6, 2015

Good job!
LGTM

@ngaut
Copy link
Copy Markdown
Member

ngaut commented Sep 6, 2015

LGTM

1 similar comment
@shenli
Copy link
Copy Markdown
Member

shenli commented Sep 6, 2015

LGTM

ngaut added a commit that referenced this pull request Sep 6, 2015
@ngaut
Merge pull request #4 from chuchao333/feature/improve-readmes-enlish-…
b7e5674 
…usage

Improvement Documentation: various corrections of the English usage i…
@ngaut ngaut merged commit b7e5674 into pingcap:master Sep 6, 2015
@chuchao333 chuchao333 changed the title Improvement Documentation: various corrections of the English usage i… Improve Documentation: various corrections of the English usage i… Sep 6, 2015
@chuchao333 chuchao333 deleted the feature/improve-readmes-enlish-usage branch September 6, 2015 07:30
@bb7133 bb7133 mentioned this pull request Sep 10, 2018
Merged
coocood added a commit to coocood/tidb that referenced this pull request Apr 18, 2019
@coocood @tiancaiamao
fix MemBuffer bug and use write conflict TS as for update TS (pingcap#4)
8abd975
IggieWang referenced this pull request in IggieWang/tidb Aug 11, 2019
@zouhuan1215
Merge pull request #4 from IggieWang/tmp
be28630 
finish virtual index DDL statement
@breezewish breezewish mentioned this pull request Sep 10, 2019
Closed
wph95 referenced this pull request in wph95/tidb Oct 6, 2019
@qiuyesuifeng
Merge pull request #4 from spongedu/complete_stream_agg
d0deb5a 
Complete stream agg
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
windtalker referenced this pull request in windtalker/tidb Apr 22, 2020
@windtalker
Merge pull request #4 from windtalker/hanfei/join-merge
7774284 
basic cbo support for broadcast join
Deardrops pushed a commit to Deardrops/tidb that referenced this pull request May 15, 2020
Merge pull request pingcap#4 from imtbkcat/supportLoginFail
0db9f6e 
privilege: support login fail count and account blacklist
@mahjonp mahjonp mentioned this pull request Aug 6, 2020
Open
@ti-srebot ti-srebot mentioned this pull request Sep 5, 2020
Closed
abbccdda pushed a commit to abbccdda/tidb that referenced this pull request Jan 16, 2021
@zhangjinpeng87
Merge pull request pingcap#4 from PatrickNicholas/2020-hackathon
5fc0756 
store: make network cost threshold as a Variable
djshow832 referenced this pull request in djshow832/tidb Mar 12, 2021
@nolouch
Merge pull request #4 from djshow832/fix_session
5d60731 
set staleness for transaction
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
@silentsai
pkg -- handle key-value operations (pingcap#4)
cc2913e 
* package for hanlding key-value operations

* with error checks

* kv encode now support execute sql convert in 'prepare statement' mode

* address comment

* address comment
YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021
@overvenus
Merge pull request pingcap#4 from pingcap/rate-limit
8481050 
backup: support rate limit
knull-cn added a commit to knull-cn/tidb that referenced this pull request Dec 31, 2021
@knull-cn
Merge pull request pingcap#4 from lichunzhu/addRFC
94c454c 
add rfc for hackathon 2021
TszKitLo40 pushed a commit to TszKitLo40/tidb that referenced this pull request Jan 3, 2022
@jyz0309
Merge pull request pingcap#4 from ti2sky/add-replay
48af694 
add init
crazycs520 referenced this pull request in crazycs520/tidb Jan 6, 2022
@crazycs520
Merge pull request #4 from rebelice/dev_where
bf88cdc 
create `aws` SQL, support WHERE for TableScan and Selection
AilinKid added a commit to AilinKid/tidb that referenced this pull request Mar 2, 2022
@AilinKid
introduce expr/constant into fdSet with uniqueID and refine some op's…
8a55d15 
… logic (pingcap#4)
@Benjamin2037 Benjamin2037 mentioned this pull request Jun 1, 2022
Closed
12 tasks
sleepymole referenced this pull request in sleepymole/tidb Aug 22, 2022
@fengou1
Merge pull request #4 from xu21yingan/patch-2
6cb49ea 
Fine tuning dry-run in order to avoid recover-data
zhongzc pushed a commit to zhongzc/tidb that referenced this pull request Feb 2, 2023
@mornyx
Merge pull request pingcap#4 from zhongzc/stmtsummary
7d92952 
fix build
keeplearning20221 added a commit to keeplearning20221/tidb that referenced this pull request Feb 13, 2023
@keeplearning20221
Merge pull request pingcap#4 from keeplearning20221/dependabot/go_mod…
6eb9cf2 
…ules/golang.org/x/oauth2-0.5.0

build(deps): bump golang.org/x/oauth2 from 0.2.0 to 0.5.0
ljun0712 pushed a commit to ljun0712/tidb that referenced this pull request Mar 1, 2023
@CbcWestwolf
update bazel (pingcap#4)
77296fd
rebelice added a commit to rebelice/tidb that referenced this pull request Mar 28, 2023
@rebelice
feat: add new restore flag RestoreCreateTableWithoutDefaultOption (pi…
81c8ec0 
…ngcap#4)
qw4990 added a commit to qw4990/tidb that referenced this pull request Jun 21, 2023
@qw4990
# This is a combination of 6 commits.
b6465f0 
# This is the 1st commit message:

fixup

# This is the commit message #2:

fixup

# This is the commit message pingcap#3:

fixup

# This is the commit message pingcap#4:

fixup

# This is the commit message pingcap#5:

fixup

# This is the commit message pingcap#6:

fixup
rleungx pushed a commit to rleungx/tidb that referenced this pull request Feb 26, 2024
@clark1013 @lcwangchao
@CbcWestwolf @ti-chi-bot @wuhuizuo @zeminzhou @baiyuqing
extension/serverless: introduce serverless audit log (pingcap#870)
aef4fc1 
* init

* audit: init first version of audit log

* audit: support log global rotate

* audit: update log keys

* audit: more common notify implement

* audit: add record id

* audit: rename some names

* audit: default use normal log path

* audit: add server ip info

* audit: do some refine

* audit: Add some log keys

* audit: update some item format

* audit: add stmt demo

* audit: support redact

* audit: fix bug

* audit: update filter

* audit: update filter

* audit: check user

* audit: update

* update

* audit: update

* audit: fix bug

* aduit: update

* audit: update

* update

* update

* audit: add filter unit test

* fmt

* Add tests for `tidb_audit_enabled` and `tidb_audit_log`

* Add tests for `tidb_audit_log_max_size` and `tidb_audit_log_max_lifetime`

* Add tests for `tidb_audit_log_reserved_*`

* TODO: TestAuditLogRedact

* Fininsh `TestAuditLogRedact`

* Update (pingcap#1)

* fix typo (pingcap#2)

* Add `TRANSACTION`

* rename sysvar

* audit_log_create_filter, audit_log_remove_filter

* finish function call and table test

* test privilege

* finish test for sysvar

* TODO: TestConnectionEvenClass

* update

* audit: fix lint for audit log (pingcap#1)

* audit: fix UT failure caused by the change of redact log (pingcap#3)

* audit: use `t.TempDir()` to make test stable (pingcap#4)

* audit: fix test failed for 7.1

* Add `OWNERS` file (pingcap#35)

Co-authored-by: Chao Wang <cclcwangchao@hotmail.com>

* audit: fix panic when logging sometime (pingcap#26) (pingcap#31)

* test: fix unstable test TestAuditLogReservedDays (pingcap#8)

* Format sysvar_test.go

* audit: use `StatementContext` to generate redacted SQL (pingcap#9)

* audit: fix panic when logging sometime (pingcap#26)

* update

* add owner

* Update OWNERS

---------

Co-authored-by: CbcWestwolf <1004626265@qq.com>
Co-authored-by: wuhuizuo <wuhuizuo@126.com>

* audit: fix panic sometimes when `create user` without password (pingcap#37) (pingcap#39)

* This is an automated cherry-pick of pingcap#37

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix conflict

---------

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: 王超 <cclcwangchao@hotmail.com>

* extension/audit: introduce serverless audit log

Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com>

* update bazel config

Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com>

* support enable audit log when activate

Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com>

* add gwconnid to audit log

Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com>

* comment unstable test

* update bazel

* add log about activate request

* diff audit log enabled

* audit: fix memory leak for executeSQL (pingcap#44) (pingcap#45)

* This is an automated cherry-pick of pingcap#44

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* Update util.go

---------

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Co-authored-by: 王超 <cclcwangchao@hotmail.com>

* Update extension/serverless/OWNERS

---------

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Wen Jiazhi <jiazhi.wen@pingcap.com>
Co-authored-by: Chao Wang <cclcwangchao@hotmail.com>
Co-authored-by: cbcwestwolf <1004626265@qq.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: wuhuizuo <wuhuizuo@126.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
Co-authored-by: Yuqing Bai <baiyuq@gmail.com>
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
@Tema @crazycs520
*: add global variable tidb_schema_version_cache_limit to control inf…
d0fc624 
…oschema cache size and refine metric (pingcap#46684) (pingcap#4)

Signed-off-by: crazycs520 <crazycs520@gmail.com>

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Co-authored-by: crazycs <crazycs520@gmail.com>
@s4sukan s4sukan mentioned this pull request Mar 27, 2024
Open
@pantheon-ai pantheon-ai Bot mentioned this pull request Jan 20, 2026
Open
13 tasks
gengliqi pushed a commit to gengliqi/tidb that referenced this pull request Feb 28, 2026
@windtalker
Merge pull request pingcap#4 from solotzg/mv_tzg
5705de1 
Materialized View Service
@JmPotato JmPotato mentioned this pull request Apr 14, 2026
Merged
2 tasks
@takaidohigasi takaidohigasi mentioned this pull request Apr 24, 2026
Open
13 tasks
@mjonss mjonss mentioned this pull request Apr 29, 2026
Closed
13 tasks
premal added a commit to 6si/tidb that referenced this pull request May 4, 2026
@premal @claude
planner/executor: fix shard-key PointGet panics and misrouting
e41fb3c 
Bug pingcap#4 — panic in PointGetPlan.AccessObject and LoadTableStats when a
partitioned+sharded table is accessed by PK/index on UPDATE/DELETE.
GetPartitionIdxByRow returns a flat shard index (partIdx*shardCnt+slot)
which was used directly to index pi.Definitions (original partition count),
causing index-out-of-range. Fix maps flat→logical via idx/ShardCnt before
indexing the original PI for display (access_object.go, point_get_plan.go)
and resolves to the physical shard ID for KV access (GetPhysID in executor).

Bug pingcap#1 — PointGetPlan misroutes PK-only queries on sharded tables to the
wrong shard because locateShard hashes a zero shard-key column value.
Fix: decline to generate PointGetPlan when the predicate omits the shard key;
queries like WHERE id=X fall back to a table scan covering all shards.

Bug pingcap#3 — RANGE/HASH/KEY+shard tables with a shard-only filter always pruned
to partition p0 because PartitionPruning called pruneShardKeyPartition
directly (returning flat indices only in the first partition's range).
Fix: use pruneShardedRangeOrHashDynamic which expands matched shard slots
across all logical partitions.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
premal added a commit to 6si/tidb that referenced this pull request May 4, 2026
@premal @claude
test(shard): add routing math unit tests for Bug pingcap#4, pingcap#3, …
376dfd6 
…pingcap#1 regressions

Adds 7 unit tests to shard_test.go covering the flatIdx arithmetic,
shardForRow bounds safety, rebuildShards post-DROP-PARTITION, and
PartitionExpr staleness detection. Tests run without a live cluster
and directly exercise the 4×4 layout (4 partitions × 4 shards) that
triggered the OOB panic in production (Bug pingcap#4).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@joechenrh joechenrh mentioned this pull request May 13, 2026
Open
13 tasks
takaidohigasi added a commit to takaidohigasi/tidb that referenced this pull request May 17, 2026
@takaidohigasi
*: address @D3Hunter review (parser PR)
adb27a7 
Fixes for D3Hunter's review on pingcap#68028:

[Blocker] Dual-password clauses are parsed but ignored by execution
  - Add executor stubs that reject RETAIN CURRENT PASSWORD / DISCARD
    OLD PASSWORD with ER_NOT_SUPPORTED_YET in executeAlterUser and
    executeSetPwd. Full execution / privilege / storage logic lives in
    the follow-up PR pingcap#68393.
  - Expose exeerrors.ErrNotSupportedYet for callers (was previously
    only available via dbterror.ClassExecutor.NewStd inline).
  - New TestDualPasswordParserOnlyStub in passwordtest to pin the
    stub's behavior.

[Major pingcap#2] CREATE USER accepted dual-password clauses outside MySQL grammar
  - Drop the CreateUserSpec/CreateUserSpecList non-terminals and route
    CREATE USER back through the original UserSpec/UserSpecList chain.
    CREATE USER + RETAIN/DISCARD is now a parser-level syntax error,
    matching MySQL.

[Major pingcap#3] ALTER USER over-accepted invalid RETAIN combinations
  - Introduce AuthOptionWithPassword (the BY-form subset of AuthOption)
    and restructure AlterUserSpec to bind RETAIN only to that subset.
    Reject at parse time:
      ALTER USER u IDENTIFIED WITH plugin AS '<hash>' RETAIN ...
      ALTER USER u IDENTIFIED WITH plugin RETAIN ...
      ALTER USER u RETAIN CURRENT PASSWORD (no auth)
      ALTER USER u IDENTIFIED BY '...' DISCARD OLD PASSWORD
  - DISCARD becomes its own AlterUserSpec variant (no auth-option
    coexists with it).

[Major pingcap#4] Grammar label/documentation contradiction
  - Drop the misleading 'unsupported dual password option' label on the
    deleted CreateUserSpec; rewrite UserSpec/AlterUserSpec labels to
    state the contract accurately.

[Major pingcap#5] Generic *PasswordOrLockOption type was overloaded
  - Introduce dedicated ast.DualPasswordOption and
    ast.DualPasswordOptionType (with DualPasswordRetainCurrent /
    DualPasswordDiscardOld). UserSpec.DualPasswordOption now uses the
    dedicated type. Remove the RetainCurrentPassword and
    DiscardOldPassword iota entries from PasswordOrLockOption.

[Minor pingcap#6] ALTER USER USER() branch
  - USER() still does not route through AlterUserSpecList; dual-password
    on USER() is now a parse-time syntax error (covered by negative test).

[Minor pingcap#7] Parser tests had no negative coverage
  - Add explicit ok=false rows for CREATE USER + RETAIN, the AS-hash +
    RETAIN form, bare RETAIN with no auth, plain BY + DISCARD,
    bare-plugin + RETAIN, and ALTER USER USER() + RETAIN.

[Minor pingcap#8] CREATE/ALTER user-spec grammar duplication
  - Now naturally eliminated because CREATE USER reuses UserSpec.

Behavior PR (pingcap#68393) needs to:
  - Remove the executor stubs added here.
  - Adopt the new ast.DualPasswordOption / DualPasswordOptionType
    symbols (the iota entries it currently consumes are gone).

Ref pingcap#60587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

contribution This PR is from a community contributor.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chuchao333 @c4pt0r @ngaut @shenli @sre-bot