PageStorage: Fix invalid offset after restart#6237
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/run-all-tests |
84cdaeb to
77dd226
Compare
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
Co-authored-by: lidezhu <47731263+lidezhu@users.noreply.github.com>
|
/run-all-tests |
|
/merge |
|
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: d1cad72 |
|
@JaySon-Huang: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #6218
Problem Summary:
Introduce by #6168
The fix can not properly handle the following situation

What is changed and how it works?
WriteBatch{ put X, ref Y->X, delete X}inside one WriteBatch (PageDirectory::apply)PageDirectory.sequenceat last{ upsert-entry }and decrease the ref-count of origin-id{ upsert-entry, delete_ver}Check List
Tests
Run chbenchmark with warehouse 100 and tiflash random kill. TiFlash can restart normally.
Side effects
Documentation
Release note