AOL Adapter - ONE Mobile endpoint implemented.#1115
AOL Adapter - ONE Mobile endpoint implemented.#1115jaiminpanchal27 merged 3 commits intoprebid:masterfrom
Conversation
mp-12301
changed the title
snapwich
left a comment
snapwich
left a comment
There was a problem hiding this comment.
Some suggested changes added, but LGTM
src/adapters/aol.js
Outdated
| if (document.addEventListener) { | ||
| document.addEventListener("DOMContentLoaded", idempotentFn, false); | ||
| window.addEventListener("load", idempotentFn, false); | ||
| } else if (document.attachEvent) { |
There was a problem hiding this comment.
Prebid.js only supports IE9+, so you should be fine with using addEventListener only.
| document.body.appendChild(iframe); | ||
| } else { | ||
| domReady(() => { | ||
| document.body.appendChild(iframe); |
There was a problem hiding this comment.
Since you're checking the readyState above, I think removing domReady and just using DOMContentLoaded should be sufficient here.
jaiminpanchal27
left a comment
jaiminpanchal27
left a comment
There was a problem hiding this comment.
Left one comment if it can done.
| pixelsElements.forEach((element) => { | ||
| switch (element.tagName) { | ||
| case SYNC_TYPES.img: | ||
| return renderPixelImage(element); |
There was a problem hiding this comment.
Check if you can reuse these functions
https://github.com/prebid/Prebid.js/blob/master/src/utils.js#L446
There was a problem hiding this comment.
Hi. Thank you for the note.
If we reuse this method we will have to insert elements in DOM directly.
We would like to avoid it so we prefer to use own implementation.
vzhukovsky
left a comment
vzhukovsky
left a comment
There was a problem hiding this comment.
Removed code for supporting IE 9. Waiting approvals.
|
This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing |
…built * 'master' of https://github.com/prebid/Prebid.js: (21 commits) add lodash as dependency (prebid#1174) fix size mapping for s2s (prebid#1175) Improve footer styling (prebid#1171) Bugfix: internal bids requested overwritten (prebid#1173) pre-release version bump Prebid 0.23.0 Release Yieldbot adapter - multiple requestBids per pageview (prebid#1146) Widespace adapter validate size fix (prebid#1140) Audience Network: bid when at least one valid slot size (prebid#1148) Quantcast adaptor (prebid#1063) AOL Adapter - ONE Mobile endpoint implemented. (prebid#1115) Prebid Server to Server (prebid#1165) Pubgears Header Bidding Adapter (prebid#953) remove old adloader#trackPixel (prebid#1159) added audit beacon to detect misuse of this bidder. Detects auctions… (prebid#1134) Bidfluence CDN endpoint URL update (prebid#1163) AdSupply adapter (prebid#1162) Sonobi Adapter - Enable size overrides (prebid#1141) Added an editorconfig file to match jshint and jssrc files. (prebid#1147) force cpm to be a number (prebid#1161) ...
5 participants
Type of change
Description of change
This PR is to implement the ONE Mobile endpoint, which is a second endpoint where bid requests can be made from depending on the parameters set on the bid config. This also adds a feature where if enabled by choice the adapter will drop sync pixels on bid response.
Is there a formal procedure for updating the bidder params for the AOL adapter?