Merged
Conversation
matthewlane
reviewed
May 1, 2017
test/spec/adapters/adsupply_spec.js
Outdated
| describe('adsupply adapter tests', function () { | ||
|
|
||
| const expect = require('chai').expect; | ||
| const assert = require('chai').assert; |
Collaborator
There was a problem hiding this comment.
This isn't used, can be removed
Contributor
Author
There was a problem hiding this comment.
const assert = require('chai').assert; - REMOVED
const expect = require('chai').expect; - USED in the first test
src/adapters/adsupply.js
Outdated
| return false; | ||
| } | ||
|
|
||
| if (typeof params.zoneId !== "number" || params.zoneId <= 0) { |
Collaborator
There was a problem hiding this comment.
Upcoming ESLint error: prefer single quotes around number
src/adapters/adsupply.js
Outdated
|
|
||
| if (!media) return; | ||
|
|
||
| if (!media.Url || !media.Ecpm || typeof media.Ecpm !== "number" || media.Ecpm <= 0) { |
Collaborator
There was a problem hiding this comment.
Also prefer single quotes around number here
src/adapters/adsupply.js
Outdated
| }; | ||
| }; | ||
|
|
||
| module.exports = AdSupplyAdapter; No newline at end of file |
Collaborator
There was a problem hiding this comment.
ESLint error: newline required at end of file
Contributor
Author
There was a problem hiding this comment.
Added a new line at the end. "Files changed" tab doesn't show it for some reason but if you try to edit the file with online editor you will see there's an empty line at the end of the file. Hope it helps to fix the ESLint error.
matthewlane
approved these changes
May 2, 2017
jaiminpanchal27
approved these changes
May 2, 2017
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
May 4, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: (21 commits) add lodash as dependency (prebid#1174) fix size mapping for s2s (prebid#1175) Improve footer styling (prebid#1171) Bugfix: internal bids requested overwritten (prebid#1173) pre-release version bump Prebid 0.23.0 Release Yieldbot adapter - multiple requestBids per pageview (prebid#1146) Widespace adapter validate size fix (prebid#1140) Audience Network: bid when at least one valid slot size (prebid#1148) Quantcast adaptor (prebid#1063) AOL Adapter - ONE Mobile endpoint implemented. (prebid#1115) Prebid Server to Server (prebid#1165) Pubgears Header Bidding Adapter (prebid#953) remove old adloader#trackPixel (prebid#1159) added audit beacon to detect misuse of this bidder. Detects auctions… (prebid#1134) Bidfluence CDN endpoint URL update (prebid#1163) AdSupply adapter (prebid#1162) Sonobi Adapter - Enable size overrides (prebid#1141) Added an editorconfig file to match jshint and jssrc files. (prebid#1147) force cpm to be a number (prebid#1161) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Other information