sekindoUM for prebid1.0

[nissSK]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other

Description of change

sekindoUM for prebid1.0

• test parameters for validating bids

 var adUnits = [{
      code: 'banner-ad-div',
      sizes: [[300, 250]],
      bids: [{
          bidder: 'sekindoUM',
          params: {
              spaceId: 14071
          }
      }]
    },
        {
      code: 'video-ad-div',
      sizes: [[640, 480]],
      bids: [{
          bidder: 'sekindoUM',
          params: {
              spaceId: 87812,
                          video:{
                                playerWidth:640,
                                playerHeight:480,
                                vid_vastType: 5 //optional
                          }
          }
      }]
    }
        ];

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
• official adapter submission

Other information

[snapwich]

LGTM

[matthewlane]

There was a breaking change added recently that requires an update to the interpretResponse function, and a few other notes for your review

[matthewlane]

Line can be removed if not used

[nissSK]

done

[matthewlane]

#1748 changed the first argument of interpretResponse to:

{
  body: responseBody,
  headers: {
    get: function(header) { /* returns a header from the HTTP response */ }
  }
}

so adding something like

serverResponse = serverResponse.body;

just below this line, or however you'd prefer to grab the body, and updating corresponding tests if needed should get this back to working properly

[nissSK]

done

[matthewlane]

As of #1483, video ad units may be defined with mediaTypes: {video: {}} and would be on this bid parameter, you'll probably want to check for that as well

[nissSK]

done

[matthewlane]

May want to check for mediaTypes.video as well, see other comment for related info

[nissSK]

done

[jsnellbaker]

@nissSK I saw your updates to the feedback from @matthewlane, but I don't see that the changes were committed. Are those changes still in the works on your end?

Please confirm when you get the chance. Thanks!

[nissSK]

@jsnellbaker Should be ok now (pushed changes to prebid1.0 instead of master)

[matthewlane]

@nissSK Changes look good but the 405 file changes are a bit concerning. Looks chmod related, if those can be resolved so there are just the 3 sekindo file changes we should be good for merge

[nissSK]

@matthewlane Sure, didnt notice that.