Skip to content

AdkernelAdn analytics adapter#1868

Merged
jsnellbaker merged 2 commits intoprebid:masterfrom
ckbo3hrk:adk_analytics
Nov 29, 2017
Merged

AdkernelAdn analytics adapter#1868
jsnellbaker merged 2 commits intoprebid:masterfrom
ckbo3hrk:adk_analytics

Conversation

@ckbo3hrk
Copy link
Contributor

@ckbo3hrk ckbo3hrk commented Nov 22, 2017

Type of change

  • Bugfix
  • Feature
  • New analytics adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Adkernel Ad Delivery Network analytics adapter

  • test parameters for adapter
{
  provider: 'adkernelAdn',
    options : {
      pubId : 50357,   //id provided by adkernel
      host: 'dsp-staging.adkernel.com'  //optional host for validation purposes
    }
}

Other information

mike-chowla
mike-chowla approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @pm-harshad-mane is swamped, I thought I'd step in and help out.

No serious issues found.

Minor issues:

  1. The AJAX calls out return a GIF which seems a bit odd. The GIF is not causing any errors.
  2. The markdown page doesn't show any of the parameters needed to configure the adaptor

@mike-chowla
Copy link
Contributor

mike-chowla commented Nov 29, 2017

One other note, the adaptor has code for parsing size arrays in it. It could call the utils functions for size array parsing instead having it's own code to do so

@ckbo3hrk
Copy link
Contributor Author

ckbo3hrk commented Nov 29, 2017

@mike-chowla GIF-response will be optimized with the next backend update

jsnellbaker
jsnellbaker approved these changes Nov 29, 2017
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker merged commit cba0814 into prebid:master Nov 29, 2017
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Dec 8, 2017
Merge branch 'master' of https://github.com/prebid/Prebid.js
4273734 
* 'master' of https://github.com/prebid/Prebid.js: (43 commits)
  Merge Prebid 1.0 to Master (prebid#1936)
  Prebid.js 0.34.1 release
  Vertamedia adapter outstream support (prebid#1860)
  Expose native image-type asset dimensions on bid response object (prebid#1919)
  Remove for of (prebid#1932)
  Unit-test fix (prebid#1927)
  Remove description_url (prebid#1922)
  Trion Interactive Adapter Bugfix (prebid#1925)
  Remove config setting from Optimatic adapter (prebid#1909)
  IE bug fix (prebid#1930)
  Clarify ad unit media filtering warning (prebid#1903)
  Add ReadPeak Bid Adapter (prebid#1838)
  Change clone function to make deep copies (prebid#1910)
  Serverbid 1.0 (prebid#1802)
  sekindoUM for prebid1.0 (prebid#1777)
  update auctionId to be requestId (prebid#1896)
  bug fixed to populate userSync default values (prebid#1897)
  Increment pre version
  AdkernelAdn analytics adapter (prebid#1868)
  Justpremium Adapter: use `filter` instead of `...new Set` (prebid#1895)
  ...
@ckbo3hrk ckbo3hrk deleted the adk_analytics branch December 12, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mike-chowla mike-chowla mike-chowla approved these changes

@jsnellbaker jsnellbaker jsnellbaker approved these changes

@pm-harshad-mane pm-harshad-mane Awaiting requested review from pm-harshad-mane

Assignees

@pm-harshad-mane pm-harshad-mane

@jsnellbaker jsnellbaker

Labels

LGTM

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ckbo3hrk @mike-chowla @jsnellbaker @pm-harshad-mane

Comments