Add ReadPeak Bid Adapter by kurrestahlberg · Pull Request #1838 · prebid/Prebid.js

kurrestahlberg · 2017-11-15T22:13:29Z

Type of change

New bidder adapter

Description of change

Bid adapter for readpeak.com, a purely native bidder from Finland

test parameters for validating bids

{
  bidder: 'readpeak',
  params: {
     bidfloor: 5.00,
     publisherId: 'test'
   },
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer kurre.stahlberg@readpeak.com
official adapter submission

Other information

mkendall07 · 2017-11-27T22:12:36Z

modules/readpeakBidAdapter.js

+      const bid = {
+        requestId: id,
+        cpm: idToBidMap[id].price,
+        creativeId: id,


Is the creativeId really just the request id? Doesn't seem correct.

mkendall07 · 2017-11-27T22:13:13Z

modules/readpeakBidAdapter.js

+        currency: bidResponse.cur,
+        bidderCode: BIDDER_CODE,
+      };
+      bid['native'] = nativeResponse(idToImpMap[id], idToBidMap[id]);


no need to use bracket notation here.

mkendall07 · 2017-11-27T22:33:12Z

modules/readpeakBidAdapter.js

+        requestId: id,
+        cpm: idToBidMap[id].price,
+        creativeId: id,
+        adId: id,


adId can be dropped. I forgot this was the legacy bid identifier. It will be found on the requestId now

mkendall07 · 2017-11-27T22:36:10Z

@kurrestahlberg
Thanks for the submission! Needs a few minor updates.

Also it looks like I'm not receiving bid response. Here is the request generated to assist with testing:

{"id":"35bb8c9a63e32c","imp":[{"id":"486443e023cc9e","native":{"request":"{\"assets\":[{\"id\":1,\"required\":1,\"title\":{\"len\":70}},{\"id\":4,\"required\":1,\"data\":{\"type\":2,\"len\":120}}]}","ver":"1.1"},"bidfloor":5,"bidfloorcur":"USD"}],"site":{"publisher":{"id":"test"},"id":"test","ref":"","page":"http://ap.localhost:9999/integrationExamples/native_test.html","domain":"ap.localhost"},"app":null,"device":{"ua":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36","language":"en-US"},"isPrebid":true}

kurrestahlberg · 2017-11-28T22:46:09Z

Thanks for the review! I have fixed the issues you pointed out. We seem to have a minor configuration issue in our backend right now and thus it returns 204 for the test publisher id. I will get it fixed asap.

kurrestahlberg · 2017-11-29T13:57:05Z

@mkendall07
Everything should be in order again. Please retest.

mkendall07 · 2017-11-29T15:15:05Z

modules/readpeakBidAdapter.js

+        netRevenue: true,
+        mediaType: 'native',
+        currency: bidResponse.cur,
+        bidderCode: BIDDER_CODE,


please drop bidder code. This will be added automatically.

mkendall07 · 2017-11-29T15:28:28Z

@kurrestahlberg
if you make those changes quick I'll retest

mkendall07 · 2017-11-29T16:35:18Z

seeing bids now. Just need bidderCode dropped and we are good to merge

kurrestahlberg · 2017-11-29T17:27:09Z

@mkendall07
Should be okay now even though it fails with OOM. Sorry for the extra commits, the tests run so slow on my laptop that I always push while they are running...

kurrestahlberg · 2017-11-29T17:31:55Z

I don't know how to trigger rerun for travis.

mkendall07 · 2017-11-29T19:07:32Z

restarted the build

mkendall07 · 2017-11-30T16:24:49Z

@kurrestahlberg
I'm seeing bid returned but our test creative isn't displaying. I haven't had a chance to dig further into it. Do you have a test page that is working?

kurrestahlberg · 2017-11-30T19:07:49Z

@mkendall07
I'm having trouble getting anything to show here, but I can see that the native parts are sent and they look correct to me.

The following is sent as prev_scp:

hb_native_linkurl=https%253A%252F%252Fapp.readpeak.com%252Fads%252Ftracker%252F528%252F4_askelta_vaikuttavaan_natiivimainontaan%253Fl%253D95%2526a%253D3149%2526ka%253D1534%2526avn%253D1%2526b%253D487b0c08-74e5-49d4-8e48-9ad46630f622&hb_native_cta=&hb_native_image=https%3A%2F%2Fs3.eu-central-1.amazonaws.com%2Freadpeak%2Ffiles%2Farticle_thumbs%2Fthumb-408-c38808e3de9412fde8ce40b7a652f8cb.jpg&hb_native_brand=&hb_native_body=ReadPeak-k%C3%A4ytt%C3%B6liittym%C3%A4%20on%20kevyt%20ja%20ketter%C3%A4%20natiivimainonnan%20ty%C3%B6kalu%20jonka%20kautta%20tavoitat%20aiheistasi%20kiinnostun...&hb_native_title=4%20askelta%20vaikuttavaan%20natiivimainontaan&hb_size=0x0&hb_pb=5.80&hb_adid=24c0f8e5758435&hb_bidder=readpeak

The only odd bit to me is hb_size, and I am not sure if the regular test page will show both banners and native.

mkendall07 · 2017-11-30T22:15:42Z

Ok figured it out - I wasn't overidding the bid CPM and our native placement only responds to nice round numbers...

anyway LGTM:

* 'master' of https://github.com/prebid/Prebid.js: (43 commits) Merge Prebid 1.0 to Master (prebid#1936) Prebid.js 0.34.1 release Vertamedia adapter outstream support (prebid#1860) Expose native image-type asset dimensions on bid response object (prebid#1919) Remove for of (prebid#1932) Unit-test fix (prebid#1927) Remove description_url (prebid#1922) Trion Interactive Adapter Bugfix (prebid#1925) Remove config setting from Optimatic adapter (prebid#1909) IE bug fix (prebid#1930) Clarify ad unit media filtering warning (prebid#1903) Add ReadPeak Bid Adapter (prebid#1838) Change clone function to make deep copies (prebid#1910) Serverbid 1.0 (prebid#1802) sekindoUM for prebid1.0 (prebid#1777) update auctionId to be requestId (prebid#1896) bug fixed to populate userSync default values (prebid#1897) Increment pre version AdkernelAdn analytics adapter (prebid#1868) Justpremium Adapter: use `filter` instead of `...new Set` (prebid#1895) ...

….34.0 to aolgithub-master * commit 'f0ba90afa8b52de7a646d43928b2d51ee42e74a1': (53 commits) Added changelog entry. Added partners ids. Added dynamic ttl property for One Display and One Mobile. Prebid.js 0.34.1 release Vertamedia adapter outstream support (prebid#1860) Expose native image-type asset dimensions on bid response object (prebid#1919) Remove for of (prebid#1932) Unit-test fix (prebid#1927) Remove description_url (prebid#1922) Trion Interactive Adapter Bugfix (prebid#1925) Remove config setting from Optimatic adapter (prebid#1909) IE bug fix (prebid#1930) Clarify ad unit media filtering warning (prebid#1903) Add ReadPeak Bid Adapter (prebid#1838) Change clone function to make deep copies (prebid#1910) Serverbid 1.0 (prebid#1802) sekindoUM for prebid1.0 (prebid#1777) update auctionId to be requestId (prebid#1896) bug fixed to populate userSync default values (prebid#1897) Increment pre version ...

Kurre Ståhlberg added 2 commits November 16, 2017 00:11

Add ReadPeak Bid Adapter

bc72367

Remove protocol from endpoint address

46a98f0

jaiminpanchal27 assigned mkendall07 Nov 16, 2017

jaiminpanchal27 added needs review Prebid 1.0 labels Nov 16, 2017

Make bidfloor optional

ff814ad

kurrestahlberg mentioned this pull request Nov 16, 2017

Add ReadPeak Bid Adapter Documentation prebid/prebid.github.io#445

Merged

Update ReadPeak Bidder tests

ce9b2a3

mkendall07 reviewed Nov 27, 2017

View reviewed changes

mkendall07 added not receiving bids needs update and removed needs review labels Nov 27, 2017

Fix creative id, remove ad id from response.

207a9ab

Kurre Ståhlberg added 2 commits November 29, 2017 01:02

Fix tests

e2449a3

Merge remote-tracking branch 'upstream/master'

a48760b

mkendall07 reviewed Nov 29, 2017

View reviewed changes

mkendall07 removed the not receiving bids label Nov 29, 2017

Kurre Ståhlberg added 2 commits November 29, 2017 19:18

Drop bidderCode

75a8208

Fix tests

de02c08

bretg added the ready label Nov 29, 2017

mkendall07 added LGTM and removed needs update labels Nov 30, 2017

mkendall07 assigned matthewlane Nov 30, 2017

jaiminpanchal27 self-requested a review December 4, 2017 22:04

jaiminpanchal27 approved these changes Dec 4, 2017

View reviewed changes

jaiminpanchal27 merged commit 05e4853 into prebid:master Dec 4, 2017

Conversation

kurrestahlberg commented Nov 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Other information

Uh oh!

mkendall07 Nov 27, 2017

Choose a reason for hiding this comment

Uh oh!

mkendall07 Nov 27, 2017

Choose a reason for hiding this comment

Uh oh!

mkendall07 Nov 27, 2017

Choose a reason for hiding this comment

Uh oh!

mkendall07 commented Nov 27, 2017

Uh oh!

kurrestahlberg commented Nov 28, 2017

Uh oh!

kurrestahlberg commented Nov 29, 2017

Uh oh!

mkendall07 Nov 29, 2017

Choose a reason for hiding this comment

Uh oh!

mkendall07 commented Nov 29, 2017

Uh oh!

mkendall07 commented Nov 29, 2017

Uh oh!

kurrestahlberg commented Nov 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kurrestahlberg commented Nov 29, 2017

Uh oh!

mkendall07 commented Nov 29, 2017

Uh oh!

mkendall07 commented Nov 30, 2017

Uh oh!

kurrestahlberg commented Nov 30, 2017

Uh oh!

mkendall07 commented Nov 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

kurrestahlberg commented Nov 15, 2017 •

edited

Loading

kurrestahlberg commented Nov 29, 2017 •

edited

Loading