Release 3.10.0 by nicoddemus · Pull Request #4297 · pytest-dev/pytest

nicoddemus · 2018-11-03T13:53:00Z

No description provided.

… could still get working

Make --color more colorful

…features Merge master into features

…epwise

Fix pytest-dev#611

Issue a warning when a fixture named 'request' is collected

…_remove_writable minor: remove unused _shutil_rmtree_remove_writable

Running `pytest -k doesnotmatch` on pytest's own tests takes ~3s with Kitty terminal for me, but only ~1s with `-q`. It also is faster with urxvt, but still takes 2.2s there. This patch only calls `report_collect` every 0.1s, which is good enough for reporting collection progress, and improves the time with both Kitty and urxvt to ~1.2s for me.

For pytest's own suite the `cache_info()` looks as follows: > session.config._getconftest_pathlist.cache_info() CacheInfo(hits=231, misses=19, maxsize=None, currsize=19) While it does not really make a difference for me this might help with larger test suites / the case mentioned in pytest-dev#2206 (comment).

TerminalWriter: write "collecting" msg only once every 0.5s

Merge master into features

Also renames `_path2confmods` to `_dirpath2confmods` for clarity (it is expected to be a dirpath in `_importconftest`). Uses an explicit maxsize, since it appears to be only relevant for a short period [1]. Removes the lru_cache on _getconftest_pathlist, which makes no difference when caching _getconftestmodules, at least with the performance test of 100x10 files (pytest-dev#4237). 1: pytest-dev#4237 (comment)

…-msg pdb: improve msg about output capturing with set_trace

_getconftestmodules: use functools.lru_cache

cacheprovider: display cachedir also in non-verbose mode if customized

Time: 8.53s => 5.73s

Time: 5.73s => 5.88s/5.82s

Time: 5.73s/5.88s => 5.36s (Before rebase: 4.86s => 4.45s)

Time: 5.36s => 4.85s (before rebase: 4.45s => 3.55s)

Performance fixes

blueyed · 2018-11-03T16:48:07Z

Linting fails:

WARNING CHANGELOG.rst:3 Duplicate explicit target name: "the documentation".

RonnyPfannschmidt · 2018-11-03T20:19:05Z

@nicoddemus wrong target branch?

RonnyPfannschmidt · 2018-11-03T20:22:45Z

please excuse that mistake, i missed the merge of the master branch
i propose we always mege master into features before creating a release branch to avoid startleing our human selfes

blueyed · 2018-11-03T20:23:30Z

Still makes sense to target master here, no?
That's also what HOWTORELEASE says.

RonnyPfannschmidt

please fix the change-log ref duplication ^^

codecov · 2018-11-03T22:52:26Z

Codecov Report

Merging #4297 into master will decrease coverage by 0.07%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master    #4297      +/-   ##
==========================================
- Coverage   95.86%   95.79%   -0.08%     
==========================================
  Files         109      111       +2     
  Lines       24681    24922     +241     
  Branches     2396     2444      +48     
==========================================
+ Hits        23661    23873     +212     
- Misses        723      748      +25     
- Partials      297      301       +4

Flag	Coverage Δ
#docs	`28.9% <34.96%> (-0.05%)`	⬇️
#doctesting	`28.9% <34.96%> (-0.05%)`	⬇️
#linting	`28.9% <34.96%> (-0.05%)`	⬇️
#linux	`95.57% <90.47%> (-0.08%)`	⬇️
#nobyte	`91.81% <71.76%> (-0.18%)`	⬇️
#numpy	`92.92% <87.75%> (-0.08%)`	⬇️
#pexpect	`41.61% <52.81%> (-0.02%)`	⬇️
#py27	`93.92% <86.39%> (-0.12%)`	⬇️
#py34	`92.13% <72.44%> (-0.14%)`	⬇️
#py35	`92.14% <72.44%> (-0.14%)`	⬇️
#py36	`93.83% <84.01%> (-0.14%)`	⬇️
#py37	`92.2% <79.02%> (-0.1%)`	⬇️
#trial	`92.92% <87.75%> (-0.08%)`	⬇️
#windows	`93.97% <75.87%> (-0.16%)`	⬇️
#xdist	`93.71% <74.14%> (-0.17%)`	⬇️

Impacted Files	Coverage Δ
src/_pytest/capture.py	`93.42% <100%> (+0.02%)`	⬆️
src/_pytest/main.py	`96.88% <100%> (+0.59%)`	⬆️
testing/test_stepwise.py	`100% <100%> (ø)`
src/_pytest/deprecated.py	`100% <100%> (ø)`	⬆️
src/_pytest/config/__init__.py	`95% <100%> (+0.02%)`	⬆️
src/_pytest/hookspec.py	`100% <100%> (ø)`	⬆️
testing/deprecated_test.py	`100% <100%> (ø)`	⬆️
src/_pytest/compat.py	`96.87% <100%> (+0.1%)`	⬆️
testing/test_cacheprovider.py	`99.7% <100%> (ø)`	⬆️
testing/test_conftest.py	`99.61% <100%> (ø)`	⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b9bbd...3d88d18. Read the comment docs.

nicoddemus · 2018-11-03T23:11:07Z

Changed the base as requested

blueyed · 2018-11-04T00:57:10Z

AppVeyour failed again in the middle:

Build started
git clone -q https://github.com/pytest-dev/pytest.git C:\projects\pytest
git fetch -q origin +refs/pull/4297/merge:
git checkout -qf FETCH_HEAD
Error making request with Error Code Forbidden and Http Status Code Forbidden. No further error information was returned by the service.

I've not restarted it, I think we're good without it, especially since you can only restart all of the jobs (the whole build)?!

nip3o and others added 30 commits October 15, 2018 20:04

Restructured project.

6610551

Use a single node ID rather than a set for failed tests.

1d23bef

Use result.stderr in tests since result.errlines has changed behaviour.

33f1ff4

pytest 2.7 compatibility.

bd94954

add compat for pytest 3.7 and tox config for (some of) the versions i…

d9c428c

… could still get working

move files into the pytest file structure

c56d7ac

update for builtin plugin

63c01d1

draft doc

fd66f69

draft changelog

8c059db

authors

126bb07

we have a pr number now

4f652c9

linting

e773c8c

now pinned to pytest version

8187c14

grammar

d67d189

fix cacheprovider test

c25310d

cache is set by the cacheprovider

e478f66

Make --color more colorful

f694d8d

Merge pull request pytest-dev#4188 from svenstaro/make-it-more-colorful

43c3f59

Make --color more colorful

Merge pull request pytest-dev#4190 from nicoddemus/merge-master-into-…

b432f12

…features Merge master into features

Merge remote-tracking branch 'upstream/features' into davidszotten/st…

f947cb2

…epwise

Issue a warning when a fixture named 'request' is collected

7bb51b8

Fix pytest-dev#611

Merge pull request pytest-dev#4209 from nicoddemus/fixture-named-request

f30911d

Issue a warning when a fixture named 'request' is collected

minor: remove unused _shutil_rmtree_remove_writable

b51ee48

Merge pull request pytest-dev#4218 from blueyed/remove-_shutil_rmtree…

2a45851

…_remove_writable minor: remove unused _shutil_rmtree_remove_writable

Merge pull request pytest-dev#4225 from blueyed/collect-performance

e690e19

TerminalWriter: write "collecting" msg only once every 0.5s

Merge remote-tracking branch 'origin/master' into merge-master

eee8201

Merge pull request pytest-dev#4228 from blueyed/merge-master

66ce952

Merge master into features

functools.lru_cache does not exist on Python 2, apply for Python 3 only

1786ad1

blueyed and others added 14 commits October 31, 2018 23:13

changelog [ci skip]

65817dd

Merge pull request pytest-dev#4277 from blueyed/pdb-set_trace-capture…

017e504

…-msg pdb: improve msg about output capturing with set_trace

changelog [ci skip]

f8a2452

Merge pull request pytest-dev#4247 from blueyed/lru

a192e6b

_getconftestmodules: use functools.lru_cache

Merge pull request pytest-dev#4272 from blueyed/cache-non-default

f2cebce

cacheprovider: display cachedir also in non-verbose mode if customized

collection: performance: use optimized parts function

a41820f

Time: 8.53s => 5.73s

Minor refactor for readability

2b50911

Time: 5.73s => 5.88s/5.82s

Handle dirs only once

6ffa347

Time: 5.73s/5.88s => 5.36s (Before rebase: 4.86s => 4.45s)

paths: use set and isdisjoint

023e1c7

Time: 5.36s => 4.85s (before rebase: 4.45s => 3.55s)

Merge pull request pytest-dev#4237 from boxed/master

4cb838d

Performance fixes

Merge remote-tracking branch 'upstream/master' into release-3.10.0

6befdf8

Fix escape in code sample

1ec6805

Preparing release version 3.10.0

c2e906e

blueyed approved these changes Nov 3, 2018

View reviewed changes

RonnyPfannschmidt changed the base branch from features to master November 3, 2018 20:19

RonnyPfannschmidt changed the base branch from master to features November 3, 2018 20:19

RonnyPfannschmidt approved these changes Nov 3, 2018

View reviewed changes

Fixed linting

3d88d18

nicoddemus changed the base branch from features to master November 3, 2018 23:10

nicoddemus merged commit d1c9c54 into pytest-dev:master Nov 4, 2018

nicoddemus deleted the release-3.10.0 branch November 4, 2018 15:25

fzarifian mentioned this pull request Nov 4, 2018

Possible bug with the 3.10.0 release #4304

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release 3.10.0#4297

Release 3.10.0#4297
nicoddemus merged 64 commits intopytest-dev:masterfrom
nicoddemus:release-3.10.0

nicoddemus commented Nov 3, 2018

Uh oh!

blueyed commented Nov 3, 2018

Uh oh!

RonnyPfannschmidt commented Nov 3, 2018

Uh oh!

RonnyPfannschmidt commented Nov 3, 2018

Uh oh!

blueyed commented Nov 3, 2018

Uh oh!

RonnyPfannschmidt left a comment

Uh oh!

codecov bot commented Nov 3, 2018 •

edited

Loading

Uh oh!

nicoddemus commented Nov 3, 2018

Uh oh!

blueyed commented Nov 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

nicoddemus commented Nov 3, 2018

Uh oh!

blueyed commented Nov 3, 2018

Uh oh!

RonnyPfannschmidt commented Nov 3, 2018

Uh oh!

RonnyPfannschmidt commented Nov 3, 2018

Uh oh!

blueyed commented Nov 3, 2018

Uh oh!

RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nicoddemus commented Nov 3, 2018

Uh oh!

blueyed commented Nov 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov bot commented Nov 3, 2018 •

edited

Loading