Add semver utils, using semver library#1268
Closed
dazza-codes wants to merge 3 commits intopython-poetry:developfrom
Closed
Add semver utils, using semver library#1268dazza-codes wants to merge 3 commits intopython-poetry:developfrom
dazza-codes wants to merge 3 commits intopython-poetry:developfrom
Conversation
9 tasks
4e4e6cb to
06200a9
Compare
9667849 to
c51df8f
Compare
c51df8f to
fa82890
Compare
1a25012 to
5effab1
Compare
5bffc45 to
36c81d7
Compare
2 tasks
2 tasks
70442c0 to
aad50fb
Compare
- use the semver dependency - boolean check for a sem-ver string - filter and sort a sequence of sem-ver strings
aad50fb to
bbf869a
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
I'm kinda giving up on contributing to poetry
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The focus of this PR is only on sem-ver support and not full PEP-0440 support, see:
This implies that using
parse_single_contraintand the poetryVersionimplementations may not be compatible with the intention of supporting sem-ver (assuming poetry aims only to support PEP-0440, although the poetry philosophy seems to be not to impose a specific versioning strategy on the user). This PR is focused on sem-ver support (given that full sem-ver support is not 100% compatible with PEP-0440). The responsibility for sem-ver parsing belongs with thesemverdependency, to avoid recreating that wheel.checklist