Add constraint and version utils

[dazza-codes]

• Added tests for changed code.
• Updated documentation for changed code.
  • no docs required - internal utils only

Add constraint/version utils for boolean checks and sorting

• TODO notes about PEP-0440 vs. SEM-VER tests for TDD
• should be OPEN to adding PEP-0440 or SEM-VER config options down the road
• punting on PEP-0440 vs. SEM-VER implementations

[funkyfuture]

what problem is this solving and how does it relate to #1268?

[dazza-codes]

• @funkyfuture - good question and please LMK if you have similar work and or interests in this area - this is WIP to explore the existing poetry behavior and evaluate the specs/behavior for semver vs. PEP-0440 and it stands as an independent PR from Add semver utils, using semver library #1268 (because that PR stands alone with a focus on sem-ver utils and possibly future support for sem-ver config options, which all depend on having sem-ver utils in the first place). IF Add semver utils, using semver library #1268 is accepted, in some form, further work on this might proceed after a rebase on that stuff. Aside from Add semver utils, using semver library #1268, the initial intention of this work on this PR was to focus on PEP-0440 specs/behavior (and to distinguish between PEP-0440 and sem-ver specs/behavior). But, the PR morphed a bit and started to focus on some basic constraint/version utils and it might be in a form now that could be useful (so, in this form, it's not tagged WIP; the tests have some TODO items in there that might be taken up in follow-on PRs).
• apologies, the PR was mis-named as adding sem-ver utils (it's not that), so the PR is renamed now
• have not looked at any of the failing checks and will not do so until I pick this up at some later date, depending on time and further interest in it.

[funkyfuture]

this looks like duplicated code from semver/constraint_utils.py.

[dazza-codes]

The difference is that this uses Version.parse whereas the constraint code uses parse_single_constraint and, AFAIK, the constraints are not versions (although versions can be constraints, the distinction stands).

[funkyfuture]

i don't know these and they look strange to me.

[dazza-codes]

They are present elsewhere in poetry tests, this is a copy-n-paste and I don't know where they come from either. The point of this is just to use what poetry already has in it's tests on the methods wrapped by the boolean utils.

[funkyfuture]

same here.

[dazza-codes]

same comment as above, these are already in poetry tests; only added an n.a.n to be sure that it doesn't match a constraint because it's all chars but otherwise matches the pattern.

[dazza-codes]

@funkyfuture - thanks for code review, tried to address most of the requests, just a couple questions or tweaks remain; will follow-up if time permits.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dazza-codes]

Thanks for marking my contributions as stale. Despite my best efforts to contribute, the poetry review and merge cycles are too slow. This is discouraging for updating and further contributions.

[dimbleby]

I make no comment on whether this MR was stale or useful when the stalebot involved itself - but it certainly is stale now.

I expect that contributor has no interest in reviving this and it can now safely be closed.

[Secrus]

Closing as stale (and probably merging hell at this point).

[dazza-codes]

Yea, I've totally lost interest in contributing to poetry.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.