Skip to content

[WIP] Use packaging and compare PEP-0440 vs. SEM-VER vs. legacy etc#1390

Closed
dazza-codes wants to merge 3 commits into
python-poetry:developfrom
dazza-codes:use-packaging
Closed

[WIP] Use packaging and compare PEP-0440 vs. SEM-VER vs. legacy etc#1390
dazza-codes wants to merge 3 commits into
python-poetry:developfrom
dazza-codes:use-packaging

Conversation

@dazza-codes
Copy link
Copy Markdown
Contributor

@dazza-codes dazza-codes commented Sep 19, 2019

WIP to explore variants of version formatting and regex patterns in several version conventions and how they relate to poetry version and constraint tools

  • sem-ver
  • PEP-0440
  • poetry

This may never get merged, but it's worth throwing it up for the curious. I might need to revise one or more other PRs in the light of looking closer at these version standards. There is no intention in this to apply a specific versioning system on poetry (AFAIK, PEP-0440 is the only thing that poetry is supposed to implement and support).

TODO

checklist

  • Added tests for changed code.
  • Updated documentation for changed code.
    • don't know if it needs any (yet)

@dazza-codes dazza-codes changed the title [WIP] Use packaging [WIP] Use packaging and compare PEP-0440 vs. SEM-VER vs. legacy etc Sep 19, 2019
@dazza-codes dazza-codes force-pushed the use-packaging branch 2 times, most recently from 06d84e3 to 9fe83b1 Compare October 5, 2019 18:22
- boolean checks for a constraint/version string
- filter & sort a sequence of constraint/version strings

- WIP: try using packaging.version API
  - WIP: add tests for sorted versions
@stale
Copy link
Copy Markdown

stale Bot commented Dec 4, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Dec 4, 2019
@dazza-codes
Copy link
Copy Markdown
Contributor Author

The stale bot settings are going to kill stuff that might be useful

  • poetry review and merge cycles are too slow

@stale stale Bot removed the stale label Dec 5, 2019
@sdispater
Copy link
Copy Markdown
Member

@darrenleeweber I am sorry you feel that way but understand that doing code reviews takes time and most of it is dedicated to releasing the 1.0 release. I encourage people to create a Feature Request issue before starting to implement something to avoid the frustration of seeing your work being ignored or rejected because it does not align with the goals of the project.

Regarding your PR, I am failing to see what it's trying to solve. Is there an issue linked to it?

@dazza-codes
Copy link
Copy Markdown
Contributor Author

In this case, this PR is an exploration of various inconsistencies in version schemas and the work resulted from initial work on trying to support sem-ver for git dependencies (#925). While working on that, I've learned that several version schemas exist and this PR takes some steps to add more version-schema support to poetry, since poetry documentation indicates that any version schema should be supported. But, given that I already have a full-time job and that I'm discouraged about the contribution process, I'm not inclined to waste my time on pursuing this any further - just to be clear about where this stands.

@Secrus
Copy link
Copy Markdown
Member

Secrus commented May 21, 2022

This is no longer valid since the team has decided on sticking to pep440 and appropriate code exists in the codebase. Closing.

@Secrus Secrus closed this May 21, 2022
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants