[ET-VK] Move ParamsBuffer and StorageBuffer to standalone files#4120
Closed
junpi3 wants to merge 2 commits intogh/jorgep31415/88/basefrom
Closed
[ET-VK] Move ParamsBuffer and StorageBuffer to standalone files#4120junpi3 wants to merge 2 commits intogh/jorgep31415/88/basefrom
ParamsBuffer and StorageBuffer to standalone files#4120junpi3 wants to merge 2 commits intogh/jorgep31415/88/basefrom
Conversation
Includes the renaming of `UniformParamsBuffer` to `ParamsBuffer` for brevity. These objects aren't tightly coupled to `Context` and hence they are better placed in standalone files. Differential Revision: [D59281543](https://our.internmc.facebook.com/intern/diff/D59281543/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4120
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 73ab79b with merge base c572f9e ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59281543 |
This was referenced Jul 2, 2024
SS-JIA
approved these changes
Jul 2, 2024
…one files" Includes the renaming of `UniformParamsBuffer` to `ParamsBuffer` for brevity. These objects aren't tightly coupled to `Context` and hence they are better placed in standalone files. Differential Revision: [D59281543](https://our.internmc.facebook.com/intern/diff/D59281543/) [ghstack-poisoned]
junpi3
pushed a commit
that referenced
this pull request
Jul 2, 2024
Pull Request resolved: #4120 Includes the renaming of `UniformParamsBuffer` to `ParamsBuffer` for brevity. These objects aren't tightly coupled to `Context` and hence they are better placed in standalone files. ghstack-source-id: 232366091 @exported-using-ghexport Differential Revision: [D59281543](https://our.internmc.facebook.com/intern/diff/D59281543/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59281543 |
Contributor
|
This pull request has been merged in 96fb2bf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
vk_api/#4125Tensor.*to namespaceapi#4124StringUtil.handUtils.hintoutils/andVkUtils.h#4123api::utilstoutils#4122gen_vulkan_spv.pyout ofapi/#4121ParamsBufferandStorageBufferto standalone files #4120ParamsBindListtoDescriptor.*#4119Adapter.*#4118Context.h,Command.handUtils.h#4117Types.h#4116StringUtil.cpp#4115Includes the renaming of
UniformParamsBuffertoParamsBufferfor brevity.These objects aren't tightly coupled to
Contextand hence they are better placed in standalone files.Differential Revision: D59281543