[ET-VK] Order stdlib includes after ET includes#4127
Closed
junpi3 wants to merge 4 commits intogh/jorgep31415/94/basefrom
Closed
[ET-VK] Order stdlib includes after ET includes#4127junpi3 wants to merge 4 commits intogh/jorgep31415/94/basefrom
junpi3 wants to merge 4 commits intogh/jorgep31415/94/basefrom
Conversation
The convention in most files is: 1. Related header 2. Headers of the form ".h" (i.e. this project's other headers, further organize into blocks according to directory) 3. Headers of the form <> (i.e. standard libraries' headers) This change organizes files violating this convention by resolving #3. Differential Revision: [D59282477](https://our.internmc.facebook.com/intern/diff/D59282477/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4127
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 90a97e8 with merge base c839b9e ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Jul 2, 2024
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59282477 |
This was referenced Jul 2, 2024
This was referenced Jul 2, 2024
junpi3
pushed a commit
that referenced
this pull request
Jul 2, 2024
The convention in most files is: 1. Related header 2. Headers of the form ".h" (i.e. this project's other headers, further organize into blocks according to directory) 3. Headers of the form <> (i.e. standard libraries' headers) This change organizes files violating this convention by resolving #3. Differential Revision: [D59282477](https://our.internmc.facebook.com/intern/diff/D59282477/) ghstack-source-id: 232323113 Pull Request resolved: #4127
junpi3
changed the title
The convention in most files is: 1. Related header 2. Headers of the form ".h" (i.e. this project's other headers, further organize into blocks according to directory) 3. Headers of the form <> (i.e. standard libraries' headers) This change organizes files violating this convention by resolving #3. Differential Revision: [D59282477](https://our.internmc.facebook.com/intern/diff/D59282477/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59282477 |
junpi3
pushed a commit
that referenced
this pull request
Jul 2, 2024
Pull Request resolved: #4127 The convention in most files is: 1. Related header 2. Headers of the form ".h" (i.e. this project's other headers, further organize into blocks according to directory) 3. Headers of the form <> (i.e. standard libraries' headers) This change organizes files violating this convention by resolving #3. ghstack-source-id: 232327667 @exported-using-ghexport Differential Revision: [D59282477](https://our.internmc.facebook.com/intern/diff/D59282477/)
SS-JIA
approved these changes
Jul 2, 2024
The convention in most files is: 1. Related header 2. Headers of the form ".h" (i.e. this project's other headers, further organize into blocks according to directory) 3. Headers of the form <> (i.e. standard libraries' headers) This change organizes files violating this convention by resolving #3. Differential Revision: [D59282477](https://our.internmc.facebook.com/intern/diff/D59282477/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59282477 |
junpi3
pushed a commit
that referenced
this pull request
Jul 2, 2024
Pull Request resolved: #4127 The convention in most files is: 1. Related header 2. Headers of the form ".h" (i.e. this project's other headers, further organize into blocks according to directory) 3. Headers of the form <> (i.e. standard libraries' headers) This change organizes files violating this convention by resolving #3. ghstack-source-id: 232367488 @exported-using-ghexport Differential Revision: [D59282477](https://our.internmc.facebook.com/intern/diff/D59282477/)
The convention in most files is: 1. Related header 2. Headers of the form ".h" (i.e. this project's other headers, further organize into blocks according to directory) 3. Headers of the form <> (i.e. standard libraries' headers) This change organizes files violating this convention by resolving #3. Differential Revision: [D59282477](https://our.internmc.facebook.com/intern/diff/D59282477/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59282477 |
junpi3
pushed a commit
that referenced
this pull request
Jul 2, 2024
Pull Request resolved: #4127 The convention in most files is: 1. Related header 2. Headers of the form ".h" (i.e. this project's other headers, further organize into blocks according to directory) 3. Headers of the form <> (i.e. standard libraries' headers) This change organizes files violating this convention by resolving #3. ghstack-source-id: 232399398 @exported-using-ghexport Differential Revision: [D59282477](https://our.internmc.facebook.com/intern/diff/D59282477/)
Contributor
|
This pull request has been merged in 28a45cd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
vk_api/#4125The convention in most files is:
This change organizes files violating this convention by resolving #3.
Differential Revision: D59282477