[ET-VK] Organize StringUtil.h and Utils.h into utils/ and VkUtils.h#4123
Closed
junpi3 wants to merge 2 commits intogh/jorgep31415/91/basefrom
Closed
[ET-VK] Organize StringUtil.h and Utils.h into utils/ and VkUtils.h#4123junpi3 wants to merge 2 commits intogh/jorgep31415/91/basefrom
StringUtil.h and Utils.h into utils/ and VkUtils.h#4123junpi3 wants to merge 2 commits intogh/jorgep31415/91/basefrom
Conversation
…ils.h` Everything in `utils/` will take the `namespace vkcompute:::utils`; everything in `VkUtils.h` deals with the Vulkan API directly. Differential Revision: [D59281548](https://our.internmc.facebook.com/intern/diff/D59281548/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4123
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 78048f9 with merge base c572f9e ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59281548 |
This was referenced Jul 2, 2024
SS-JIA
approved these changes
Jul 2, 2024
…` and `VkUtils.h`" Everything in `utils/` will take the `namespace vkcompute:::utils`; everything in `VkUtils.h` deals with the Vulkan API directly. Differential Revision: [D59281548](https://our.internmc.facebook.com/intern/diff/D59281548/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D59281548 |
Contributor
|
This pull request has been merged in 0490402. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
…ils.h` Pull Request resolved: pytorch/executorch#4123 Everything in `utils/` will take the `namespace vkcompute:::utils`; everything in `VkUtils.h` deals with the Vulkan API directly. ghstack-source-id: 232367489 @exported-using-ghexport Differential Revision: [D59281548](https://our.internmc.facebook.com/intern/diff/D59281548/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
vk_api/#4125Tensor.*to namespaceapi#4124StringUtil.handUtils.hintoutils/andVkUtils.h#4123api::utilstoutils#4122gen_vulkan_spv.pyout ofapi/#4121ParamsBufferandStorageBufferto standalone files #4120ParamsBindListtoDescriptor.*#4119Adapter.*#4118Context.h,Command.handUtils.h#4117Types.h#4116StringUtil.cpp#4115Everything in
utils/will take thenamespace vkcompute:::utils; everything inVkUtils.hdeals with the Vulkan API directly.Differential Revision: D59281548