Skip to content

Update sidebar GitHub links and taxonomies#638

Merged
AaronCrawfis merged 4 commits into
v0.22from
aacrawfi/sidebar
Jul 7, 2023
Merged

Update sidebar GitHub links and taxonomies#638
AaronCrawfis merged 4 commits into
v0.22from
aacrawfi/sidebar

Conversation

@AaronCrawfis
Copy link
Copy Markdown

@AaronCrawfis AaronCrawfis commented Jul 5, 2023

This PR:

  1. Updates the GitHub Issues links to lead the user to the issue type chooser. This allows the user to select what type of issue they want instead of falling directly into a new issue
  2. Only displays the taxonomy cloud on the homepage. This prevents all the taxonomies from being shown on all pages.

Partially addresses #637

@AaronCrawfis AaronCrawfis requested a review from a team as a code owner July 5, 2023 19:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-638.westus2.azurestaticapps.net
Password: Radiu$1234

@AaronCrawfis AaronCrawfis linked an issue Jul 6, 2023 that may be closed by this pull request
{{ $context := .context }}
{{ $taxo := .taxo }}
{{ $title := .title }}
{{ if and (isset $context.Site.Taxonomies (lower $taxo)) ($context.Page.IsHome) }}
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main update here is the addition of and (....) ($context.Page.IsHome), where ... is existing logic that was already there before.

Adding the check for IsHome ensures that this only applies to the home page

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 6, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-638.westus2.azurestaticapps.net
Password: Radiu$1234

@AaronCrawfis AaronCrawfis merged commit 9056807 into v0.22 Jul 7, 2023
@AaronCrawfis AaronCrawfis deleted the aacrawfi/sidebar branch July 7, 2023 19:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 7, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-638.westus2.azurestaticapps.net
Password: Radiu$1234

willtsai added a commit that referenced this pull request Jul 7, 2023
* Create .gitattributes

* Add dropdown arrows to sections (#639)

* Add output for failed spellcheck runs (#641)

* Add output steps

* Add misspelled word

* Switch comment provider

* Clear comment on success

* Rename job

* Add concurrency control

* Fix spelling issue

* Disable section pages (#644)

* Disable section page nav

* Update section pages

* Apply suggestions from code review

Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Remove _ for leaf pages

---------

Co-authored-by: Will <28876888+willtsai@users.noreply.github.com>

* Update sidebar GitHub links and taxonomies (#638)

* Update GitHub issues links

* Only show tags/categories on home page

* v0.22 to edge upmerge

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

* v0.22 to edge upmerge

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>

---------

Signed-off-by: Will Tsai <28876888+willtsai@users.noreply.github.com>
Co-authored-by: Aaron Crawfis <Aaron.Crawfis@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting started page is challenging

1 participant